moparisthebest/k-9
1
0
Fork 0
mirror of https://github.com/moparisthebest/k-9 synced 2024-11-24 02:12:15 -05:00
Code Issues Releases Wiki Activity

Remove a bunch of stringification inside of string appends (per intellij)

Browse Source
This commit is contained in:
Jesse Vincent 2010-12-01 03:06:50 +00:00
parent 0677bd9e77
commit 75aa644a23
3 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/com/fsck/k9/controller/MessagingController.java
View File

@ -4618,7 +4618,7 @@ public class MessagingController implements Runnable
// Show From: address by default // Show From: address by default
if (!account.isAnIdentity(fromAddrs)) if (!account.isAnIdentity(fromAddrs))
{ {
messageNotice.append(from + ": " + subject); messageNotice.append(from).append(": ").append(subject);
} }
// show To: if the message was sent from me // show To: if the message was sent from me
else else
@ -4632,11 +4632,11 @@ public class MessagingController implements Runnable
String to = rcpts.length > 0 ? rcpts[0].toFriendly().toString() : null; String to = rcpts.length > 0 ? rcpts[0].toFriendly().toString() : null;
if (to != null) if (to != null)
{ {
messageNotice.append(String.format(context.getString(R.string.message_to_fmt), to) +": "+subject); messageNotice.append(String.format(context.getString(R.string.message_to_fmt), to)).append(": ").append(subject);
} }
else else
{ {
messageNotice.append(context.getString(R.string.general_no_sender) + ": "+subject); messageNotice.append(context.getString(R.string.general_no_sender)).append(": ").append(subject);
} }

2
src/com/fsck/k9/mail/store/LocalStore.java
View File

@ -1425,7 +1425,7 @@ public class LocalStore extends Store implements Serializable, LocalStoreMigrati
{ {
whereClause.append(" OR "); whereClause.append(" OR ");
} }
whereClause.append(queryField + " LIKE ? "); whereClause.append(queryField).append(" LIKE ? ");
args.add(likeString); args.add(likeString);
anyAdded = true; anyAdded = true;
} }

22
src/com/fsck/k9/mail/store/WebDavStore.java
View File

@ -386,7 +386,7 @@ public class WebDavStore extends Store
buffer.append("<?xml version='1.0' ?>"); buffer.append("<?xml version='1.0' ?>");
buffer.append("<a:searchrequest xmlns:a='DAV:'><a:sql>\r\n"); buffer.append("<a:searchrequest xmlns:a='DAV:'><a:sql>\r\n");
buffer.append("SELECT \"DAV:uid\", \"DAV:ishidden\"\r\n"); buffer.append("SELECT \"DAV:uid\", \"DAV:ishidden\"\r\n");
buffer.append(" FROM SCOPE('hierarchical traversal of \""+this.mUrl+"\"')\r\n"); buffer.append(" FROM SCOPE('hierarchical traversal of \"").append(this.mUrl).append("\"')\r\n");
buffer.append(" WHERE \"DAV:ishidden\"=False AND \"DAV:isfolder\"=True\r\n"); buffer.append(" WHERE \"DAV:ishidden\"=False AND \"DAV:isfolder\"=True\r\n");
buffer.append("</a:sql></a:searchrequest>\r\n"); buffer.append("</a:sql></a:searchrequest>\r\n");
return buffer.toString(); return buffer.toString();
@ -399,7 +399,7 @@ public class WebDavStore extends Store
buffer.append("<a:searchrequest xmlns:a='DAV:'><a:sql>\r\n"); buffer.append("<a:searchrequest xmlns:a='DAV:'><a:sql>\r\n");
buffer.append("SELECT \"DAV:visiblecount\"\r\n"); buffer.append("SELECT \"DAV:visiblecount\"\r\n");
buffer.append(" FROM \"\"\r\n"); buffer.append(" FROM \"\"\r\n");
buffer.append(" WHERE \"DAV:ishidden\"=False AND \"DAV:isfolder\"=False AND \"urn:schemas:httpmail:read\"="+messageState+"\r\n"); buffer.append(" WHERE \"DAV:ishidden\"=False AND \"DAV:isfolder\"=False AND \"urn:schemas:httpmail:read\"=").append(messageState).append("\r\n");
buffer.append(" GROUP BY \"DAV:ishidden\"\r\n"); buffer.append(" GROUP BY \"DAV:ishidden\"\r\n");
buffer.append("</a:sql></a:searchrequest>\r\n"); buffer.append("</a:sql></a:searchrequest>\r\n");
return buffer.toString(); return buffer.toString();
@ -431,7 +431,7 @@ public class WebDavStore extends Store
{ {
buffer.append(" OR "); buffer.append(" OR ");
} }
buffer.append(" \"DAV:uid\"='"+uids[i]+"' "); buffer.append(" \"DAV:uid\"='").append(uids[i]).append("' ");
} }
buffer.append("\r\n"); buffer.append("\r\n");
buffer.append("</a:sql></a:searchrequest>\r\n"); buffer.append("</a:sql></a:searchrequest>\r\n");
@ -465,7 +465,7 @@ public class WebDavStore extends Store
buffer.append(" OR "); buffer.append(" OR ");
} }
buffer.append(" \"DAV:uid\"='"+uids[i]+"' "); buffer.append(" \"DAV:uid\"='").append(uids[i]).append("' ");
} }
buffer.append("\r\n"); buffer.append("\r\n");
@ -493,7 +493,7 @@ public class WebDavStore extends Store
{ {
buffer.append(" OR "); buffer.append(" OR ");
} }
buffer.append(" \"DAV:uid\"='"+uids[i]+"' "); buffer.append(" \"DAV:uid\"='").append(uids[i]).append("' ");
} }
buffer.append("\r\n"); buffer.append("\r\n");
buffer.append("</a:sql></a:searchrequest>\r\n"); buffer.append("</a:sql></a:searchrequest>\r\n");
@ -508,12 +508,12 @@ public class WebDavStore extends Store
buffer.append("<a:target>\r\n"); buffer.append("<a:target>\r\n");
for (String url : urls) for (String url : urls)
{ {
buffer.append(" <a:href>"+url+"</a:href>\r\n"); buffer.append(" <a:href>").append(url).append("</a:href>\r\n");
} }
buffer.append("</a:target>\r\n"); buffer.append("</a:target>\r\n");
buffer.append("<a:set>\r\n"); buffer.append("<a:set>\r\n");
buffer.append(" <a:prop>\r\n"); buffer.append(" <a:prop>\r\n");
buffer.append(" <b:read>" + (read ? "1" : "0") + "</b:read>\r\n"); buffer.append(" <b:read>").append(read ? "1" : "0").append("</b:read>\r\n");
buffer.append(" </a:prop>\r\n"); buffer.append(" </a:prop>\r\n");
buffer.append("</a:set>\r\n"); buffer.append("</a:set>\r\n");
buffer.append("</a:propertyupdate>\r\n"); buffer.append("</a:propertyupdate>\r\n");
@ -530,15 +530,15 @@ public class WebDavStore extends Store
String action = (isMove ? "move" : "copy"); String action = (isMove ? "move" : "copy");
StringBuffer buffer = new StringBuffer(600); StringBuffer buffer = new StringBuffer(600);
buffer.append("<?xml version='1.0' ?>\r\n"); buffer.append("<?xml version='1.0' ?>\r\n");
buffer.append("<a:" + action + " xmlns:a='DAV:' xmlns:b='urn:schemas:httpmail:'>\r\n"); buffer.append("<a:").append(action).append(" xmlns:a='DAV:' xmlns:b='urn:schemas:httpmail:'>\r\n");
buffer.append("<a:target>\r\n"); buffer.append("<a:target>\r\n");
for (String url : urls) for (String url : urls)
{ {
buffer.append(" <a:href>"+url+"</a:href>\r\n"); buffer.append(" <a:href>").append(url).append("</a:href>\r\n");
} }
buffer.append("</a:target>\r\n"); buffer.append("</a:target>\r\n");
buffer.append("</a:" + action + ">\r\n"); buffer.append("</a:").append(action).append(">\r\n");
return buffer.toString(); return buffer.toString();
} }
@ -1547,7 +1547,7 @@ public class WebDavStore extends Store
while ((tempText = reader.readLine()) != null && while ((tempText = reader.readLine()) != null &&
(currentLines < lines)) (currentLines < lines))
{ {
buffer.append(tempText+"\r\n"); buffer.append(tempText).append("\r\n");
currentLines++; currentLines++;
} }