From 65d2de0fccbfcc465debd32bb57b88e3519066ad Mon Sep 17 00:00:00 2001 From: cketti Date: Sat, 3 Jan 2015 03:04:44 +0100 Subject: [PATCH] Fix bug caused by edge case of Math.abs() --- .../java/com/fsck/k9/activity/misc/ContactPictureLoader.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/k9mail/src/main/java/com/fsck/k9/activity/misc/ContactPictureLoader.java b/k9mail/src/main/java/com/fsck/k9/activity/misc/ContactPictureLoader.java index ffd06becc..f99aa8642 100644 --- a/k9mail/src/main/java/com/fsck/k9/activity/misc/ContactPictureLoader.java +++ b/k9mail/src/main/java/com/fsck/k9/activity/misc/ContactPictureLoader.java @@ -156,8 +156,8 @@ public class ContactPictureLoader { } int val = address.hashCode(); - int rgb = CONTACT_DUMMY_COLORS_ARGB[Math.abs(val) % CONTACT_DUMMY_COLORS_ARGB.length]; - return rgb; + int colorIndex = (val & Integer.MAX_VALUE) % CONTACT_DUMMY_COLORS_ARGB.length; + return CONTACT_DUMMY_COLORS_ARGB[colorIndex]; } private String calcUnknownContactLetter(Address address) {