moparisthebest/k-9
1
0
Fork 0
mirror of https://github.com/moparisthebest/k-9 synced 2024-11-27 19:52:17 -05:00
Code Issues Releases Wiki Activity

Replace MessageList's outdated message-passing mechanism with runOnUiThread for improved code clarity and performance.

Browse Source
This commit is contained in:
Jesse Vincent 2009-12-15 02:51:25 +00:00
parent 7b811e45a1
commit 647dc827d8
1 changed files with 92 additions and 127 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

195
src/com/fsck/k9/activity/MessageList.java
View File

@ -134,40 +134,13 @@ public class MessageList
class MessageListHandler extends Handler class MessageListHandler extends Handler
{ {
private static final int MSG_PROGRESS = 2; public void removeMessage(final List<MessageInfoHolder> messages)
private static final int MSG_FOLDER_LOADING = 7;
private static final int MSG_ADD_MESSAGE = 10;
private static final int MSG_REMOVE_MESSAGE = 11;
private static final int MSG_SORT_MESSAGES = 12;
private static final int MSG_FOLDER_SYNCING = 18;
private static final int MSG_SENDING_OUTBOX = 19;
@Override
public void handleMessage(android.os.Message msg)
{ {
switch (msg.what)
runOnUiThread(new Runnable()
{ {
case MSG_PROGRESS: public void run()
showProgressIndicator(msg.arg1 != 0);
break;
case MSG_SORT_MESSAGES:
synchronized (mAdapter.messages)
{ {
Collections.sort(mAdapter.messages);
}
mAdapter.notifyDataSetChanged();
break;
case MSG_REMOVE_MESSAGE:
{
List<MessageInfoHolder> messages = (List<MessageInfoHolder>)((Object[]) msg.obj)[0];
for (MessageInfoHolder message : messages) for (MessageInfoHolder message : messages)
{ {
if (message != null && message.selected && mSelectedCount > 0) if (message != null && message.selected && mSelectedCount > 0)
@ -178,14 +151,20 @@ public class MessageList
} }
mAdapter.notifyDataSetChanged(); mAdapter.notifyDataSetChanged();
configureBatchButtons(); configureBatchButtons();
break; }
});
} }
case MSG_ADD_MESSAGE: public void addMessages(List<MessageInfoHolder> messages)
{ {
boolean wasEmpty = mAdapter.messages.isEmpty(); boolean wasEmpty = mAdapter.messages.isEmpty();
List<MessageInfoHolder> messages = (List<MessageInfoHolder>)((Object[]) msg.obj)[0]; for (final MessageInfoHolder message : messages)
for (MessageInfoHolder message : messages) {
runOnUiThread(new Runnable()
{
public void run()
{ {
int index = Collections.binarySearch(mAdapter.messages, message); int index = Collections.binarySearch(mAdapter.messages, message);
@ -195,46 +174,90 @@ public class MessageList
} }
mAdapter.messages.add(index, message); mAdapter.messages.add(index, message);
}
});
} }
if (wasEmpty) if (wasEmpty)
{
runOnUiThread(new Runnable()
{
public void run()
{
mListView.setSelection(0); mListView.setSelection(0);
mAdapter.notifyDataSetChanged(); mAdapter.notifyDataSetChanged();
break; }
});
}
}
private void sortMessages()
{
runOnUiThread(new Runnable()
{
public void run()
{
synchronized (mAdapter.messages)
{
Collections.sort(mAdapter.messages);
}
mAdapter.notifyDataSetChanged();
}
});
} }
case MSG_FOLDER_SYNCING: public void folderLoading(String folder, boolean loading)
{ {
String folderName = (String)((Object[]) msg.obj)[0];
String dispString;
dispString = mAccount.getDescription();
if (folderName != null) if (mCurrentFolder.name == folder)
{
mCurrentFolder.loading = loading;
}
}
public void progress(final boolean progress)
{
runOnUiThread(new Runnable()
{
public void run()
{
showProgressIndicator(progress);
}
});
}
public void folderSyncing(final String folder)
{
runOnUiThread(new Runnable()
{
public void run()
{
String dispString = mAccount.getDescription();
if (folder != null)
{ {
dispString += " (" + getString(R.string.status_loading) dispString += " (" + getString(R.string.status_loading)
+ folderName + ")"; + folder + ")";
} }
setTitle(dispString); setTitle(dispString);
}
break; });
} }
case MSG_FOLDER_LOADING: public void sendingOutbox(final boolean sending)
{ {
FolderInfoHolder folder = mCurrentFolder;
if (folder != null)
{
folder.loading = msg.arg1 != 0;
}
break;
}
case MSG_SENDING_OUTBOX:
runOnUiThread(new Runnable()
{ {
boolean sending = (msg.arg1 != 0); public void run()
String dispString; {
dispString = mAccount.getDescription(); String dispString = mAccount.getDescription();
if (sending) if (sending)
{ {
@ -242,67 +265,9 @@ public class MessageList
} }
setTitle(dispString); setTitle(dispString);
break;
} }
});
default:
super.handleMessage(msg);
}
}
public void removeMessage(List<MessageInfoHolder> messages)
{
android.os.Message msg = new android.os.Message();
msg.what = MSG_REMOVE_MESSAGE;
msg.obj = new Object[] { messages };
sendMessage(msg);
}
public void addMessages(List<MessageInfoHolder> messages)
{
android.os.Message msg = new android.os.Message();
msg.what = MSG_ADD_MESSAGE;
msg.obj = new Object[] { messages };
sendMessage(msg);
}
private void sortMessages()
{
sendEmptyMessage(MSG_SORT_MESSAGES);
}
public void folderLoading(String folder, boolean loading)
{
android.os.Message msg = new android.os.Message();
msg.what = MSG_FOLDER_LOADING;
msg.arg1 = loading ? 1 : 0;
msg.obj = folder;
sendMessage(msg);
}
public void progress(boolean progress)
{
android.os.Message msg = new android.os.Message();
msg.what = MSG_PROGRESS;
msg.arg1 = progress ? 1 : 0;
sendMessage(msg);
}
public void folderSyncing(String folder)
{
android.os.Message msg = new android.os.Message();
msg.what = MSG_FOLDER_SYNCING;
msg.obj = new String[] { folder };
sendMessage(msg);
}
public void sendingOutbox(boolean sending)
{
android.os.Message msg = new android.os.Message();
msg.what = MSG_SENDING_OUTBOX;
msg.arg1 = sending ? 1 : 0;
sendMessage(msg);
} }
} }