From 4aaabddfa5282a9fd02449ee85aac5e80f0e5091 Mon Sep 17 00:00:00 2001
From: Andrew Chen <achen.code@gmail.com>
Date: Tue, 8 Feb 2011 18:54:07 -0800
Subject: [PATCH 01/24] astyle

---
 res/layout/message_view_scrolling_buttons.xml | 162 +++++++++---------
 1 file changed, 81 insertions(+), 81 deletions(-)

diff --git a/res/layout/message_view_scrolling_buttons.xml b/res/layout/message_view_scrolling_buttons.xml
index 632cd7315..426ee800c 100644
--- a/res/layout/message_view_scrolling_buttons.xml
+++ b/res/layout/message_view_scrolling_buttons.xml
@@ -1,88 +1,88 @@
 <?xml version="1.0" encoding="utf-8"?>
 <merge xmlns:android="http://schemas.android.com/apk/res/android">
-            <LinearLayout
-                android:id="@+id/extra_buttons"
-                android:orientation="horizontal"
-                android:layout_width="fill_parent"
+    <LinearLayout
+            android:id="@+id/extra_buttons"
+            android:orientation="horizontal"
+            android:layout_width="fill_parent"
+            android:layout_height="wrap_content"
+            android:paddingBottom="2dip"
+            android:gravity="center_vertical">
+        <Button
+                android:id="@+id/reply"
+                android:text="@string/reply_action"
                 android:layout_height="wrap_content"
-                android:paddingBottom="2dip"
-                android:gravity="center_vertical">
-                <Button
-                    android:id="@+id/reply"
-                    android:text="@string/reply_action"
-                    android:layout_height="wrap_content"
-                    android:layout_width="0dip"
-                    android:layout_weight="1" />
-                <Button
-                    android:id="@+id/reply_all"
-                    android:text="@string/reply_all_action"
-                    android:layout_height="wrap_content"
-                    android:layout_width="0dip"
-                    android:layout_weight="1" />
-                <Button
-                    android:id="@+id/forward"
-                    android:text="@string/forward_action"
-                    android:layout_height="wrap_content"
-                    android:layout_width="0dip"
-                    android:layout_weight="1" />
-            </LinearLayout>
-            <LinearLayout
-                android:id="@+id/scrolling_move_buttons"
-                android:orientation="horizontal"
-                android:layout_width="fill_parent"
+                android:layout_width="0dip"
+                android:layout_weight="1"/>
+        <Button
+                android:id="@+id/reply_all"
+                android:text="@string/reply_all_action"
                 android:layout_height="wrap_content"
-                android:paddingBottom="2dip"
-                android:gravity="center_vertical">
-                <Button
-                    android:id="@+id/archive_scrolling"
-                    android:text="@string/message_view_archive_action"
-                    android:layout_height="wrap_content"
-                    android:layout_width="0dip"
-                    android:layout_weight="1" />
-
-                <Button
-                    android:id="@+id/move_scrolling"
-                    android:text="@string/message_view_move_action"
-                    android:layout_height="wrap_content"
-                    android:layout_width="0dip"
-                    android:layout_weight="1" />
-
-                <Button
-                    android:id="@+id/spam_scrolling"
-                    android:text="@string/message_view_spam_action"
-                    android:layout_height="wrap_content"
-                    android:layout_width="0dip"
-                    android:layout_weight="1" />
-            </LinearLayout>
-            <LinearLayout
-                android:id="@+id/scrolling_buttons"
-                android:orientation="horizontal"
-                android:layout_width="fill_parent"
+                android:layout_width="0dip"
+                android:layout_weight="1"/>
+        <Button
+                android:id="@+id/forward"
+                android:text="@string/forward_action"
                 android:layout_height="wrap_content"
-                android:gravity="center_vertical">
-                <Button
-                    android:id="@+id/previous_scrolling"
-                    android:text="@string/message_view_prev_action"
-                    android:contentDescription="@string/previous_action"
-                    android:textSize="35dip"
-                    android:padding="0dip"
-                    android:layout_height="wrap_content"
-                    android:layout_width="0dip"
-                    android:layout_weight="1" />
+                android:layout_width="0dip"
+                android:layout_weight="1"/>
+    </LinearLayout>
+    <LinearLayout
+            android:id="@+id/scrolling_move_buttons"
+            android:orientation="horizontal"
+            android:layout_width="fill_parent"
+            android:layout_height="wrap_content"
+            android:paddingBottom="2dip"
+            android:gravity="center_vertical">
+        <Button
+                android:id="@+id/archive_scrolling"
+                android:text="@string/message_view_archive_action"
+                android:layout_height="wrap_content"
+                android:layout_width="0dip"
+                android:layout_weight="1"/>
 
-                <ImageButton
-                    android:id="@+id/delete_scrolling"
-                    android:layout_height="wrap_content"
-                    android:src="@drawable/ic_button_delete"
-                    android:layout_width="0dip"
-                    android:layout_weight="1" />
-               <Button
-                    android:id="@+id/next_scrolling"
-                    android:padding="0dip"
-                    android:text="@string/message_view_next_action"
-                    android:textSize="35dip"
-                    android:layout_height="wrap_content"
-                    android:layout_width="0dip"
-                    android:layout_weight="1" />
-            </LinearLayout>
+        <Button
+                android:id="@+id/move_scrolling"
+                android:text="@string/message_view_move_action"
+                android:layout_height="wrap_content"
+                android:layout_width="0dip"
+                android:layout_weight="1"/>
+
+        <Button
+                android:id="@+id/spam_scrolling"
+                android:text="@string/message_view_spam_action"
+                android:layout_height="wrap_content"
+                android:layout_width="0dip"
+                android:layout_weight="1"/>
+    </LinearLayout>
+    <LinearLayout
+            android:id="@+id/scrolling_buttons"
+            android:orientation="horizontal"
+            android:layout_width="fill_parent"
+            android:layout_height="wrap_content"
+            android:gravity="center_vertical">
+        <Button
+                android:id="@+id/previous_scrolling"
+                android:text="@string/message_view_prev_action"
+                android:contentDescription="@string/previous_action"
+                android:textSize="35dip"
+                android:padding="0dip"
+                android:layout_height="wrap_content"
+                android:layout_width="0dip"
+                android:layout_weight="1"/>
+
+        <ImageButton
+                android:id="@+id/delete_scrolling"
+                android:layout_height="wrap_content"
+                android:src="@drawable/ic_button_delete"
+                android:layout_width="0dip"
+                android:layout_weight="1"/>
+        <Button
+                android:id="@+id/next_scrolling"
+                android:padding="0dip"
+                android:text="@string/message_view_next_action"
+                android:textSize="35dip"
+                android:layout_height="wrap_content"
+                android:layout_width="0dip"
+                android:layout_weight="1"/>
+    </LinearLayout>
 </merge>

From 7e824fc748eaf57ec847ff3f010ee6961cf88918 Mon Sep 17 00:00:00 2001
From: cketti <cketti@gmail.com>
Date: Wed, 9 Feb 2011 06:58:06 +0100
Subject: [PATCH 02/24] Log error message when switching local storage provider
 fails.

---
 src/com/fsck/k9/Account.java | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/com/fsck/k9/Account.java b/src/com/fsck/k9/Account.java
index cf8a9be84..f7c58ecb4 100644
--- a/src/com/fsck/k9/Account.java
+++ b/src/com/fsck/k9/Account.java
@@ -683,6 +683,8 @@ public class Account implements BaseAccount {
                 switchLocalStorage(id);
                 successful = true;
             } catch (MessagingException e) {
+                Log.e(K9.LOG_TAG, "Switching local storage provider from " +
+                        mLocalStorageProviderId + " to " + id + " failed.", e);
             } finally {
                 // if migration to/from SD-card failed once, it will fail again.
                 if (!successful) {

From 14abb68772217d9b8dbd130c438c6682a472ecb0 Mon Sep 17 00:00:00 2001
From: cketti <cketti@gmail.com>
Date: Wed, 9 Feb 2011 07:08:10 +0100
Subject: [PATCH 03/24] Get rid of the "Fwd: " prefix when sharing a message.
 Add recipients to the intent ("To:" -> EXTRA_EMAIL, "CC:" -> EXTRA_CC)

---
 .../k9/controller/MessagingController.java     | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/src/com/fsck/k9/controller/MessagingController.java b/src/com/fsck/k9/controller/MessagingController.java
index bb116ac63..d053443fe 100644
--- a/src/com/fsck/k9/controller/MessagingController.java
+++ b/src/com/fsck/k9/controller/MessagingController.java
@@ -46,6 +46,7 @@ import com.fsck.k9.mail.Flag;
 import com.fsck.k9.mail.Folder;
 import com.fsck.k9.mail.Folder.FolderType;
 import com.fsck.k9.mail.Folder.OpenMode;
+import com.fsck.k9.mail.Message.RecipientType;
 import com.fsck.k9.mail.Message;
 import com.fsck.k9.mail.MessagingException;
 import com.fsck.k9.mail.Part;
@@ -3469,7 +3470,22 @@ public class MessagingController implements Runnable {
                     if (quotedText != null) {
                         msg.putExtra(Intent.EXTRA_TEXT, quotedText);
                     }
-                    msg.putExtra(Intent.EXTRA_SUBJECT, "Fwd: " + message.getSubject());
+                    msg.putExtra(Intent.EXTRA_SUBJECT, message.getSubject());
+
+                    Address[] to = message.getRecipients(RecipientType.TO);
+                    String[] recipientsTo = new String[to.length];
+                    for (int i = 0; i < to.length; i++) {
+                        recipientsTo[i] = to[i].toString();
+                    }
+                    msg.putExtra(Intent.EXTRA_EMAIL, recipientsTo);
+
+                    Address[] cc = message.getRecipients(RecipientType.CC);
+                    String[] recipientsCc = new String[cc.length];
+                    for (int i = 0; i < cc.length; i++) {
+                        recipientsCc[i] = cc[i].toString();
+                    }
+                    msg.putExtra(Intent.EXTRA_CC, recipientsCc);
+
                     msg.setType("text/plain");
                     context.startActivity(Intent.createChooser(msg, context.getString(R.string.send_alternate_chooser_title)));
                 } catch (MessagingException me) {

From bece2f55a0e6e760831fb6a0344062f0eb7b442e Mon Sep 17 00:00:00 2001
From: Jesse Vincent <jesse@bestpractical.com>
Date: Wed, 9 Feb 2011 07:47:21 -0500
Subject: [PATCH 04/24] Bumped manifest to 3.702

---
 AndroidManifest.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/AndroidManifest.xml b/AndroidManifest.xml
index 11497724d..95099cc0f 100644
--- a/AndroidManifest.xml
+++ b/AndroidManifest.xml
@@ -1,8 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest
     xmlns:android="http://schemas.android.com/apk/res/android"
-    android:versionCode="13001"
-    android:versionName="3.701" package="com.fsck.k9"
+    android:versionCode="13002"
+    android:versionName="3.702" package="com.fsck.k9"
     >
     <uses-sdk
        android:minSdkVersion="3"

From a51daf9798d1e273307f985e6530edf0b4ec900a Mon Sep 17 00:00:00 2001
From: Andrew Chen <achen.code@gmail.com>
Date: Wed, 9 Feb 2011 11:06:01 -0800
Subject: [PATCH 05/24] Use interface Map.Entry.

---
 src/com/fsck/k9/mail/transport/SmtpTransport.java | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/com/fsck/k9/mail/transport/SmtpTransport.java b/src/com/fsck/k9/mail/transport/SmtpTransport.java
index b541b4da6..6954b7ad0 100644
--- a/src/com/fsck/k9/mail/transport/SmtpTransport.java
+++ b/src/com/fsck/k9/mail/transport/SmtpTransport.java
@@ -27,10 +27,8 @@ import java.security.MessageDigest;
 import java.security.NoSuchAlgorithmException;
 import java.security.SecureRandom;
 import org.apache.commons.codec.binary.Hex;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.HashMap;
-import java.util.List;
+
+import java.util.*;
 
 public class SmtpTransport extends Transport {
     public static final int CONNECTION_SECURITY_NONE = 0;
@@ -284,7 +282,7 @@ public class SmtpTransport extends Transport {
             addressesOfCharset.add(addressString);
         }
 
-        for (HashMap.Entry<String, ArrayList<String>> charsetAddressesMapEntry :
+        for (Map.Entry<String, ArrayList<String>> charsetAddressesMapEntry :
                 charsetAddressesMap.entrySet()) {
             String charset = charsetAddressesMapEntry.getKey();
             ArrayList<String> addressesOfCharset = charsetAddressesMapEntry.getValue();

From 673b1fdf944e350f0decbc20e3510837803d8dba Mon Sep 17 00:00:00 2001
From: mwolschon <mwolschon@dwmu-6tbpt3j.united.domain>
Date: Thu, 10 Feb 2011 07:59:29 +0100
Subject: [PATCH 06/24] bugfix for
 https://github.com/k9mail/k-9/commit/2e981afaed1d97a71ab5b06cf466a758b6aca06c
 ( forgot a call to finish() )

---
 src/com/fsck/k9/activity/Accounts.java | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/com/fsck/k9/activity/Accounts.java b/src/com/fsck/k9/activity/Accounts.java
index df48a358a..59814a6e2 100644
--- a/src/com/fsck/k9/activity/Accounts.java
+++ b/src/com/fsck/k9/activity/Accounts.java
@@ -299,6 +299,7 @@ public class Accounts extends K9ListActivity implements OnItemClickListener, OnC
             finish();
         } else if (startup && accounts.length == 1 && onOpenAccount(accounts[0])) {
             // fall through to "else" if !onOpenAccount()
+        	finish();
         } else {
             requestWindowFeature(Window.FEATURE_INDETERMINATE_PROGRESS);
             requestWindowFeature(Window.FEATURE_PROGRESS);

From 850aee9008c79354f4aa9e861593333770240de6 Mon Sep 17 00:00:00 2001
From: Jesse Vincent <jesse@bestpractical.com>
Date: Thu, 10 Feb 2011 12:03:10 -0500
Subject: [PATCH 07/24] Move as much of the Apg code as possible to its own
 "view" class (should eventually be a fragment?)

---
 res/layout/message_view_crypto_layout.xml   |   4 +-
 src/com/fsck/k9/activity/MessageView.java   | 165 ++++--------------
 src/com/fsck/k9/crypto/Apg.java             |   6 +-
 src/com/fsck/k9/view/MessageCryptoView.java | 176 ++++++++++++++++++++
 4 files changed, 213 insertions(+), 138 deletions(-)
 create mode 100644 src/com/fsck/k9/view/MessageCryptoView.java

diff --git a/res/layout/message_view_crypto_layout.xml b/res/layout/message_view_crypto_layout.xml
index edab3f1e3..a5bda33a5 100644
--- a/res/layout/message_view_crypto_layout.xml
+++ b/res/layout/message_view_crypto_layout.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
-<LinearLayout
+<com.fsck.k9.view.MessageCryptoView
     xmlns:android="http://schemas.android.com/apk/res/android"
     android:id="@+id/layout_decrypt"
     android:orientation="horizontal"
@@ -55,4 +55,4 @@
         android:layout_width="0dip"
         android:layout_height="wrap_content"
         android:layout_weight="1"/>
-</LinearLayout>
+</com.fsck.k9.view.MessageCryptoView>
diff --git a/src/com/fsck/k9/activity/MessageView.java b/src/com/fsck/k9/activity/MessageView.java
index 87fe292e4..f54a4d86d 100644
--- a/src/com/fsck/k9/activity/MessageView.java
+++ b/src/com/fsck/k9/activity/MessageView.java
@@ -20,7 +20,6 @@ import android.widget.*;
 import com.fsck.k9.*;
 import com.fsck.k9.controller.MessagingController;
 import com.fsck.k9.controller.MessagingListener;
-import com.fsck.k9.crypto.CryptoProvider;
 import com.fsck.k9.crypto.PgpData;
 import com.fsck.k9.helper.Contacts;
 import com.fsck.k9.helper.Utility;
@@ -34,6 +33,7 @@ import com.fsck.k9.view.AttachmentView;
 import com.fsck.k9.view.MessageWebView;
 import com.fsck.k9.view.ToggleScrollView;
 import com.fsck.k9.view.MessageHeader;
+import com.fsck.k9.view.MessageCryptoView;
 
 import java.io.Serializable;
 import java.util.*;
@@ -46,12 +46,7 @@ public class MessageView extends K9Activity implements OnClickListener {
     private static final String STATE_PGP_DATA = "pgpData";
     private static final int ACTIVITY_CHOOSE_FOLDER_MOVE = 1;
     private static final int ACTIVITY_CHOOSE_FOLDER_COPY = 2;
-    private View mDecryptLayout;
-    private Button mDecryptButton;
-    private LinearLayout mCryptoSignatureLayout = null;
-    private ImageView mCryptoSignatureStatusImage = null;
-    private TextView mCryptoSignatureUserId = null;
-    private TextView mCryptoSignatureUserIdRest = null;
+    private MessageCryptoView mCryptoView;
     private MessageWebView mMessageContentView;
     private boolean mScreenReaderEnabled;
     private AccessibleWebView mAccessibleMessageContentView;
@@ -71,7 +66,6 @@ public class MessageView extends K9Activity implements OnClickListener {
     private MessageReference mMessageReference;
     private ArrayList<MessageReference> mMessageReferences;
     private Message mMessage;
-    private PgpData mPgpData = null;
     private static final int PREVIOUS = 1;
     private static final int NEXT = 2;
     private int mLastDirection = PREVIOUS;
@@ -377,6 +371,9 @@ public class MessageView extends K9Activity implements OnClickListener {
         mAttachments = (LinearLayout) findViewById(R.id.attachments);
 
         mHeaderContainer = (MessageHeader) findViewById(R.id.header_container);
+        mCryptoView = (MessageCryptoView) findViewById(R.id.layout_decrypt);
+        mCryptoView.setActivity(this);
+        mCryptoView.setupChildViews();
 
         mScreenReaderEnabled = isScreenReaderActive();
         if (mScreenReaderEnabled) {
@@ -387,15 +384,13 @@ public class MessageView extends K9Activity implements OnClickListener {
             mMessageContentView.setVisibility(View.VISIBLE);
         }
 
-        setupDecryptLayout();
 
         setTitle("");
         Intent intent = getIntent();
         Uri uri = intent.getData();
         if (icicle != null) {
             restoreMessageReferences(icicle);
-            mPgpData = (PgpData) icicle.getSerializable(STATE_PGP_DATA);
-            updateDecryptLayout();
+            mCryptoView.setCryptoData((PgpData) icicle.getSerializable(STATE_PGP_DATA));
         } else {
             if (uri == null) {
                 restoreMessageReferencesExtra(intent);
@@ -532,33 +527,6 @@ public class MessageView extends K9Activity implements OnClickListener {
     }
 
 
-    private void setupDecryptLayout() {
-        mDecryptLayout = findViewById(R.id.layout_decrypt);
-        mDecryptButton = (Button) findViewById(R.id.btn_decrypt);
-        mDecryptButton.setOnClickListener(new OnClickListener() {
-            @Override
-            public void onClick(View v) {
-                try {
-                    String data = null;
-                    Part part = MimeUtility.findFirstPartByMimeType(mMessage, "text/plain");
-                    if (part == null) {
-                        part = MimeUtility.findFirstPartByMimeType(mMessage, "text/html");
-                    }
-                    if (part != null) {
-                        data = MimeUtility.getTextFromPart(part);
-                    }
-                    mAccount.getCryptoProvider().decrypt(MessageView.this, data, mPgpData);
-                } catch (MessagingException me) {
-                    Log.e(K9.LOG_TAG, "Unable to decrypt email.", me);
-                }
-            }
-        });
-        mCryptoSignatureLayout = (LinearLayout) findViewById(R.id.crypto_signature);
-        mCryptoSignatureStatusImage = (ImageView) findViewById(R.id.ic_crypto_signature_status);
-        mCryptoSignatureUserId = (TextView) findViewById(R.id.userId);
-        mCryptoSignatureUserIdRest = (TextView) findViewById(R.id.userIdRest);
-        mCryptoSignatureLayout.setVisibility(View.INVISIBLE);
-    }
 
     private boolean isScreenReaderActive() {
         final String SCREENREADER_INTENT_ACTION = "android.accessibilityservice.AccessibilityService";
@@ -597,7 +565,7 @@ public class MessageView extends K9Activity implements OnClickListener {
     protected void onSaveInstanceState(Bundle outState) {
         outState.putSerializable(EXTRA_MESSAGE_REFERENCE, mMessageReference);
         outState.putSerializable(EXTRA_MESSAGE_REFERENCES, mMessageReferences);
-        outState.putSerializable(STATE_PGP_DATA, mPgpData);
+        outState.putSerializable(STATE_PGP_DATA, mCryptoView.getCryptoData());
         outState.putBoolean(SHOW_PICTURES, mShowPictures);
     }
 
@@ -605,8 +573,9 @@ public class MessageView extends K9Activity implements OnClickListener {
     protected void onRestoreInstanceState(Bundle savedInstanceState) {
         super.onRestoreInstanceState(savedInstanceState);
         setLoadPictures(savedInstanceState.getBoolean(SHOW_PICTURES));
-        initializeCrypto((PgpData) savedInstanceState.getSerializable(STATE_PGP_DATA));
-        updateDecryptLayout();
+        mCryptoView.setCryptoData((PgpData) savedInstanceState.getSerializable(STATE_PGP_DATA));
+        mCryptoView.setCryptoProvider(mAccount.getCryptoProvider());
+        mCryptoView.updateLayout(mMessage);
     }
 
     private void displayMessage(MessageReference ref) {
@@ -624,7 +593,8 @@ public class MessageView extends K9Activity implements OnClickListener {
         mAttachments.removeAllViews();
         findSurroundingMessagesUid();
         // start with fresh, empty PGP data
-        initializeCrypto(null);
+        mCryptoView.setCryptoData(null);
+        mCryptoView.setCryptoProvider(mAccount.getCryptoProvider());
         mTopView.setVisibility(View.VISIBLE);
         mController.loadMessageForView(
             mAccount,
@@ -844,21 +814,21 @@ public class MessageView extends K9Activity implements OnClickListener {
 
     private void onReply() {
         if (mMessage != null) {
-            MessageCompose.actionReply(this, mAccount, mMessage, false, mPgpData.getDecryptedData());
+            MessageCompose.actionReply(this, mAccount, mMessage, false, mCryptoView.getDecryptedContent());
             finish();
         }
     }
 
     private void onReplyAll() {
         if (mMessage != null) {
-            MessageCompose.actionReply(this, mAccount, mMessage, true, mPgpData.getDecryptedData());
+            MessageCompose.actionReply(this, mAccount, mMessage, true, mCryptoView.getDecryptedContent());
             finish();
         }
     }
 
     private void onForward() {
         if (mMessage != null) {
-            MessageCompose.actionForward(this, mAccount, mMessage, mPgpData.getDecryptedData());
+            MessageCompose.actionForward(this, mAccount, mMessage, mCryptoView.getDecryptedContent());
             finish();
         }
     }
@@ -917,7 +887,7 @@ public class MessageView extends K9Activity implements OnClickListener {
 
     @Override
     protected void onActivityResult(int requestCode, int resultCode, Intent data) {
-        if (mAccount.getCryptoProvider().onActivityResult(this, requestCode, resultCode, data, mPgpData)) {
+        if (mAccount.getCryptoProvider().onActivityResult(this, requestCode, resultCode, data, mCryptoView.getCryptoData())) {
             return;
         }
         if (resultCode != RESULT_OK)
@@ -1160,6 +1130,11 @@ public class MessageView extends K9Activity implements OnClickListener {
         return true;
     }
 
+    public MessageCryptoView getDecryptLayout() {
+        return mCryptoView;
+    }
+
+
     @Override
     public boolean onPrepareOptionsMenu(Menu menu) {
         prepareMenuItems();
@@ -1207,8 +1182,8 @@ public class MessageView extends K9Activity implements OnClickListener {
             MessageView.this.mMessage = message;
             mHandler.removeAllAttachments();
             String text, type;
-            if (mPgpData.getDecryptedData() != null) {
-                text = mPgpData.getDecryptedData();
+            if (mCryptoView.getDecryptedContent() != null) {
+                text = mCryptoView.getDecryptedContent();
                 type = "text/plain";
             } else {
                 // getTextForDisplay() always returns HTML-ified content.
@@ -1229,7 +1204,7 @@ public class MessageView extends K9Activity implements OnClickListener {
                                                                     contentType, "utf-8", null);
                             mMessageContentView.scrollTo(0, 0);
                         }
-                        updateDecryptLayout();
+                        mCryptoView.updateLayout(mMessage);
                     }
                 });
                 // If the message contains external pictures and the "Show pictures"
@@ -1248,7 +1223,7 @@ public class MessageView extends K9Activity implements OnClickListener {
                 mHandler.post(new Runnable() {
                     public void run() {
                         mMessageContentView.loadUrl("file:///android_asset/empty.html");
-                        updateDecryptLayout();
+                        mCryptoView.updateLayout(mMessage);
                     }
                 });
             }
@@ -1302,7 +1277,7 @@ public class MessageView extends K9Activity implements OnClickListener {
                 mHandler.post(new Runnable() {
                     public void run() {
                         mMessageContentView.loadUrl("file:///android_asset/downloading.html");
-                        updateDecryptLayout();
+                        mCryptoView.updateLayout(mMessage);
                     }
                 });
             }
@@ -1340,7 +1315,7 @@ public class MessageView extends K9Activity implements OnClickListener {
                     if ((MessageView.this.mMessage == null) ||
                     !MessageView.this.mMessage.isSet(Flag.X_DOWNLOADED_PARTIAL)) {
                         mMessageContentView.loadUrl("file:///android_asset/empty.html");
-                        updateDecryptLayout();
+                        mCryptoView.updateLayout(mMessage);
                     }
                 }
             });
@@ -1368,7 +1343,7 @@ public class MessageView extends K9Activity implements OnClickListener {
             }
             mHandler.post(new Runnable() {
                 public void run() {
-                    updateDecryptLayout();
+                    mCryptoView.updateLayout(mMessage);
                     setProgressBarIndeterminateVisibility(true);
                 }
             });
@@ -1419,86 +1394,12 @@ public class MessageView extends K9Activity implements OnClickListener {
     }
 
 
-    private void initializeCrypto(PgpData data) {
-        if (data == null) {
-            if (mAccount == null) {
-                mAccount = Preferences.getPreferences(this).getAccount(mMessageReference.accountUuid);
-            }
-            mPgpData = new PgpData();
-        } else {
-            mPgpData = data;
-        }
-    }
-
-    /**
-     * Fill the decrypt layout with signature data, if known, make controls visible, if
-     * they should be visible.
-     */
-    public void updateDecryptLayout() {
-        if (mPgpData.getSignatureKeyId() != 0) {
-            mCryptoSignatureUserIdRest.setText(
-                getString(R.string.key_id, Long.toHexString(mPgpData.getSignatureKeyId() & 0xffffffffL)));
-            String userId = mPgpData.getSignatureUserId();
-            if (userId == null) {
-                userId = getString(R.string.unknown_crypto_signature_user_id);
-            }
-            String chunks[] = userId.split(" <", 2);
-            String name = chunks[0];
-            if (chunks.length > 1) {
-                mCryptoSignatureUserIdRest.setText("<" + chunks[1]);
-            }
-            mCryptoSignatureUserId.setText(name);
-            if (mPgpData.getSignatureSuccess()) {
-                mCryptoSignatureStatusImage.setImageResource(R.drawable.overlay_ok);
-            } else if (mPgpData.getSignatureUnknown()) {
-                mCryptoSignatureStatusImage.setImageResource(R.drawable.overlay_error);
-            } else {
-                mCryptoSignatureStatusImage.setImageResource(R.drawable.overlay_error);
-            }
-            mCryptoSignatureLayout.setVisibility(View.VISIBLE);
-            mDecryptLayout.setVisibility(View.VISIBLE);
-        } else {
-            mCryptoSignatureLayout.setVisibility(View.INVISIBLE);
-        }
-        if (false || ((mMessage == null) && (mPgpData.getDecryptedData() == null))) {
-            mDecryptLayout.setVisibility(View.GONE);
-            return;
-        }
-        if (mPgpData.getDecryptedData() != null) {
-            if (mPgpData.getSignatureKeyId() == 0) {
-                mDecryptLayout.setVisibility(View.GONE);
-            } else {
-                // no need to show this after decryption/verification
-                mDecryptButton.setVisibility(View.GONE);
-            }
-            return;
-        }
-        mDecryptButton.setVisibility(View.VISIBLE);
-        CryptoProvider crypto = mAccount.getCryptoProvider();
-        if (crypto.isEncrypted(mMessage)) {
-            mDecryptButton.setText(R.string.btn_decrypt);
-            mDecryptLayout.setVisibility(View.VISIBLE);
-        } else if (crypto.isSigned(mMessage)) {
-            mDecryptButton.setText(R.string.btn_verify);
-            mDecryptLayout.setVisibility(View.VISIBLE);
-        } else {
-            mDecryptLayout.setVisibility(View.GONE);
-            try {
-                // check for PGP/MIME encryption
-                Part pgp = MimeUtility.findFirstPartByMimeType(mMessage, "application/pgp-encrypted");
-                if (pgp != null) {
-                    Toast.makeText(this, R.string.pgp_mime_unsupported, Toast.LENGTH_LONG).show();
-                }
-            } catch (MessagingException e) {
-                // nothing to do...
-            }
-        }
-    }
-
-    public void onDecryptDone() {
+    // This REALLY should be in MessageCryptoView
+    public void onDecryptDone(PgpData pgpData) {
         // TODO: this might not be enough if the orientation was changed while in APG,
         // sometimes shows the original encrypted content
-        mMessageContentView.loadDataWithBaseURL("email://", mPgpData.getDecryptedData(), "text/plain", "utf-8", null);
-        updateDecryptLayout();
+        mMessageContentView.loadDataWithBaseURL("email://", pgpData.getDecryptedData(), "text/plain", "utf-8", null);
+        mCryptoView.updateLayout(mMessage);
     }
+
 }
diff --git a/src/com/fsck/k9/crypto/Apg.java b/src/com/fsck/k9/crypto/Apg.java
index 3540faeae..0b85ff039 100644
--- a/src/com/fsck/k9/crypto/Apg.java
+++ b/src/com/fsck/k9/crypto/Apg.java
@@ -327,7 +327,7 @@ public class Apg extends CryptoProvider {
             pgpData.setSignatureUnknown(data.getBooleanExtra(Apg.EXTRA_SIGNATURE_UNKNOWN, false));
 
             pgpData.setDecryptedData(data.getStringExtra(Apg.EXTRA_DECRYPTED_MESSAGE));
-            ((MessageView) activity).onDecryptDone();
+            ((MessageView) activity).onDecryptDone(pgpData);
 
             break;
 
@@ -386,9 +386,7 @@ public class Apg extends CryptoProvider {
             activity.startActivityForResult(intent, Apg.DECRYPT_MESSAGE);
             return true;
         } catch (ActivityNotFoundException e) {
-            Toast.makeText(activity,
-                           R.string.error_activity_not_found,
-                           Toast.LENGTH_SHORT).show();
+            Toast.makeText(activity, R.string.error_activity_not_found, Toast.LENGTH_SHORT).show();
             return false;
         }
     }
diff --git a/src/com/fsck/k9/view/MessageCryptoView.java b/src/com/fsck/k9/view/MessageCryptoView.java
new file mode 100644
index 000000000..6bb40dcd7
--- /dev/null
+++ b/src/com/fsck/k9/view/MessageCryptoView.java
@@ -0,0 +1,176 @@
+package com.fsck.k9.view;
+
+import android.app.Activity;
+import android.content.Context;
+import android.content.Intent;
+import android.graphics.Bitmap;
+import android.graphics.BitmapFactory;
+import android.net.Uri;
+import android.os.Environment;
+import android.util.AttributeSet;
+import android.util.Log;
+import android.view.View;
+import android.widget.LinearLayout;
+import android.widget.*;
+import com.fsck.k9.Account;
+import com.fsck.k9.K9;
+import com.fsck.k9.R;
+import com.fsck.k9.controller.MessagingController;
+import com.fsck.k9.controller.MessagingListener;
+import com.fsck.k9.crypto.CryptoProvider;
+import com.fsck.k9.crypto.PgpData;
+import com.fsck.k9.helper.MediaScannerNotifier;
+import com.fsck.k9.helper.SizeFormatter;
+import com.fsck.k9.helper.Utility;
+import com.fsck.k9.mail.Message;
+import com.fsck.k9.mail.MessagingException;
+import com.fsck.k9.mail.Part;
+import com.fsck.k9.mail.internet.MimeUtility;
+import com.fsck.k9.mail.store.LocalStore.LocalAttachmentBodyPart;
+import com.fsck.k9.provider.AttachmentProvider;
+import org.apache.commons.io.IOUtils;
+
+import java.io.*;
+
+
+
+public class MessageCryptoView extends LinearLayout {
+
+    private Context mContext;
+    private Activity mActivity;
+    private PgpData mPgpData = null;
+    private CryptoProvider mCryptoProvider = null;
+    private View mMessageContentView;
+    private Button mDecryptButton;
+    private LinearLayout mCryptoSignatureLayout = null;
+    private ImageView mCryptoSignatureStatusImage = null;
+    private TextView mCryptoSignatureUserId = null;
+    private TextView mCryptoSignatureUserIdRest = null;
+
+
+    public MessageCryptoView(Context context, AttributeSet attrs) {
+        super(context, attrs);
+        mContext = context;
+    }
+
+    public void setupChildViews() {
+        mCryptoSignatureLayout = (LinearLayout) findViewById(R.id.crypto_signature);
+        mCryptoSignatureStatusImage = (ImageView) findViewById(R.id.ic_crypto_signature_status);
+        mCryptoSignatureUserId = (TextView) findViewById(R.id.userId);
+        mCryptoSignatureUserIdRest = (TextView) findViewById(R.id.userIdRest);
+        mCryptoSignatureLayout.setVisibility(View.INVISIBLE);
+        mDecryptButton = (Button) findViewById(R.id.btn_decrypt);
+    }
+
+    public void setActivity(Activity activity) {
+        mActivity = activity;
+
+    }
+
+    public void setCryptoProvider(CryptoProvider provider){
+        mCryptoProvider = provider;
+    }
+
+    public PgpData getCryptoData() {
+        return mPgpData;
+    }
+
+    public void setCryptoData(PgpData data) {
+        if (data == null) {
+            mPgpData = new PgpData();
+        } else {
+            mPgpData = data;
+        }
+    }
+
+    /**
+     * Fill the decrypt layout with signature data, if known, make controls visible, if
+     * they should be visible.
+     */
+    public void updateLayout(final Message message) {
+        if (mPgpData.getSignatureKeyId() != 0) {
+            mCryptoSignatureUserIdRest.setText(
+                mContext.getString(R.string.key_id, Long.toHexString(mPgpData.getSignatureKeyId() & 0xffffffffL)));
+            String userId = mPgpData.getSignatureUserId();
+            if (userId == null) {
+                userId = mContext.getString(R.string.unknown_crypto_signature_user_id);
+            }
+            String chunks[] = userId.split(" <", 2);
+            String name = chunks[0];
+            if (chunks.length > 1) {
+                mCryptoSignatureUserIdRest.setText("<" + chunks[1]);
+            }
+            mCryptoSignatureUserId.setText(name);
+            if (mPgpData.getSignatureSuccess()) {
+                mCryptoSignatureStatusImage.setImageResource(R.drawable.overlay_ok);
+            } else if (mPgpData.getSignatureUnknown()) {
+                mCryptoSignatureStatusImage.setImageResource(R.drawable.overlay_error);
+            } else {
+                mCryptoSignatureStatusImage.setImageResource(R.drawable.overlay_error);
+            }
+            mCryptoSignatureLayout.setVisibility(View.VISIBLE);
+            this.setVisibility(View.VISIBLE);
+        } else {
+            mCryptoSignatureLayout.setVisibility(View.INVISIBLE);
+        }
+        if (false || ((message == null) && (getDecryptedContent() == null))) {
+            this.setVisibility(View.GONE);
+            return;
+        }
+        if (getDecryptedContent() != null) {
+            if (mPgpData.getSignatureKeyId() == 0) {
+                this.setVisibility(View.GONE);
+            } else {
+                // no need to show this after decryption/verification
+                mDecryptButton.setVisibility(View.GONE);
+            }
+            return;
+        }
+
+
+        mDecryptButton.setOnClickListener(new OnClickListener() {
+            @Override
+            public void onClick(View v) {
+                try {
+                    String data = null;
+                    Part part = MimeUtility.findFirstPartByMimeType(message, "text/plain");
+                    if (part == null) {
+                        part = MimeUtility.findFirstPartByMimeType(message, "text/html");
+                    }
+                    if (part != null) {
+                        data = MimeUtility.getTextFromPart(part);
+                    }
+                    mCryptoProvider.decrypt(mActivity, data, mPgpData);
+                } catch (MessagingException me) {
+                    Log.e(K9.LOG_TAG, "Unable to decrypt email.", me);
+                }
+            }
+        });
+
+
+        mDecryptButton.setVisibility(View.VISIBLE);
+        if (mCryptoProvider.isEncrypted(message)) {
+            mDecryptButton.setText(R.string.btn_decrypt);
+            this.setVisibility(View.VISIBLE);
+        } else if (mCryptoProvider.isSigned(message)) {
+            mDecryptButton.setText(R.string.btn_verify);
+            this.setVisibility(View.VISIBLE);
+        } else {
+            this.setVisibility(View.GONE);
+            try {
+                // check for PGP/MIME encryption
+                Part pgp = MimeUtility.findFirstPartByMimeType(message, "application/pgp-encrypted");
+                if (pgp != null) {
+                    Toast.makeText(mContext, R.string.pgp_mime_unsupported, Toast.LENGTH_LONG).show();
+                }
+            } catch (MessagingException e) {
+                // nothing to do...
+            }
+        }
+    }
+
+
+    public String getDecryptedContent() {
+        return mPgpData.getDecryptedData();
+    }
+}

From c4e5196584fee4483800192c796ad249027350a3 Mon Sep 17 00:00:00 2001
From: Jesse Vincent <jesse@bestpractical.com>
Date: Wed, 9 Feb 2011 07:47:21 -0500
Subject: [PATCH 08/24] Bumped manifest to 3.702

---
 AndroidManifest.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/AndroidManifest.xml b/AndroidManifest.xml
index 11497724d..95099cc0f 100644
--- a/AndroidManifest.xml
+++ b/AndroidManifest.xml
@@ -1,8 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest
     xmlns:android="http://schemas.android.com/apk/res/android"
-    android:versionCode="13001"
-    android:versionName="3.701" package="com.fsck.k9"
+    android:versionCode="13002"
+    android:versionName="3.702" package="com.fsck.k9"
     >
     <uses-sdk
        android:minSdkVersion="3"

From 98f3909ecc83843430e3db5b8a252114aee023df Mon Sep 17 00:00:00 2001
From: Jesse Vincent <jesse@bestpractical.com>
Date: Thu, 10 Feb 2011 14:56:56 -0500
Subject: [PATCH 09/24] Split out a "clear the current message view" method

---
 src/com/fsck/k9/activity/MessageView.java | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

diff --git a/src/com/fsck/k9/activity/MessageView.java b/src/com/fsck/k9/activity/MessageView.java
index f54a4d86d..6abbed6db 100644
--- a/src/com/fsck/k9/activity/MessageView.java
+++ b/src/com/fsck/k9/activity/MessageView.java
@@ -583,14 +583,7 @@ public class MessageView extends K9Activity implements OnClickListener {
         if (K9.DEBUG)
             Log.d(K9.LOG_TAG, "MessageView displaying message " + mMessageReference);
         mAccount = Preferences.getPreferences(this).getAccount(mMessageReference.accountUuid);
-        mTopView.setVisibility(View.GONE);
-        mTopView.scrollTo(0, 0);
-        mMessageContentView.scrollTo(0, 0);
-        mHeaderContainer.setVisibility(View.GONE);
-
-        mMessageContentView.clearView();
-        setLoadPictures(false);
-        mAttachments.removeAllViews();
+        clearMessageDisplay();
         findSurroundingMessagesUid();
         // start with fresh, empty PGP data
         mCryptoView.setCryptoData(null);
@@ -604,6 +597,17 @@ public class MessageView extends K9Activity implements OnClickListener {
         setupDisplayMessageButtons();
     }
 
+    private void clearMessageDisplay() {
+        mTopView.setVisibility(View.GONE);
+        mTopView.scrollTo(0, 0);
+        mMessageContentView.scrollTo(0, 0);
+        mHeaderContainer.setVisibility(View.GONE);
+
+        mMessageContentView.clearView();
+        setLoadPictures(false);
+        mAttachments.removeAllViews();
+    }
+
     private void setupDisplayMessageButtons() {
         mDelete.setEnabled(true);
         next.setEnabled(mNextMessage != null);

From fe21d6951f6114870bf30c4c515d28fc2b6b4370 Mon Sep 17 00:00:00 2001
From: Jesse Vincent <jesse@bestpractical.com>
Date: Thu, 10 Feb 2011 15:11:15 -0500
Subject: [PATCH 10/24] remove unused method

---
 src/com/fsck/k9/activity/MessageView.java | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/com/fsck/k9/activity/MessageView.java b/src/com/fsck/k9/activity/MessageView.java
index 6abbed6db..1dda4ac11 100644
--- a/src/com/fsck/k9/activity/MessageView.java
+++ b/src/com/fsck/k9/activity/MessageView.java
@@ -1134,10 +1134,6 @@ public class MessageView extends K9Activity implements OnClickListener {
         return true;
     }
 
-    public MessageCryptoView getDecryptLayout() {
-        return mCryptoView;
-    }
-
 
     @Override
     public boolean onPrepareOptionsMenu(Menu menu) {

From 015baa06b46591bd55338c6c80829766977684ef Mon Sep 17 00:00:00 2001
From: Jesse Vincent <jesse@bestpractical.com>
Date: Thu, 10 Feb 2011 16:28:30 -0500
Subject: [PATCH 11/24] Renamed "next" and "previous" buttons to match code
 style

---
 src/com/fsck/k9/activity/MessageView.java | 26 +++++++++++------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/src/com/fsck/k9/activity/MessageView.java b/src/com/fsck/k9/activity/MessageView.java
index 1dda4ac11..6b0a38938 100644
--- a/src/com/fsck/k9/activity/MessageView.java
+++ b/src/com/fsck/k9/activity/MessageView.java
@@ -55,8 +55,8 @@ public class MessageView extends K9Activity implements OnClickListener {
     private View mShowPicturesSection;
     private boolean mShowPictures;
     private Button mDownloadRemainder;
-    View next;
-    View previous;
+    private View mNext;
+    private View mPrevious;
     private View mDelete;
     private View mArchive;
     private View mMove;
@@ -432,7 +432,7 @@ public class MessageView extends K9Activity implements OnClickListener {
         if (K9.DEBUG)
             Log.d(K9.LOG_TAG, "MessageView got message " + mMessageReference);
         if (intent.getBooleanExtra(EXTRA_NEXT, false)) {
-            next.requestFocus();
+            mNext.requestFocus();
         }
 
         setupHeaderLayout();
@@ -610,8 +610,8 @@ public class MessageView extends K9Activity implements OnClickListener {
 
     private void setupDisplayMessageButtons() {
         mDelete.setEnabled(true);
-        next.setEnabled(mNextMessage != null);
-        previous.setEnabled(mPreviousMessage != null);
+        mNext.setEnabled(mNextMessage != null);
+        mPrevious.setEnabled(mPreviousMessage != null);
         // If moving isn't support at all, then all of them must be disabled anyway.
         if (mController.isMoveCapable(mAccount)) {
             // Only enable the button if the Archive folder is not the current folder and not NONE.
@@ -631,8 +631,8 @@ public class MessageView extends K9Activity implements OnClickListener {
         if (buttons != null) {
             buttons.setVisibility(View.GONE);
         }
-        next = findViewById(R.id.next);
-        previous = findViewById(R.id.previous);
+        mNext = findViewById(R.id.next);
+        mPrevious = findViewById(R.id.previous);
         mDelete = findViewById(R.id.delete);
     }
 
@@ -641,8 +641,8 @@ public class MessageView extends K9Activity implements OnClickListener {
         if (buttons != null) {
             buttons.setVisibility(View.GONE);
         }
-        next = findViewById(R.id.next_scrolling);
-        previous = findViewById(R.id.previous_scrolling);
+        mNext = findViewById(R.id.next_scrolling);
+        mPrevious = findViewById(R.id.previous_scrolling);
         mDelete = findViewById(R.id.delete_scrolling);
     }
 
@@ -669,8 +669,8 @@ public class MessageView extends K9Activity implements OnClickListener {
     private void disableButtons() {
         setLoadPictures(false);
         disableMoveButtons();
-        next.setEnabled(false);
-        previous.setEnabled(false);
+        mNext.setEnabled(false);
+        mPrevious.setEnabled(false);
         mDelete.setEnabled(false);
     }
 
@@ -941,7 +941,7 @@ public class MessageView extends K9Activity implements OnClickListener {
             mTopView.startAnimation(outToLeftAnimation());
         }
         displayMessage(mNextMessage);
-        next.requestFocus();
+        mNext.requestFocus();
     }
 
     @Override
@@ -956,7 +956,7 @@ public class MessageView extends K9Activity implements OnClickListener {
             mTopView.startAnimation(inFromRightAnimation());
         }
         displayMessage(mPreviousMessage);
-        previous.requestFocus();
+        mPrevious.requestFocus();
     }
 
     private void onMarkAsUnread() {

From 44607638d9fa28b27433700b5380eff5d946c048 Mon Sep 17 00:00:00 2001
From: Jesse Vincent <jesse@bestpractical.com>
Date: Thu, 10 Feb 2011 16:46:14 -0500
Subject: [PATCH 12/24] remove a noop layout entry

---
 res/layout/message_view.xml | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/res/layout/message_view.xml b/res/layout/message_view.xml
index 2055b14c2..209549f32 100644
--- a/res/layout/message_view.xml
+++ b/res/layout/message_view.xml
@@ -21,10 +21,6 @@
             android:layout_height="0dip"
             android:layout_weight="1">
             <include layout="@layout/message_view_header" />
-            <View
-                android:layout_width="fill_parent"
-                android:layout_height="0dip"
-                android:layout_weight="1" />
             <include layout="@layout/message_view_scrolling_buttons"/>
         </LinearLayout>
     </com.fsck.k9.view.ToggleScrollView>

From 594b3291acfe03610bb0be3b211a4d921299fce0 Mon Sep 17 00:00:00 2001
From: Jesse Vincent <jesse@bestpractical.com>
Date: Thu, 10 Feb 2011 17:57:54 -0500
Subject: [PATCH 13/24] move the messageview from a merge to a linearlayout

---
 res/layout/message_view.xml        |  2 +-
 res/layout/message_view_header.xml | 11 +++++++++--
 2 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/res/layout/message_view.xml b/res/layout/message_view.xml
index 209549f32..2505c904d 100644
--- a/res/layout/message_view.xml
+++ b/res/layout/message_view.xml
@@ -18,7 +18,7 @@
             android:orientation="vertical"
             android:layout_width="fill_parent"
             android:background="@android:color/transparent"
-            android:layout_height="0dip"
+            android:layout_height="wrap_content"
             android:layout_weight="1">
             <include layout="@layout/message_view_header" />
             <include layout="@layout/message_view_scrolling_buttons"/>
diff --git a/res/layout/message_view_header.xml b/res/layout/message_view_header.xml
index dd1feafa1..1e77062af 100644
--- a/res/layout/message_view_header.xml
+++ b/res/layout/message_view_header.xml
@@ -1,5 +1,12 @@
 <?xml version="1.0" encoding="utf-8"?>
-<merge xmlns:android="http://schemas.android.com/apk/res/android">
+<LinearLayout 
+    android:id="@+id/message_view"
+            android:orientation="vertical"
+            android:layout_width="fill_parent"
+            android:background="@android:color/transparent"
+            android:layout_height="wrap_content"
+            android:layout_weight="1"
+ xmlns:android="http://schemas.android.com/apk/res/android">
     <!-- Header area -->
     <com.fsck.k9.view.MessageHeader
         android:id="@+id/header_container"
@@ -216,4 +223,4 @@
         android:layout_height="wrap_content"
         android:visibility="gone"
         android:layout_width="fill_parent" />
-</merge>
+</LinearLayout>

From d29781b2fd76deec1cacec0bc59b86fec75d6643 Mon Sep 17 00:00:00 2001
From: Jesse Vincent <jesse@bestpractical.com>
Date: Thu, 10 Feb 2011 18:01:20 -0500
Subject: [PATCH 14/24] rename the message_view_header component that actually
 contained just the message

---
 res/layout/{message_view_header.xml => message.xml} | 0
 res/layout/message_view.xml                         | 2 +-
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename res/layout/{message_view_header.xml => message.xml} (100%)

diff --git a/res/layout/message_view_header.xml b/res/layout/message.xml
similarity index 100%
rename from res/layout/message_view_header.xml
rename to res/layout/message.xml
diff --git a/res/layout/message_view.xml b/res/layout/message_view.xml
index 2505c904d..d653f3dba 100644
--- a/res/layout/message_view.xml
+++ b/res/layout/message_view.xml
@@ -20,7 +20,7 @@
             android:background="@android:color/transparent"
             android:layout_height="wrap_content"
             android:layout_weight="1">
-            <include layout="@layout/message_view_header" />
+            <include layout="@layout/message" />
             <include layout="@layout/message_view_scrolling_buttons"/>
         </LinearLayout>
     </com.fsck.k9.view.ToggleScrollView>

From d634bcb38136ae8e968f9f4ce2231b15da912b47 Mon Sep 17 00:00:00 2001
From: Jesse Vincent <jesse@bestpractical.com>
Date: Thu, 10 Feb 2011 19:29:46 -0500
Subject: [PATCH 15/24] Switch the Message view to our new SingleMessageView

---
 res/layout/message.xml                      |  4 ++--
 src/com/fsck/k9/view/SingleMessageView.java | 13 +++++++++++++
 2 files changed, 15 insertions(+), 2 deletions(-)
 create mode 100644 src/com/fsck/k9/view/SingleMessageView.java

diff --git a/res/layout/message.xml b/res/layout/message.xml
index 1e77062af..8e425eb71 100644
--- a/res/layout/message.xml
+++ b/res/layout/message.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
-<LinearLayout 
+<com.fsck.k9.view.SingleMessageView
     android:id="@+id/message_view"
             android:orientation="vertical"
             android:layout_width="fill_parent"
@@ -223,4 +223,4 @@
         android:layout_height="wrap_content"
         android:visibility="gone"
         android:layout_width="fill_parent" />
-</LinearLayout>
+</com.fsck.k9.view.SingleMessageView>
diff --git a/src/com/fsck/k9/view/SingleMessageView.java b/src/com/fsck/k9/view/SingleMessageView.java
new file mode 100644
index 000000000..7ae7872a0
--- /dev/null
+++ b/src/com/fsck/k9/view/SingleMessageView.java
@@ -0,0 +1,13 @@
+package com.fsck.k9.view;
+
+import android.content.Context;
+import android.util.AttributeSet;
+import android.widget.LinearLayout;
+
+/**
+ */
+public class SingleMessageView extends LinearLayout{
+    public SingleMessageView(Context context, AttributeSet attrs) {
+        super(context, attrs);
+    }
+}

From 49b35f923697e56695c5069a3e3bd94419bdf971 Mon Sep 17 00:00:00 2001
From: Jesse Vincent <jesse@bestpractical.com>
Date: Fri, 11 Feb 2011 10:09:15 -0500
Subject: [PATCH 16/24] More reshuffling toward having a reusable "Show a
 message" widget - what should eventually be a Fragment.

Lifted part of the cryptoView back up to the activity since the
factoring felt forced.
---
 src/com/fsck/k9/activity/MessageView.java   | 304 ++++++--------------
 src/com/fsck/k9/view/MessageCryptoView.java |  45 +--
 src/com/fsck/k9/view/SingleMessageView.java | 199 ++++++++++++-
 3 files changed, 295 insertions(+), 253 deletions(-)

diff --git a/src/com/fsck/k9/activity/MessageView.java b/src/com/fsck/k9/activity/MessageView.java
index 6b0a38938..e94e19b43 100644
--- a/src/com/fsck/k9/activity/MessageView.java
+++ b/src/com/fsck/k9/activity/MessageView.java
@@ -24,16 +24,11 @@ import com.fsck.k9.crypto.PgpData;
 import com.fsck.k9.helper.Contacts;
 import com.fsck.k9.helper.Utility;
 import com.fsck.k9.mail.*;
-import com.fsck.k9.mail.internet.MimeUtility;
-import com.fsck.k9.mail.store.LocalStore.LocalAttachmentBodyPart;
 import com.fsck.k9.mail.store.LocalStore.LocalMessage;
 import com.fsck.k9.mail.store.StorageManager;
-import com.fsck.k9.view.AccessibleWebView;
 import com.fsck.k9.view.AttachmentView;
-import com.fsck.k9.view.MessageWebView;
 import com.fsck.k9.view.ToggleScrollView;
-import com.fsck.k9.view.MessageHeader;
-import com.fsck.k9.view.MessageCryptoView;
+import com.fsck.k9.view.SingleMessageView;
 
 import java.io.Serializable;
 import java.util.*;
@@ -46,15 +41,13 @@ public class MessageView extends K9Activity implements OnClickListener {
     private static final String STATE_PGP_DATA = "pgpData";
     private static final int ACTIVITY_CHOOSE_FOLDER_MOVE = 1;
     private static final int ACTIVITY_CHOOSE_FOLDER_COPY = 2;
-    private MessageCryptoView mCryptoView;
-    private MessageWebView mMessageContentView;
-    private boolean mScreenReaderEnabled;
-    private AccessibleWebView mAccessibleMessageContentView;
-    private MessageHeader mHeaderContainer;
-    private LinearLayout        mAttachments;
-    private View mShowPicturesSection;
-    private boolean mShowPictures;
-    private Button mDownloadRemainder;
+
+
+    private SingleMessageView mMessageView;
+
+    private PgpData mPgpData;
+
+
     private View mNext;
     private View mPrevious;
     private View mDelete;
@@ -203,15 +196,7 @@ public class MessageView extends K9Activity implements OnClickListener {
         case KeyEvent.KEYCODE_Z: {
             mHandler.post(new Runnable() {
                 public void run() {
-                    if (mScreenReaderEnabled) {
-                        mAccessibleMessageContentView.zoomIn();
-                    } else {
-                        if (event.isShiftPressed()) {
-                            mMessageContentView.zoomIn();
-                        } else {
-                            mMessageContentView.zoomOut();
-                        }
-                    }
+                    mMessageView.zoom(event);
                 }
             });
             return true;
@@ -239,31 +224,6 @@ public class MessageView extends K9Activity implements OnClickListener {
     }
 
     class MessageViewHandler extends Handler {
-        public void setHeaders(final Message message) {
-            runOnUiThread(new Runnable() {
-                public void run() {
-                    try {
-                        mHeaderContainer.populate(message, mAccount);
-                        mHeaderContainer.setOnFlagListener(new OnClickListener() {
-                            @Override public void onClick(View v) {
-                                if (mMessage != null) {
-                                    onFlag();
-                                }
-                            }
-                        });
-                    } catch (Exception me) {
-                        Log.e(K9.LOG_TAG, "setHeaders - error", me);
-                    }
-                    if (mMessage.isSet(Flag.X_DOWNLOADED_FULL)) {
-                        mDownloadRemainder.setVisibility(View.GONE);
-                    } else {
-                        mDownloadRemainder.setEnabled(true);
-                        mDownloadRemainder.setVisibility(View.VISIBLE);
-                    }
-                }
-            });
-
-        }
 
         public void progress(final boolean progress) {
             runOnUiThread(new Runnable() {
@@ -276,8 +236,7 @@ public class MessageView extends K9Activity implements OnClickListener {
         public void addAttachment(final View attachmentView) {
             runOnUiThread(new Runnable() {
                 public void run() {
-                    mAttachments.addView(attachmentView);
-                    mAttachments.setVisibility(View.VISIBLE);
+                    mMessageView.addAttachment(attachmentView);
                 }
             });
         }
@@ -285,32 +244,16 @@ public class MessageView extends K9Activity implements OnClickListener {
         public void removeAllAttachments() {
             runOnUiThread(new Runnable() {
                 public void run() {
-                    for (int i = 0, count = mAttachments.getChildCount(); i < count; i++) {
-                        mAttachments.removeView(mAttachments.getChildAt(i));
-                    }
+                    mMessageView.removeAllAttachments();
                 }
-            });
+            }
+                         );
         }
 
-        public void setAttachmentsEnabled(final boolean enabled) {
-            runOnUiThread(new Runnable() {
-                public void run() {
-                    for (int i = 0, count = mAttachments.getChildCount(); i < count; i++) {
-                        AttachmentView attachment = (AttachmentView) mAttachments.getChildAt(i);
-                        attachment.viewButton.setEnabled(enabled);
-                        attachment.downloadButton.setEnabled(enabled);
-                    }
-                }
-            });
-        }
-
-
-
         public void networkError() {
             runOnUiThread(new Runnable() {
                 public void run() {
-                    Toast.makeText(MessageView.this,
-                                   R.string.status_network_error, Toast.LENGTH_LONG).show();
+                    Toast.makeText(MessageView.this, R.string.status_network_error, Toast.LENGTH_LONG).show();
                 }
             });
         }
@@ -318,8 +261,7 @@ public class MessageView extends K9Activity implements OnClickListener {
         public void invalidIdError() {
             runOnUiThread(new Runnable() {
                 public void run() {
-                    Toast.makeText(MessageView.this,
-                                   R.string.status_invalid_id_error, Toast.LENGTH_LONG).show();
+                    Toast.makeText(MessageView.this, R.string.status_invalid_id_error, Toast.LENGTH_LONG).show();
                 }
             });
         }
@@ -338,13 +280,22 @@ public class MessageView extends K9Activity implements OnClickListener {
         public void showShowPictures(final boolean show) {
             runOnUiThread(new Runnable() {
                 public void run() {
-                    mShowPicturesSection.setVisibility(show ? View.VISIBLE : View.GONE);
+                    mMessageView.showShowPicturesSection(show);
+                }
+            });
+        }
+
+        public void setHeaders(final Message message, final Account account) {
+            runOnUiThread(new Runnable() {
+                public void run() {
+                    mMessageView.setHeaders(message, account);
                 }
             });
         }
 
     }
 
+
     public static void actionView(Context context, MessageReference messRef, List<MessageReference> messReferences) {
         actionView(context, messRef, messReferences, null);
     }
@@ -366,31 +317,18 @@ public class MessageView extends K9Activity implements OnClickListener {
         requestWindowFeature(Window.FEATURE_INDETERMINATE_PROGRESS);
         requestWindowFeature(Window.FEATURE_NO_TITLE);
         setContentView(R.layout.message_view);
-        mMessageContentView = (MessageWebView) findViewById(R.id.message_content);
-        mAccessibleMessageContentView = (AccessibleWebView) findViewById(R.id.accessible_message_content);
-        mAttachments = (LinearLayout) findViewById(R.id.attachments);
 
-        mHeaderContainer = (MessageHeader) findViewById(R.id.header_container);
-        mCryptoView = (MessageCryptoView) findViewById(R.id.layout_decrypt);
-        mCryptoView.setActivity(this);
-        mCryptoView.setupChildViews();
-
-        mScreenReaderEnabled = isScreenReaderActive();
-        if (mScreenReaderEnabled) {
-            mAccessibleMessageContentView.setVisibility(View.VISIBLE);
-            mMessageContentView.setVisibility(View.GONE);
-        } else {
-            mAccessibleMessageContentView.setVisibility(View.GONE);
-            mMessageContentView.setVisibility(View.VISIBLE);
-        }
+        mTopView = mToggleScrollView = (ToggleScrollView) findViewById(R.id.top_view);
+        mMessageView = (SingleMessageView) findViewById(R.id.message_view);
 
+        mMessageView.initialize(this, isScreenReaderActive());
 
         setTitle("");
         Intent intent = getIntent();
         Uri uri = intent.getData();
         if (icicle != null) {
             restoreMessageReferences(icicle);
-            mCryptoView.setCryptoData((PgpData) icicle.getSerializable(STATE_PGP_DATA));
+            mPgpData = (PgpData) icicle.getSerializable(STATE_PGP_DATA);
         } else {
             if (uri == null) {
                 restoreMessageReferencesExtra(intent);
@@ -435,9 +373,7 @@ public class MessageView extends K9Activity implements OnClickListener {
             mNext.requestFocus();
         }
 
-        setupHeaderLayout();
         setupButtonViews();
-
         displayMessage(mMessageReference);
     }
 
@@ -508,26 +444,8 @@ public class MessageView extends K9Activity implements OnClickListener {
                 buttons.setVisibility(View.GONE);
             }
         }
-
-
-
     }
 
-    private void setupHeaderLayout() {
-        mShowPicturesSection = findViewById(R.id.show_pictures_section);
-        mShowPictures = false;
-
-        mDownloadRemainder = (Button) findViewById(R.id.download_remainder);
-        mMessageContentView.configure();
-
-        mTopView = mToggleScrollView = (ToggleScrollView) findViewById(R.id.top_view);
-
-        mAttachments.setVisibility(View.GONE);
-
-    }
-
-
-
     private boolean isScreenReaderActive() {
         final String SCREENREADER_INTENT_ACTION = "android.accessibilityservice.AccessibilityService";
         final String SCREENREADER_INTENT_CATEGORY = "android.accessibilityservice.category.FEEDBACK_SPOKEN";
@@ -565,17 +483,16 @@ public class MessageView extends K9Activity implements OnClickListener {
     protected void onSaveInstanceState(Bundle outState) {
         outState.putSerializable(EXTRA_MESSAGE_REFERENCE, mMessageReference);
         outState.putSerializable(EXTRA_MESSAGE_REFERENCES, mMessageReferences);
-        outState.putSerializable(STATE_PGP_DATA, mCryptoView.getCryptoData());
-        outState.putBoolean(SHOW_PICTURES, mShowPictures);
+        outState.putSerializable(STATE_PGP_DATA, mPgpData);
+        outState.putBoolean(SHOW_PICTURES, mMessageView.showPictures());
     }
 
     @Override
     protected void onRestoreInstanceState(Bundle savedInstanceState) {
         super.onRestoreInstanceState(savedInstanceState);
         setLoadPictures(savedInstanceState.getBoolean(SHOW_PICTURES));
-        mCryptoView.setCryptoData((PgpData) savedInstanceState.getSerializable(STATE_PGP_DATA));
-        mCryptoView.setCryptoProvider(mAccount.getCryptoProvider());
-        mCryptoView.updateLayout(mMessage);
+        mPgpData = (PgpData) savedInstanceState.getSerializable(STATE_PGP_DATA);
+        mMessageView.updateCryptoLayout(mAccount.getCryptoProvider(), mPgpData, mMessage);
     }
 
     private void displayMessage(MessageReference ref) {
@@ -586,26 +503,19 @@ public class MessageView extends K9Activity implements OnClickListener {
         clearMessageDisplay();
         findSurroundingMessagesUid();
         // start with fresh, empty PGP data
-        mCryptoView.setCryptoData(null);
-        mCryptoView.setCryptoProvider(mAccount.getCryptoProvider());
+        mPgpData = new PgpData();
         mTopView.setVisibility(View.VISIBLE);
-        mController.loadMessageForView(
-            mAccount,
-            mMessageReference.folderName,
-            mMessageReference.uid,
-            mListener);
+        mController.loadMessageForView(mAccount, mMessageReference.folderName, mMessageReference.uid, mListener);
         setupDisplayMessageButtons();
     }
 
     private void clearMessageDisplay() {
         mTopView.setVisibility(View.GONE);
         mTopView.scrollTo(0, 0);
-        mMessageContentView.scrollTo(0, 0);
-        mHeaderContainer.setVisibility(View.GONE);
-
-        mMessageContentView.clearView();
         setLoadPictures(false);
-        mAttachments.removeAllViews();
+
+        mMessageView.resetView();
+
     }
 
     private void setupDisplayMessageButtons() {
@@ -818,21 +728,21 @@ public class MessageView extends K9Activity implements OnClickListener {
 
     private void onReply() {
         if (mMessage != null) {
-            MessageCompose.actionReply(this, mAccount, mMessage, false, mCryptoView.getDecryptedContent());
+            MessageCompose.actionReply(this, mAccount, mMessage, false, mPgpData.getDecryptedData());
             finish();
         }
     }
 
     private void onReplyAll() {
         if (mMessage != null) {
-            MessageCompose.actionReply(this, mAccount, mMessage, true, mCryptoView.getDecryptedContent());
+            MessageCompose.actionReply(this, mAccount, mMessage, true, mPgpData.getDecryptedData());
             finish();
         }
     }
 
     private void onForward() {
         if (mMessage != null) {
-            MessageCompose.actionForward(this, mAccount, mMessage, mCryptoView.getDecryptedContent());
+            MessageCompose.actionForward(this, mAccount, mMessage, mPgpData.getDecryptedData());
             finish();
         }
     }
@@ -843,7 +753,7 @@ public class MessageView extends K9Activity implements OnClickListener {
                                 mMessage.getFolder().getName(), new String[] {mMessage.getUid()}, Flag.FLAGGED, !mMessage.isSet(Flag.FLAGGED));
             try {
                 mMessage.setFlag(Flag.FLAGGED, !mMessage.isSet(Flag.FLAGGED));
-                mHandler.setHeaders(mMessage);
+                mMessageView.setHeaders(mMessage, mAccount);
                 prepareMenuItems();
             } catch (MessagingException me) {
                 Log.e(K9.LOG_TAG, "Could not set flag on local message", me);
@@ -891,7 +801,7 @@ public class MessageView extends K9Activity implements OnClickListener {
 
     @Override
     protected void onActivityResult(int requestCode, int resultCode, Intent data) {
-        if (mAccount.getCryptoProvider().onActivityResult(this, requestCode, resultCode, data, mCryptoView.getCryptoData())) {
+        if (mAccount.getCryptoProvider().onActivityResult(this, requestCode, resultCode, data, mPgpData)) {
             return;
         }
         if (resultCode != RESULT_OK)
@@ -969,7 +879,7 @@ public class MessageView extends K9Activity implements OnClickListener {
                 false);
             try {
                 mMessage.setFlag(Flag.SEEN, false);
-                mHandler.setHeaders(mMessage);
+                mMessageView.setHeaders(mMessage, mAccount);
                 String subject = mMessage.getSubject();
                 setTitle(subject);
             } catch (Exception e) {
@@ -983,17 +893,8 @@ public class MessageView extends K9Activity implements OnClickListener {
         if (mMessage.isSet(Flag.X_DOWNLOADED_FULL)) {
             return;
         }
-        mDownloadRemainder.setEnabled(false);
-        mController.loadMessageForViewRemote(
-            mAccount,
-            mMessageReference.folderName,
-            mMessageReference.uid,
-            mListener);
-    }
-
-    private void onShowPictures() {
-        // TODO: Download attachments that are used as inline image
-        setLoadPictures(true);
+        mMessageView.downloadRemainderButton().setEnabled(false);
+        mController.loadMessageForViewRemote(mAccount, mMessageReference.folderName, mMessageReference.uid, mListener);
     }
 
     /**
@@ -1004,11 +905,12 @@ public class MessageView extends K9Activity implements OnClickListener {
      *               false, otherwise.
      */
     private void setLoadPictures(boolean enable) {
-        mMessageContentView.blockNetworkData(!enable);
-        mShowPictures = enable;
+        mMessageView.blockNetworkData(!enable);
+        mMessageView.setShowPictures(enable);
         mHandler.showShowPictures(false);
     }
 
+
     public void onClick(View view) {
         switch (view.getId()) {
         case R.id.reply:
@@ -1050,7 +952,7 @@ public class MessageView extends K9Activity implements OnClickListener {
             ((AttachmentView)view).saveFile();
             break;
         case R.id.show_pictures:
-            onShowPictures();
+            setLoadPictures(true);
             break;
         case R.id.download_remainder:
             onDownloadRemainder();
@@ -1096,14 +998,15 @@ public class MessageView extends K9Activity implements OnClickListener {
             break;
         case R.id.show_full_header:
             runOnUiThread(new Runnable() {
-                @Override public void run() {
-                    mHeaderContainer.onShowAdditionalHeaders();
+                @Override
+                public void run() {
+                    mMessageView.showAllHeaders();
                 }
             });
             break;
         case R.id.select_text:
             mToggleScrollView.setScrolling(false);
-            mMessageContentView.emulateShiftHeld();
+            mMessageView.beginSelectingText();
             break;
         default:
             return super.onOptionsItemSelected(item);
@@ -1166,7 +1069,7 @@ public class MessageView extends K9Activity implements OnClickListener {
             }
             MenuItem additionalHeadersItem = menu.findItem(R.id.show_full_header);
             if (additionalHeadersItem != null) {
-                additionalHeadersItem.setTitle(mHeaderContainer.additionalHeadersVisible() ?
+                additionalHeadersItem.setTitle(mMessageView.additionalHeadersVisible() ?
                                                R.string.hide_full_header_action : R.string.show_full_header_action);
             }
         }
@@ -1177,13 +1080,13 @@ public class MessageView extends K9Activity implements OnClickListener {
             if (MessageView.this.mMessage != null
                     && MessageView.this.mMessage.isSet(Flag.X_DOWNLOADED_PARTIAL)
                     && message.isSet(Flag.X_DOWNLOADED_FULL)) {
-                mHandler.setHeaders(message);
+                mMessageView.setHeaders(message, account);
             }
             MessageView.this.mMessage = message;
             mHandler.removeAllAttachments();
-            String text, type;
-            if (mCryptoView.getDecryptedContent() != null) {
-                text = mCryptoView.getDecryptedContent();
+            String type;
+            String text = mPgpData.getDecryptedData();
+            if (text != null) {
                 type = "text/plain";
             } else {
                 // getTextForDisplay() always returns HTML-ified content.
@@ -1196,38 +1099,29 @@ public class MessageView extends K9Activity implements OnClickListener {
                 mHandler.post(new Runnable() {
                     public void run() {
                         mTopView.scrollTo(0, 0);
-                        if (mScreenReaderEnabled) {
-                            mAccessibleMessageContentView.loadDataWithBaseURL("http://",
-                                    emailText, contentType, "utf-8", null);
-                        } else {
-                            mMessageContentView.loadDataWithBaseURL("http://", emailText,
-                                                                    contentType, "utf-8", null);
-                            mMessageContentView.scrollTo(0, 0);
-                        }
-                        mCryptoView.updateLayout(mMessage);
+                        mMessageView.loadBodyFromText(mAccount.getCryptoProvider(), mPgpData, mMessage, emailText, contentType);
                     }
                 });
                 // If the message contains external pictures and the "Show pictures"
                 // button wasn't already pressed, see if the user's preferences has us
                 // showing them anyway.
-                if (Utility.hasExternalImages(text) && !mShowPictures) {
+                if (Utility.hasExternalImages(text) && !mMessageView.showPictures()) {
                     if ((account.getShowPictures() == Account.ShowPictures.ALWAYS) ||
                             ((account.getShowPictures() == Account.ShowPictures.ONLY_FROM_CONTACTS) &&
                              mContacts.isInContacts(message.getFrom()[0].getAddress()))) {
-                        onShowPictures();
+                        setLoadPictures(true);
                     } else {
-                        mHandler.showShowPictures(true);
+                        mMessageView.showShowPicturesSection(true);
                     }
                 }
             } else {
                 mHandler.post(new Runnable() {
                     public void run() {
-                        mMessageContentView.loadUrl("file:///android_asset/empty.html");
-                        mCryptoView.updateLayout(mMessage);
+                        mMessageView.loadBodyFromUrl(mMessage, "file:///android_asset/empty.html");
                     }
                 });
             }
-            renderAttachments(mMessage, 0);
+            mMessageView.renderAttachments(mMessage, 0, mMessage, mAccount, mController, mListener);
         } catch (Exception e) {
             if (Config.LOGV) {
                 Log.v(K9.LOG_TAG, "loadMessageForViewBodyAvailable", e);
@@ -1235,53 +1129,25 @@ public class MessageView extends K9Activity implements OnClickListener {
         }
     }
 
-    private void renderAttachments(Part part, int depth) throws MessagingException {
-        if (part.getBody() instanceof Multipart) {
-            Multipart mp = (Multipart) part.getBody();
-            for (int i = 0; i < mp.getCount(); i++) {
-                renderAttachments(mp.getBodyPart(i), depth + 1);
-            }
-        } else if (part instanceof LocalAttachmentBodyPart) {
-            String contentDisposition = MimeUtility.unfoldAndDecode(part.getDisposition());
-            // Inline parts with a content-id are almost certainly components of an HTML message
-            // not attachments. Don't show attachment download buttons for them.
-            if (contentDisposition != null &&
-                    MimeUtility.getHeaderParameter(contentDisposition, null).matches("^(?i:inline)")
-                    && part.getHeader("Content-ID") != null) {
-                return;
-            }
-            renderPartAsAttachment(part);
-        }
-    }
-
-    private void renderPartAsAttachment(Part part) throws MessagingException {
-        LayoutInflater inflater = getLayoutInflater();
-        AttachmentView view = (AttachmentView)inflater.inflate(R.layout.message_view_attachment, null);
-        if (view.populateFromPart(part, mMessage, mAccount, mController, mListener)) {
-            mHandler.addAttachment(view);
-        }
-        return;
-    }
-
     class Listener extends MessagingListener {
         @Override
-        public void loadMessageForViewHeadersAvailable(Account account, String folder, String uid,
+        public void loadMessageForViewHeadersAvailable(final Account account, String folder, String uid,
                 final Message message) {
             if (!mMessageReference.uid.equals(uid) || !mMessageReference.folderName.equals(folder)
                     || !mMessageReference.accountUuid.equals(account.getUuid())) {
                 return;
             }
             MessageView.this.mMessage = message;
-            if (!message.isSet(Flag.X_DOWNLOADED_FULL)
-                    && !message.isSet(Flag.X_DOWNLOADED_PARTIAL)) {
-                mHandler.post(new Runnable() {
-                    public void run() {
-                        mMessageContentView.loadUrl("file:///android_asset/downloading.html");
-                        mCryptoView.updateLayout(mMessage);
+            runOnUiThread(
+
+            new Runnable() {
+                public void run() {
+                    if (!message.isSet(Flag.X_DOWNLOADED_FULL) && !message.isSet(Flag.X_DOWNLOADED_PARTIAL)) {
+                        mMessageView.loadBodyFromUrl(mMessage, "file:///android_asset/downloading.html");
                     }
-                });
-            }
-            mHandler.setHeaders(message);
+                    mMessageView.setHeaders(message, account);
+                }
+            });
         }
 
         @Override
@@ -1314,8 +1180,7 @@ public class MessageView extends K9Activity implements OnClickListener {
                     }
                     if ((MessageView.this.mMessage == null) ||
                     !MessageView.this.mMessage.isSet(Flag.X_DOWNLOADED_PARTIAL)) {
-                        mMessageContentView.loadUrl("file:///android_asset/empty.html");
-                        mCryptoView.updateLayout(mMessage);
+                        mMessageView.loadBodyFromUrl(mMessage, "file:///android_asset/empty.html");
                     }
                 }
             });
@@ -1343,7 +1208,6 @@ public class MessageView extends K9Activity implements OnClickListener {
             }
             mHandler.post(new Runnable() {
                 public void run() {
-                    mCryptoView.updateLayout(mMessage);
                     setProgressBarIndeterminateVisibility(true);
                 }
             });
@@ -1355,7 +1219,7 @@ public class MessageView extends K9Activity implements OnClickListener {
             if (mMessage != message) {
                 return;
             }
-            mHandler.setAttachmentsEnabled(false);
+            mMessageView.setAttachmentsEnabled(false);
             mHandler.progress(true);
             if (requiresDownload) {
                 mHandler.fetchingAttachment();
@@ -1363,12 +1227,11 @@ public class MessageView extends K9Activity implements OnClickListener {
         }
 
         @Override
-        public void loadAttachmentFinished(Account account, Message message,
-                                           Part part, Object tag) {
+        public void loadAttachmentFinished(Account account, Message message, Part part, Object tag) {
             if (mMessage != message) {
                 return;
             }
-            mHandler.setAttachmentsEnabled(true);
+            mMessageView.setAttachmentsEnabled(true);
             mHandler.progress(false);
             Object[] params = (Object[]) tag;
             boolean download = (Boolean) params[0];
@@ -1387,19 +1250,22 @@ public class MessageView extends K9Activity implements OnClickListener {
             if (mMessage != message) {
                 return;
             }
-            mHandler.setAttachmentsEnabled(true);
+            mMessageView.setAttachmentsEnabled(true);
             mHandler.progress(false);
             mHandler.networkError();
         }
     }
 
 
+    public PgpData getPgpData() {
+        return mPgpData;
+    }
+
     // This REALLY should be in MessageCryptoView
     public void onDecryptDone(PgpData pgpData) {
         // TODO: this might not be enough if the orientation was changed while in APG,
         // sometimes shows the original encrypted content
-        mMessageContentView.loadDataWithBaseURL("email://", pgpData.getDecryptedData(), "text/plain", "utf-8", null);
-        mCryptoView.updateLayout(mMessage);
+        mMessageView.loadBodyFromText(mAccount.getCryptoProvider(), mPgpData, mMessage, mPgpData.getDecryptedData(), "text/plain");
     }
 
 }
diff --git a/src/com/fsck/k9/view/MessageCryptoView.java b/src/com/fsck/k9/view/MessageCryptoView.java
index 6bb40dcd7..9c7a7f1a9 100644
--- a/src/com/fsck/k9/view/MessageCryptoView.java
+++ b/src/com/fsck/k9/view/MessageCryptoView.java
@@ -39,7 +39,6 @@ public class MessageCryptoView extends LinearLayout {
     private Context mContext;
     private Activity mActivity;
     private PgpData mPgpData = null;
-    private CryptoProvider mCryptoProvider = null;
     private View mMessageContentView;
     private Button mDecryptButton;
     private LinearLayout mCryptoSignatureLayout = null;
@@ -67,31 +66,15 @@ public class MessageCryptoView extends LinearLayout {
 
     }
 
-    public void setCryptoProvider(CryptoProvider provider){
-        mCryptoProvider = provider;
-    }
-
-    public PgpData getCryptoData() {
-        return mPgpData;
-    }
-
-    public void setCryptoData(PgpData data) {
-        if (data == null) {
-            mPgpData = new PgpData();
-        } else {
-            mPgpData = data;
-        }
-    }
-
     /**
      * Fill the decrypt layout with signature data, if known, make controls visible, if
      * they should be visible.
      */
-    public void updateLayout(final Message message) {
-        if (mPgpData.getSignatureKeyId() != 0) {
+    public void updateLayout(final CryptoProvider cryptoProvider, final PgpData pgpData, final Message message) {
+        if (pgpData.getSignatureKeyId() != 0) {
             mCryptoSignatureUserIdRest.setText(
-                mContext.getString(R.string.key_id, Long.toHexString(mPgpData.getSignatureKeyId() & 0xffffffffL)));
-            String userId = mPgpData.getSignatureUserId();
+                mContext.getString(R.string.key_id, Long.toHexString(pgpData.getSignatureKeyId() & 0xffffffffL)));
+            String userId = pgpData.getSignatureUserId();
             if (userId == null) {
                 userId = mContext.getString(R.string.unknown_crypto_signature_user_id);
             }
@@ -101,9 +84,9 @@ public class MessageCryptoView extends LinearLayout {
                 mCryptoSignatureUserIdRest.setText("<" + chunks[1]);
             }
             mCryptoSignatureUserId.setText(name);
-            if (mPgpData.getSignatureSuccess()) {
+            if (pgpData.getSignatureSuccess()) {
                 mCryptoSignatureStatusImage.setImageResource(R.drawable.overlay_ok);
-            } else if (mPgpData.getSignatureUnknown()) {
+            } else if (pgpData.getSignatureUnknown()) {
                 mCryptoSignatureStatusImage.setImageResource(R.drawable.overlay_error);
             } else {
                 mCryptoSignatureStatusImage.setImageResource(R.drawable.overlay_error);
@@ -113,12 +96,12 @@ public class MessageCryptoView extends LinearLayout {
         } else {
             mCryptoSignatureLayout.setVisibility(View.INVISIBLE);
         }
-        if (false || ((message == null) && (getDecryptedContent() == null))) {
+        if ((message == null) && (pgpData.getDecryptedData() == null)) {
             this.setVisibility(View.GONE);
             return;
         }
-        if (getDecryptedContent() != null) {
-            if (mPgpData.getSignatureKeyId() == 0) {
+        if (pgpData.getDecryptedData() != null) {
+            if (pgpData.getSignatureKeyId() == 0) {
                 this.setVisibility(View.GONE);
             } else {
                 // no need to show this after decryption/verification
@@ -140,7 +123,7 @@ public class MessageCryptoView extends LinearLayout {
                     if (part != null) {
                         data = MimeUtility.getTextFromPart(part);
                     }
-                    mCryptoProvider.decrypt(mActivity, data, mPgpData);
+                    cryptoProvider.decrypt(mActivity, data, pgpData);
                 } catch (MessagingException me) {
                     Log.e(K9.LOG_TAG, "Unable to decrypt email.", me);
                 }
@@ -149,10 +132,10 @@ public class MessageCryptoView extends LinearLayout {
 
 
         mDecryptButton.setVisibility(View.VISIBLE);
-        if (mCryptoProvider.isEncrypted(message)) {
+        if (cryptoProvider.isEncrypted(message)) {
             mDecryptButton.setText(R.string.btn_decrypt);
             this.setVisibility(View.VISIBLE);
-        } else if (mCryptoProvider.isSigned(message)) {
+        } else if (cryptoProvider.isSigned(message)) {
             mDecryptButton.setText(R.string.btn_verify);
             this.setVisibility(View.VISIBLE);
         } else {
@@ -169,8 +152,4 @@ public class MessageCryptoView extends LinearLayout {
         }
     }
 
-
-    public String getDecryptedContent() {
-        return mPgpData.getDecryptedData();
-    }
 }
diff --git a/src/com/fsck/k9/view/SingleMessageView.java b/src/com/fsck/k9/view/SingleMessageView.java
index 7ae7872a0..419ff5fa1 100644
--- a/src/com/fsck/k9/view/SingleMessageView.java
+++ b/src/com/fsck/k9/view/SingleMessageView.java
@@ -1,13 +1,210 @@
 package com.fsck.k9.view;
 
+import android.app.Activity;
 import android.content.Context;
 import android.util.AttributeSet;
+import android.util.Log;
+import android.view.KeyEvent;
+import android.view.LayoutInflater;
+import android.view.View;
+import android.widget.Button;
 import android.widget.LinearLayout;
+import com.fsck.k9.Account;
+import com.fsck.k9.K9;
+import com.fsck.k9.R;
+import com.fsck.k9.controller.MessagingController;
+import com.fsck.k9.controller.MessagingListener;
+import com.fsck.k9.crypto.CryptoProvider;
+import com.fsck.k9.crypto.PgpData;
+import com.fsck.k9.mail.*;
+import com.fsck.k9.mail.internet.MimeUtility;
+import com.fsck.k9.mail.store.LocalStore;
+
 
 /**
  */
-public class SingleMessageView extends LinearLayout{
+public class SingleMessageView extends LinearLayout {
+    private boolean mScreenReaderEnabled;
+    private MessageCryptoView mCryptoView;
+    private MessageWebView mMessageContentView;
+    private AccessibleWebView mAccessibleMessageContentView;
+    private MessageHeader mHeaderContainer;
+    private LinearLayout        mAttachments;
+    private View mShowPicturesSection;
+    private boolean mShowPictures;
+    private Button mDownloadRemainder;
+    private Activity mActivity;
+
+
+    public void initialize(Activity activity, Boolean isScreenReaderActive) {
+        mMessageContentView = (MessageWebView) findViewById(R.id.message_content);
+        mAccessibleMessageContentView = (AccessibleWebView) findViewById(R.id.accessible_message_content);
+        mAttachments = (LinearLayout) findViewById(R.id.attachments);
+        mHeaderContainer = (MessageHeader) findViewById(R.id.header_container);
+        mCryptoView = (MessageCryptoView) findViewById(R.id.layout_decrypt);
+        mCryptoView.setActivity(activity);
+        mCryptoView.setupChildViews();
+        mShowPicturesSection = findViewById(R.id.show_pictures_section);
+        mShowPictures = false;
+
+        mActivity = activity;
+
+        mDownloadRemainder = (Button) findViewById(R.id.download_remainder);
+        mMessageContentView.configure();
+
+
+        mAttachments.setVisibility(View.GONE);
+        if (isScreenReaderActive) {
+            mAccessibleMessageContentView.setVisibility(View.VISIBLE);
+            mMessageContentView.setVisibility(View.GONE);
+        } else {
+            mAccessibleMessageContentView.setVisibility(View.GONE);
+            mMessageContentView.setVisibility(View.VISIBLE);
+        }
+        mScreenReaderEnabled = isScreenReaderActive;
+
+    }
+
     public SingleMessageView(Context context, AttributeSet attrs) {
         super(context, attrs);
     }
+
+    public boolean showPictures() {
+        return mShowPictures;
+    }
+    public void setShowPictures(Boolean show) {
+        mShowPictures = show;
+    }
+
+    public void blockNetworkData(Boolean block) {
+        mMessageContentView.blockNetworkData(block);
+    }
+
+    public Button downloadRemainderButton() {
+        return  mDownloadRemainder;
+    }
+
+    public void showShowPicturesSection(boolean show) {
+        mShowPicturesSection.setVisibility(show ? View.VISIBLE : View.GONE);
+    }
+
+    public void setHeaders(final Message message, Account account) {
+        try {
+            mHeaderContainer.populate(message, account);
+            mHeaderContainer.setOnFlagListener(new OnClickListener() {
+                @Override public void onClick(View v) {
+                    if (message != null) {
+                        //TODO: reenable onFlag();
+                    }
+                }
+            });
+        } catch (Exception me) {
+            Log.e(K9.LOG_TAG, "setHeaders - error", me);
+        }
+        if (message.isSet(Flag.X_DOWNLOADED_FULL)) {
+            mDownloadRemainder.setVisibility(View.GONE);
+        } else {
+            mDownloadRemainder.setEnabled(true);
+            mDownloadRemainder.setVisibility(View.VISIBLE);
+        }
+    }
+    public void showAllHeaders() {
+        mHeaderContainer.onShowAdditionalHeaders();
+    }
+
+    public boolean additionalHeadersVisible() {
+        return mHeaderContainer.additionalHeadersVisible();
+    }
+
+
+    public void loadBodyFromUrl(Message message, String url) {
+        mMessageContentView.loadUrl(url);
+        // TODO reenable: updateCryptoLayout(cryptoProvider, pgpData, message);
+
+    }
+
+    public void loadBodyFromText(CryptoProvider cryptoProvider, PgpData pgpData, Message message, String emailText, String contentType) {
+        if (mScreenReaderEnabled) {
+            mAccessibleMessageContentView.loadDataWithBaseURL("http://", emailText, contentType, "utf-8", null);
+        } else {
+            mMessageContentView.loadDataWithBaseURL("http://", emailText, contentType, "utf-8", null);
+            mMessageContentView.scrollTo(0, 0);
+        }
+        updateCryptoLayout(cryptoProvider, pgpData, message);
+
+    }
+
+    public void updateCryptoLayout(CryptoProvider cp, PgpData pgpData, Message message) {
+        mCryptoView.updateLayout(cp, pgpData, message);
+    }
+
+    public void setAttachmentsEnabled(boolean enabled) {
+        for (int i = 0, count = mAttachments.getChildCount(); i < count; i++) {
+            AttachmentView attachment = (AttachmentView) mAttachments.getChildAt(i);
+            attachment.viewButton.setEnabled(enabled);
+            attachment.downloadButton.setEnabled(enabled);
+        }
+    }
+
+
+    public void removeAllAttachments() {
+        for (int i = 0, count = mAttachments.getChildCount(); i < count; i++) {
+            mAttachments.removeView(mAttachments.getChildAt(i));
+        }
+    }
+
+    public void renderAttachments(Part part, int depth,
+
+                                  Message message, Account account, MessagingController controller, MessagingListener listener) throws MessagingException {
+
+        if (part.getBody() instanceof Multipart) {
+            Multipart mp = (Multipart) part.getBody();
+            for (int i = 0; i < mp.getCount(); i++) {
+                renderAttachments(mp.getBodyPart(i), depth + 1, message, account, controller, listener);
+            }
+        } else if (part instanceof LocalStore.LocalAttachmentBodyPart) {
+            String contentDisposition = MimeUtility.unfoldAndDecode(part.getDisposition());
+            // Inline parts with a content-id are almost certainly components of an HTML message
+            // not attachments. Don't show attachment download buttons for them.
+            if (contentDisposition != null &&
+                    MimeUtility.getHeaderParameter(contentDisposition, null).matches("^(?i:inline)")
+                    && part.getHeader("Content-ID") != null) {
+                return;
+            }
+            LayoutInflater inflater = mActivity.getLayoutInflater();
+            AttachmentView view = (AttachmentView)inflater.inflate(R.layout.message_view_attachment, null);
+            if (view.populateFromPart(part, message, account, controller, listener)) {
+                addAttachment(view);
+            }
+        }
+    }
+
+
+    public void addAttachment(View attachmentView) {
+        mAttachments.addView(attachmentView);
+        mAttachments.setVisibility(View.VISIBLE);
+    }
+    public void zoom(KeyEvent event) {
+        if (mScreenReaderEnabled) {
+            mAccessibleMessageContentView.zoomIn();
+        } else {
+            if (event.isShiftPressed()) {
+                mMessageContentView.zoomIn();
+            } else {
+                mMessageContentView.zoomOut();
+            }
+        }
+    }
+    public void beginSelectingText() {
+        mMessageContentView.emulateShiftHeld();
+    }
+
+
+    public void resetView() {
+
+        mMessageContentView.scrollTo(0, 0);
+        mHeaderContainer.setVisibility(View.GONE);
+        mMessageContentView.clearView();
+        mAttachments.removeAllViews();
+    }
 }

From 111b9a63058055fc4b6ba8342541f38eb3beb4a3 Mon Sep 17 00:00:00 2001
From: Jesse Vincent <jesse@bestpractical.com>
Date: Fri, 11 Feb 2011 11:16:50 -0500
Subject: [PATCH 17/24] remove a pointless indirection and an extra method call
 to set the options menu when we didn't need to

---
 src/com/fsck/k9/activity/MessageView.java | 15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)

diff --git a/src/com/fsck/k9/activity/MessageView.java b/src/com/fsck/k9/activity/MessageView.java
index e94e19b43..2d1b5ee98 100644
--- a/src/com/fsck/k9/activity/MessageView.java
+++ b/src/com/fsck/k9/activity/MessageView.java
@@ -65,7 +65,6 @@ public class MessageView extends K9Activity implements OnClickListener {
     private MessagingController mController = MessagingController.getInstance(getApplication());
     private MessageReference mNextMessage = null;
     private MessageReference mPreviousMessage = null;
-    private Menu optionsMenu = null;
     private Listener mListener = new Listener();
     private MessageViewHandler mHandler = new MessageViewHandler();
     private Contacts mContacts;
@@ -754,7 +753,6 @@ public class MessageView extends K9Activity implements OnClickListener {
             try {
                 mMessage.setFlag(Flag.FLAGGED, !mMessage.isSet(Flag.FLAGGED));
                 mMessageView.setHeaders(mMessage, mAccount);
-                prepareMenuItems();
             } catch (MessagingException me) {
                 Log.e(K9.LOG_TAG, "Could not set flag on local message", me);
             }
@@ -1018,8 +1016,6 @@ public class MessageView extends K9Activity implements OnClickListener {
     public boolean onCreateOptionsMenu(Menu menu) {
         super.onCreateOptionsMenu(menu);
         getMenuInflater().inflate(R.menu.message_view_option, menu);
-        optionsMenu = menu;
-        prepareMenuItems();
         if (!mController.isCopyCapable(mAccount)) {
             menu.findItem(R.id.copy).setVisible(false);
         }
@@ -1037,12 +1033,6 @@ public class MessageView extends K9Activity implements OnClickListener {
         return true;
     }
 
-
-    @Override
-    public boolean onPrepareOptionsMenu(Menu menu) {
-        prepareMenuItems();
-        return super.onPrepareOptionsMenu(menu);
-    }
     // TODO: when switching to API version 8, override onCreateDialog(int, Bundle)
 
     /**
@@ -1060,8 +1050,8 @@ public class MessageView extends K9Activity implements OnClickListener {
         return super.onCreateDialog(id);
     }
 
-    private void prepareMenuItems() {
-        Menu menu = optionsMenu;
+    @Override
+    public boolean onPrepareOptionsMenu(Menu menu) {
         if (menu != null) {
             MenuItem flagItem = menu.findItem(R.id.flag);
             if (flagItem != null && mMessage != null) {
@@ -1073,6 +1063,7 @@ public class MessageView extends K9Activity implements OnClickListener {
                                                R.string.hide_full_header_action : R.string.show_full_header_action);
             }
         }
+        return super.onPrepareOptionsMenu(menu);
     }
 
     public void displayMessage(Account account, String folder, String uid, Message message) {

From 06baf3f60249d8d2a64eabf99435fd05e43bfa5a Mon Sep 17 00:00:00 2001
From: Jesse Vincent <jesse@bestpractical.com>
Date: Fri, 11 Feb 2011 12:09:47 -0500
Subject: [PATCH 18/24] simplify the "load a url for the message body"
 signature

---
 src/com/fsck/k9/activity/MessageView.java   | 6 +++---
 src/com/fsck/k9/view/SingleMessageView.java | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/com/fsck/k9/activity/MessageView.java b/src/com/fsck/k9/activity/MessageView.java
index 2d1b5ee98..d5776cfd1 100644
--- a/src/com/fsck/k9/activity/MessageView.java
+++ b/src/com/fsck/k9/activity/MessageView.java
@@ -1108,7 +1108,7 @@ public class MessageView extends K9Activity implements OnClickListener {
             } else {
                 mHandler.post(new Runnable() {
                     public void run() {
-                        mMessageView.loadBodyFromUrl(mMessage, "file:///android_asset/empty.html");
+                        mMessageView.loadBodyFromUrl("file:///android_asset/empty.html");
                     }
                 });
             }
@@ -1134,7 +1134,7 @@ public class MessageView extends K9Activity implements OnClickListener {
             new Runnable() {
                 public void run() {
                     if (!message.isSet(Flag.X_DOWNLOADED_FULL) && !message.isSet(Flag.X_DOWNLOADED_PARTIAL)) {
-                        mMessageView.loadBodyFromUrl(mMessage, "file:///android_asset/downloading.html");
+                        mMessageView.loadBodyFromUrl("file:///android_asset/downloading.html");
                     }
                     mMessageView.setHeaders(message, account);
                 }
@@ -1171,7 +1171,7 @@ public class MessageView extends K9Activity implements OnClickListener {
                     }
                     if ((MessageView.this.mMessage == null) ||
                     !MessageView.this.mMessage.isSet(Flag.X_DOWNLOADED_PARTIAL)) {
-                        mMessageView.loadBodyFromUrl(mMessage, "file:///android_asset/empty.html");
+                        mMessageView.loadBodyFromUrl("file:///android_asset/empty.html");
                     }
                 }
             });
diff --git a/src/com/fsck/k9/view/SingleMessageView.java b/src/com/fsck/k9/view/SingleMessageView.java
index 419ff5fa1..ae0eded72 100644
--- a/src/com/fsck/k9/view/SingleMessageView.java
+++ b/src/com/fsck/k9/view/SingleMessageView.java
@@ -117,7 +117,7 @@ public class SingleMessageView extends LinearLayout {
     }
 
 
-    public void loadBodyFromUrl(Message message, String url) {
+    public void loadBodyFromUrl(String url) {
         mMessageContentView.loadUrl(url);
         // TODO reenable: updateCryptoLayout(cryptoProvider, pgpData, message);
 

From 9deea3342637f5bfd3cb89194297cdcc6f6131f9 Mon Sep 17 00:00:00 2001
From: Jesse Vincent <jesse@bestpractical.com>
Date: Fri, 11 Feb 2011 12:10:45 -0500
Subject: [PATCH 19/24] re-enable setOnFlagListener

---
 src/com/fsck/k9/activity/MessageView.java   |  6 ++++++
 src/com/fsck/k9/view/SingleMessageView.java | 14 +++++++-------
 2 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/src/com/fsck/k9/activity/MessageView.java b/src/com/fsck/k9/activity/MessageView.java
index d5776cfd1..ee4a488bd 100644
--- a/src/com/fsck/k9/activity/MessageView.java
+++ b/src/com/fsck/k9/activity/MessageView.java
@@ -1137,6 +1137,12 @@ public class MessageView extends K9Activity implements OnClickListener {
                         mMessageView.loadBodyFromUrl("file:///android_asset/downloading.html");
                     }
                     mMessageView.setHeaders(message, account);
+                    mMessageView.setOnFlagListener(new OnClickListener() {
+                        @Override
+                        public void onClick(View v) {
+                            onFlag();
+                        }
+                    });
                 }
             });
         }
diff --git a/src/com/fsck/k9/view/SingleMessageView.java b/src/com/fsck/k9/view/SingleMessageView.java
index ae0eded72..163c5b2e1 100644
--- a/src/com/fsck/k9/view/SingleMessageView.java
+++ b/src/com/fsck/k9/view/SingleMessageView.java
@@ -91,13 +91,8 @@ public class SingleMessageView extends LinearLayout {
     public void setHeaders(final Message message, Account account) {
         try {
             mHeaderContainer.populate(message, account);
-            mHeaderContainer.setOnFlagListener(new OnClickListener() {
-                @Override public void onClick(View v) {
-                    if (message != null) {
-                        //TODO: reenable onFlag();
-                    }
-                }
-            });
+
+
         } catch (Exception me) {
             Log.e(K9.LOG_TAG, "setHeaders - error", me);
         }
@@ -108,6 +103,11 @@ public class SingleMessageView extends LinearLayout {
             mDownloadRemainder.setVisibility(View.VISIBLE);
         }
     }
+
+    public void setOnFlagListener(OnClickListener listener) {
+        mHeaderContainer.setOnFlagListener(listener);
+    }
+
     public void showAllHeaders() {
         mHeaderContainer.onShowAdditionalHeaders();
     }

From abc921093c02d0045d3010f4654589934f7e0109 Mon Sep 17 00:00:00 2001
From: Jesse Vincent <jesse@bestpractical.com>
Date: Fri, 11 Feb 2011 12:11:21 -0500
Subject: [PATCH 20/24] refactor display of the download button

---
 src/com/fsck/k9/activity/MessageView.java   | 3 ++-
 src/com/fsck/k9/view/SingleMessageView.java | 3 +++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/com/fsck/k9/activity/MessageView.java b/src/com/fsck/k9/activity/MessageView.java
index ee4a488bd..c6629fb7b 100644
--- a/src/com/fsck/k9/activity/MessageView.java
+++ b/src/com/fsck/k9/activity/MessageView.java
@@ -1185,7 +1185,7 @@ public class MessageView extends K9Activity implements OnClickListener {
 
         @Override
         public void loadMessageForViewFinished(Account account, String folder, String uid,
-                                               Message message) {
+                                               final Message message) {
             if (!mMessageReference.uid.equals(uid) || !mMessageReference.folderName.equals(folder)
                     || !mMessageReference.accountUuid.equals(account.getUuid())) {
                 return;
@@ -1193,6 +1193,7 @@ public class MessageView extends K9Activity implements OnClickListener {
             mHandler.post(new Runnable() {
                 public void run() {
                     setProgressBarIndeterminateVisibility(false);
+                    mMessageView.setShowDownloadButton(message);
                 }
             });
         }
diff --git a/src/com/fsck/k9/view/SingleMessageView.java b/src/com/fsck/k9/view/SingleMessageView.java
index 163c5b2e1..4213a75e9 100644
--- a/src/com/fsck/k9/view/SingleMessageView.java
+++ b/src/com/fsck/k9/view/SingleMessageView.java
@@ -96,6 +96,9 @@ public class SingleMessageView extends LinearLayout {
         } catch (Exception me) {
             Log.e(K9.LOG_TAG, "setHeaders - error", me);
         }
+    }
+
+    public void setShowDownloadButton(Message message) {
         if (message.isSet(Flag.X_DOWNLOADED_FULL)) {
             mDownloadRemainder.setVisibility(View.GONE);
         } else {

From 20623dc18a5650135ac7ca82567c488839fe4024 Mon Sep 17 00:00:00 2001
From: Jesse Vincent <jesse@bestpractical.com>
Date: Fri, 11 Feb 2011 12:12:09 -0500
Subject: [PATCH 21/24] slight clean up to cryptoprovider view interface

---
 src/com/fsck/k9/view/MessageCryptoView.java | 5 +++++
 src/com/fsck/k9/view/SingleMessageView.java | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/com/fsck/k9/view/MessageCryptoView.java b/src/com/fsck/k9/view/MessageCryptoView.java
index 9c7a7f1a9..e9c70bb58 100644
--- a/src/com/fsck/k9/view/MessageCryptoView.java
+++ b/src/com/fsck/k9/view/MessageCryptoView.java
@@ -66,6 +66,11 @@ public class MessageCryptoView extends LinearLayout {
 
     }
 
+
+    public void hide () {
+        this.setVisibility(View.GONE);
+    }
+
     /**
      * Fill the decrypt layout with signature data, if known, make controls visible, if
      * they should be visible.
diff --git a/src/com/fsck/k9/view/SingleMessageView.java b/src/com/fsck/k9/view/SingleMessageView.java
index 4213a75e9..74c31917b 100644
--- a/src/com/fsck/k9/view/SingleMessageView.java
+++ b/src/com/fsck/k9/view/SingleMessageView.java
@@ -122,7 +122,7 @@ public class SingleMessageView extends LinearLayout {
 
     public void loadBodyFromUrl(String url) {
         mMessageContentView.loadUrl(url);
-        // TODO reenable: updateCryptoLayout(cryptoProvider, pgpData, message);
+        mCryptoView.hide();
 
     }
 

From e099337c52dc7841ecf8d7ce5994871e2f886c3e Mon Sep 17 00:00:00 2001
From: Jesse Vincent <jesse@bestpractical.com>
Date: Fri, 11 Feb 2011 12:12:52 -0500
Subject: [PATCH 22/24] remove dead code

---
 src/com/fsck/k9/view/MessageCryptoView.java | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/src/com/fsck/k9/view/MessageCryptoView.java b/src/com/fsck/k9/view/MessageCryptoView.java
index e9c70bb58..479447c72 100644
--- a/src/com/fsck/k9/view/MessageCryptoView.java
+++ b/src/com/fsck/k9/view/MessageCryptoView.java
@@ -2,35 +2,20 @@ package com.fsck.k9.view;
 
 import android.app.Activity;
 import android.content.Context;
-import android.content.Intent;
-import android.graphics.Bitmap;
-import android.graphics.BitmapFactory;
-import android.net.Uri;
-import android.os.Environment;
 import android.util.AttributeSet;
 import android.util.Log;
 import android.view.View;
 import android.widget.LinearLayout;
 import android.widget.*;
-import com.fsck.k9.Account;
 import com.fsck.k9.K9;
 import com.fsck.k9.R;
-import com.fsck.k9.controller.MessagingController;
-import com.fsck.k9.controller.MessagingListener;
 import com.fsck.k9.crypto.CryptoProvider;
 import com.fsck.k9.crypto.PgpData;
-import com.fsck.k9.helper.MediaScannerNotifier;
-import com.fsck.k9.helper.SizeFormatter;
-import com.fsck.k9.helper.Utility;
 import com.fsck.k9.mail.Message;
 import com.fsck.k9.mail.MessagingException;
 import com.fsck.k9.mail.Part;
 import com.fsck.k9.mail.internet.MimeUtility;
-import com.fsck.k9.mail.store.LocalStore.LocalAttachmentBodyPart;
-import com.fsck.k9.provider.AttachmentProvider;
-import org.apache.commons.io.IOUtils;
 
-import java.io.*;
 
 
 
@@ -38,8 +23,6 @@ public class MessageCryptoView extends LinearLayout {
 
     private Context mContext;
     private Activity mActivity;
-    private PgpData mPgpData = null;
-    private View mMessageContentView;
     private Button mDecryptButton;
     private LinearLayout mCryptoSignatureLayout = null;
     private ImageView mCryptoSignatureStatusImage = null;

From 0d0415e70585fc919e453fcc57d72a24a7036c40 Mon Sep 17 00:00:00 2001
From: Jesse Vincent <jesse@bestpractical.com>
Date: Fri, 11 Feb 2011 12:13:18 -0500
Subject: [PATCH 23/24] use a single layout inflater for loading attachments

---
 src/com/fsck/k9/view/SingleMessageView.java | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/com/fsck/k9/view/SingleMessageView.java b/src/com/fsck/k9/view/SingleMessageView.java
index 74c31917b..87a3499f8 100644
--- a/src/com/fsck/k9/view/SingleMessageView.java
+++ b/src/com/fsck/k9/view/SingleMessageView.java
@@ -33,7 +33,7 @@ public class SingleMessageView extends LinearLayout {
     private View mShowPicturesSection;
     private boolean mShowPictures;
     private Button mDownloadRemainder;
-    private Activity mActivity;
+    private LayoutInflater mInflater;
 
 
     public void initialize(Activity activity, Boolean isScreenReaderActive) {
@@ -47,8 +47,7 @@ public class SingleMessageView extends LinearLayout {
         mShowPicturesSection = findViewById(R.id.show_pictures_section);
         mShowPictures = false;
 
-        mActivity = activity;
-
+        mInflater = activity.getLayoutInflater();
         mDownloadRemainder = (Button) findViewById(R.id.download_remainder);
         mMessageContentView.configure();
 
@@ -174,8 +173,7 @@ public class SingleMessageView extends LinearLayout {
                     && part.getHeader("Content-ID") != null) {
                 return;
             }
-            LayoutInflater inflater = mActivity.getLayoutInflater();
-            AttachmentView view = (AttachmentView)inflater.inflate(R.layout.message_view_attachment, null);
+            AttachmentView view = (AttachmentView)mInflater.inflate(R.layout.message_view_attachment, null);
             if (view.populateFromPart(part, message, account, controller, listener)) {
                 addAttachment(view);
             }

From ae2c93318152fd83aa0224c457835bf9393e3f1f Mon Sep 17 00:00:00 2001
From: Matt Johnston <matt@ucc.asn.au>
Date: Wed, 9 Feb 2011 20:27:24 +0800
Subject: [PATCH 24/24] Destroy all messages in one sqlite transaction

---
 .../k9/controller/MessagingController.java    | 14 +++++++++----
 src/com/fsck/k9/mail/store/LocalStore.java    | 21 +++++++++++++++++++
 2 files changed, 31 insertions(+), 4 deletions(-)

diff --git a/src/com/fsck/k9/controller/MessagingController.java b/src/com/fsck/k9/controller/MessagingController.java
index d053443fe..c8be8feab 100644
--- a/src/com/fsck/k9/controller/MessagingController.java
+++ b/src/com/fsck/k9/controller/MessagingController.java
@@ -1005,13 +1005,19 @@ public class MessagingController implements Runnable {
              * Remove any messages that are in the local store but no longer on the remote store or are too old
              */
             if (account.syncRemoteDeletions()) {
+                ArrayList<Message> destroyMessages = new ArrayList<Message>();
                 for (Message localMessage : localMessages) {
                     if (remoteUidMap.get(localMessage.getUid()) == null) {
-                        localMessage.destroy();
+                        destroyMessages.add(localMessage);
+                    }
+                }
 
-                        for (MessagingListener l : getListeners(listener)) {
-                            l.synchronizeMailboxRemovedMessage(account, folder, localMessage);
-                        }
+
+                localFolder.destroyMessages(destroyMessages.toArray(EMPTY_MESSAGE_ARRAY));
+
+                for (Message destroyMessage : destroyMessages) {
+                    for (MessagingListener l : getListeners(listener)) {
+                        l.synchronizeMailboxRemovedMessage(account, folder, destroyMessage);
                     }
                 }
             }
diff --git a/src/com/fsck/k9/mail/store/LocalStore.java b/src/com/fsck/k9/mail/store/LocalStore.java
index f706ed8de..672554921 100644
--- a/src/com/fsck/k9/mail/store/LocalStore.java
+++ b/src/com/fsck/k9/mail/store/LocalStore.java
@@ -2020,6 +2020,27 @@ public class LocalStore extends Store implements Serializable {
             appendMessages(messages, false);
         }
 
+        public void destroyMessages(final Message[] messages) throws MessagingException {
+                try {
+                    database.execute(true, new DbCallback<Void>() {
+                        @Override
+                        public Void doDbWork(final SQLiteDatabase db) throws WrappedException, UnavailableStorageException {
+                            for (Message message : messages) {
+                                try {
+                                    message.destroy();
+                                } catch (MessagingException e) {
+                                    throw new WrappedException(e);
+                                }
+                            }
+                            return null;
+                        }
+                    });
+                } catch (MessagingException e) {
+                    throw new WrappedException(e);
+                }
+        }
+
+
         /**
          * The method differs slightly from the contract; If an incoming message already has a uid
          * assigned and it matches the uid of an existing message then this message will replace the