moparisthebest/k-9
1
0
Fork 0
mirror of https://github.com/moparisthebest/k-9 synced 2025-03-01 09:01:47 -05:00
Code Issues Releases Wiki Activity

Avoid full table scan when creating the threaded message list

Browse Source
This commit is contained in:
cketti 2013-01-11 03:59:38 +01:00
parent 1df88ea153
commit 3ec623c174
1 changed files with 68 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

110
src/com/fsck/k9/provider/EmailProvider.java
View File

@ -385,6 +385,7 @@ public class EmailProvider extends ContentProvider {
UnavailableStorageException { UnavailableStorageException {
StringBuilder query = new StringBuilder(); StringBuilder query = new StringBuilder();
query.append("SELECT "); query.append("SELECT ");
boolean first = true; boolean first = true;
for (String columnName : projection) { for (String columnName : projection) {
@ -394,62 +395,37 @@ public class EmailProvider extends ContentProvider {
first = false; first = false;
} }
if (MessageColumns.DATE.equals(columnName)) { if (MessageColumns.ID.equals(columnName)) {
query.append("MAX(m.date) AS " + MessageColumns.DATE); query.append("u." + MessageColumns.ID + " AS " + MessageColumns.ID);
} else if (MessageColumns.DATE.equals(columnName)) {
query.append("MAX(date) AS " + MessageColumns.DATE);
} else if (SpecialColumns.THREAD_COUNT.equals(columnName)) { } else if (SpecialColumns.THREAD_COUNT.equals(columnName)) {
query.append("COUNT(h.id) AS " + SpecialColumns.THREAD_COUNT); query.append("COUNT(g) AS " + SpecialColumns.THREAD_COUNT);
} else if (SpecialColumns.FOLDER_NAME.equals(columnName)) {
query.append("f." + SpecialColumns.FOLDER_NAME + " AS " +
SpecialColumns.FOLDER_NAME);
} else if (SpecialColumns.INTEGRATE.equals(columnName)) {
query.append("f." + SpecialColumns.INTEGRATE + " AS " +
SpecialColumns.INTEGRATE);
} else if (ThreadColumns.ROOT.equals(columnName)) {
// Always return the thread ID of the root message (even for the root
// message itself)
query.append("CASE WHEN t2." + ThreadColumns.ROOT + " IS NULL THEN " +
"t2." + ThreadColumns.ID + " ELSE t2." + ThreadColumns.ROOT +
" END AS " + ThreadColumns.ROOT);
} else { } else {
query.append("m.");
query.append(columnName);
query.append(" AS ");
query.append(columnName); query.append(columnName);
} }
} }
query.append( query.append(" FROM (");
" FROM messages h " +
"LEFT JOIN threads t1 ON (t1.message_id = h.id) " +
"LEFT JOIN threads t2 ON (t1.id = t2.id OR t1.id = t2.root) " +
"LEFT JOIN messages m ON (m.id = t2.message_id) ");
if (Utility.arrayContainsAny(projection, (Object[]) FOLDERS_COLUMNS)) { createThreadedSubQuery(projection, selection, selectionArgs, "t1.id = t2.id", query);
query.append("LEFT JOIN folders f ON (m.folder_id = f.id) "); query.append(" UNION ALL ");
} createThreadedSubQuery(projection, selection, selectionArgs, "t1.id = t2.root", query);
query.append( query.append(") u GROUP BY g");
"WHERE " +
"(t1.root IS NULL AND " +
"m.deleted = 0 AND " +
"(m.empty IS NULL OR m.empty != 1)) ");
if (!StringUtils.isNullOrEmpty(selection)) {
query.append("AND (");
query.append(SqlQueryBuilder.addPrefixToSelection(MESSAGES_COLUMNS,
"h.", selection));
query.append(") ");
}
query.append("GROUP BY h.id");
if (!StringUtils.isNullOrEmpty(sortOrder)) { if (!StringUtils.isNullOrEmpty(sortOrder)) {
query.append(" ORDER BY "); query.append(" ORDER BY ");
query.append(SqlQueryBuilder.addPrefixToSelection(MESSAGES_COLUMNS, query.append(SqlQueryBuilder.addPrefixToSelection(MESSAGES_COLUMNS,
"m.", sortOrder)); "u.", sortOrder));
} }
return db.rawQuery(query.toString(), selectionArgs); // We need the selection arguments twice. Once for each sub query.
String[] args = new String[selectionArgs.length * 2];
System.arraycopy(selectionArgs, 0, args, 0, selectionArgs.length);
System.arraycopy(selectionArgs, 0, args, selectionArgs.length, selectionArgs.length);
return db.rawQuery(query.toString(), args);
} }
}); });
} catch (UnavailableStorageException e) { } catch (UnavailableStorageException e) {
@ -457,6 +433,56 @@ public class EmailProvider extends ContentProvider {
} }
} }
private void createThreadedSubQuery(String[] projection, String selection,
String[] selectionArgs, String join, StringBuilder query) {
query.append("SELECT h." + MessageColumns.ID + " AS g");
for (String columnName : projection) {
if (SpecialColumns.THREAD_COUNT.equals(columnName)) {
// Skip
} else if (SpecialColumns.FOLDER_NAME.equals(columnName) ||
SpecialColumns.INTEGRATE.equals(columnName)) {
query.append("," + columnName);
} else if (ThreadColumns.ROOT.equals(columnName)) {
// Always return the thread ID of the root message (even for the root
// message itself)
query.append(",CASE WHEN t2." + ThreadColumns.ROOT + " IS NULL THEN " +
"t2." + ThreadColumns.ID + " ELSE t2." + ThreadColumns.ROOT +
" END AS " + ThreadColumns.ROOT);
} else {
query.append(",m.");
query.append(columnName);
query.append(" AS ");
query.append(columnName);
}
}
query.append(
" FROM messages h " +
"LEFT JOIN threads t1 ON (t1.message_id = h.id) " +
"JOIN threads t2 ON (");
query.append(join);
query.append(") " +
"LEFT JOIN messages m ON (m.id = t2.message_id) ");
if (Utility.arrayContainsAny(projection, (Object[]) FOLDERS_COLUMNS)) {
query.append("LEFT JOIN folders f ON (m.folder_id = f.id) ");
}
query.append(
"WHERE " +
"(t1.root IS NULL AND " +
"m.deleted = 0 AND " +
"(m.empty IS NULL OR m.empty != 1))");
if (!StringUtils.isNullOrEmpty(selection)) {
query.append(" AND (");
query.append(SqlQueryBuilder.addPrefixToSelection(MESSAGES_COLUMNS,
"h.", selection));
query.append(")");
}
}
protected Cursor getThread(String accountUuid, final String[] projection, final String threadId, protected Cursor getThread(String accountUuid, final String[] projection, final String threadId,
final String sortOrder) { final String sortOrder) {