From 309a4d6107f1bfb071989fbe81fbfe86e78cc156 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A1s=20Veres-Szentkir=C3=A1lyi?= Date: Sat, 15 Feb 2014 21:38:05 +0100 Subject: [PATCH] Use more efficient entrySet iterator instead of keySet + get() The loop extracted keys from `folderMap` and then called `folderMap.get(...)` for every key. If both the key and the value needs to be iterated on, `Map.entrySet()` is a more efficient solution as it doesn't require O(n) Map lookups. --- src/com/fsck/k9/fragment/MessageListFragment.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/com/fsck/k9/fragment/MessageListFragment.java b/src/com/fsck/k9/fragment/MessageListFragment.java index ff2f176f5..f6035c47e 100644 --- a/src/com/fsck/k9/fragment/MessageListFragment.java +++ b/src/com/fsck/k9/fragment/MessageListFragment.java @@ -2667,8 +2667,9 @@ public class MessageListFragment extends SherlockFragment implements OnItemClick outMessages.add(message); } - for (String folderName : folderMap.keySet()) { - List outMessages = folderMap.get(folderName); + for (Map.Entry> entry : folderMap.entrySet()) { + String folderName = entry.getKey(); + List outMessages = entry.getValue(); Account account = outMessages.get(0).getFolder().getAccount(); if (operation == FolderOperation.MOVE) {