From 2fd9bd5a03c90044a02513ecce3e663f4e1b2a26 Mon Sep 17 00:00:00 2001
From: Andrew Gaul <gaul@maginatics.com>
Date: Tue, 31 May 2011 15:11:36 +0200
Subject: [PATCH] Cleanup Utility.combine()

Fix spelling mistakes, simplify adding separators, use unsynchronized
StringBuilder, and fix Javadoc.
---
 src/com/fsck/k9/helper/Utility.java | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/src/com/fsck/k9/helper/Utility.java b/src/com/fsck/k9/helper/Utility.java
index c1faa8d91..d06734f5f 100644
--- a/src/com/fsck/k9/helper/Utility.java
+++ b/src/com/fsck/k9/helper/Utility.java
@@ -57,24 +57,25 @@ public class Utility {
     }
 
     /**
-     * Combines the given array of Objects into a single string using the
-     * seperator character and each Object's toString() method. between each
-     * part.
+     * Combines the given array of Objects into a single String using
+     * each Object's toString() method and the separator character
+     * between each part.
      *
      * @param parts
-     * @param seperator
-     * @return
+     * @param separator
+     * @return new String
      */
-    public static String combine(Object[] parts, char seperator) {
+    public static String combine(Object[] parts, char separator) {
         if (parts == null) {
             return null;
+        } else if (parts.length == 0) {
+            return "";
         }
-        StringBuffer sb = new StringBuffer();
-        for (int i = 0; i < parts.length; i++) {
-            sb.append(parts[i].toString());
-            if (i < parts.length - 1) {
-                sb.append(seperator);
-            }
+        StringBuilder sb = new StringBuilder();
+        sb.append(parts[0]);
+        for (int i = 1; i < parts.length; ++i) {
+            sb.append(separator);
+            sb.append(parts[i]);
         }
         return sb.toString();
     }