moparisthebest/k-9
1
0
Fork 0
mirror of https://github.com/moparisthebest/k-9 synced 2024-12-24 08:38:51 -05:00
Code Issues Releases Wiki Activity

Use one database transaction when doing bulk flag changes

Browse Source 
Previously we used one transaction per message. For 500 messages the
database updates alone took over 30s on my Nexus 7.
This commit is contained in:
cketti 2012-11-27 16:46:59 +01:00
parent 3b022cd72f
commit 2db8034c31
1 changed files with 22 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/com/fsck/k9/mail/store/LocalStore.java
View File

@ -2795,11 +2795,30 @@ public class LocalStore extends Store implements Serializable {
}
@Override
public void setFlags(Message[] messages, Flag[] flags, boolean value)
public void setFlags(final Message[] messages, final Flag[] flags, final boolean value)
throws MessagingException {
open(OpenMode.READ_WRITE);
for (Message message : messages) {
message.setFlags(flags, value);
// Use one transaction to set all flags
try {
database.execute(true, new DbCallback<Void>() {
@Override
public Void doDbWork(final SQLiteDatabase db) throws WrappedException,
UnavailableStorageException {
for (Message message : messages) {
try {
message.setFlags(flags, value);
} catch (MessagingException e) {
Log.e(K9.LOG_TAG, "Something went wrong while setting flag", e);
}
}
return null;
}
});
} catch (WrappedException e) {
throw(MessagingException) e.getCause();
}
}