From 222cd43c80c67f2d0f5a1942d60ce42273f01015 Mon Sep 17 00:00:00 2001 From: cketti Date: Fri, 17 Jun 2011 04:13:32 +0200 Subject: [PATCH] Some code cleanup. No functional changes. --- .../fsck/k9/mail/internet/MimeBodyPart.java | 28 ++++++------------- .../fsck/k9/mail/internet/MimeMessage.java | 13 ++------- 2 files changed, 11 insertions(+), 30 deletions(-) diff --git a/src/com/fsck/k9/mail/internet/MimeBodyPart.java b/src/com/fsck/k9/mail/internet/MimeBodyPart.java index bc8c058f0..ee7f2b5c3 100644 --- a/src/com/fsck/k9/mail/internet/MimeBodyPart.java +++ b/src/com/fsck/k9/mail/internet/MimeBodyPart.java @@ -77,35 +77,25 @@ public class MimeBodyPart extends BodyPart { public String getContentType() throws MessagingException { String contentType = getFirstHeader(MimeHeader.HEADER_CONTENT_TYPE); - if (contentType == null) { - return "text/plain"; - } else { - return contentType; - } + return (contentType == null) ? "text/plain" : contentType; } public String getDisposition() throws MessagingException { - String contentDisposition = getFirstHeader(MimeHeader.HEADER_CONTENT_DISPOSITION); - if (contentDisposition == null) { - return null; - } else { - return contentDisposition; - } + return getFirstHeader(MimeHeader.HEADER_CONTENT_DISPOSITION); } public String getContentId() throws MessagingException { String contentId = getFirstHeader(MimeHeader.HEADER_CONTENT_ID); if (contentId == null) { return null; - } else { - int first = contentId.indexOf('<'); - int last = contentId.lastIndexOf('>'); - if (first != -1 && last != -1) { - return contentId.substring(first + 1, last); - } else { - return contentId; - } } + + int first = contentId.indexOf('<'); + int last = contentId.lastIndexOf('>'); + + return (first != -1 && last != -1) ? + contentId.substring(first + 1, last) : + contentId; } public String getMimeType() throws MessagingException { diff --git a/src/com/fsck/k9/mail/internet/MimeMessage.java b/src/com/fsck/k9/mail/internet/MimeMessage.java index 505d88868..64893674e 100644 --- a/src/com/fsck/k9/mail/internet/MimeMessage.java +++ b/src/com/fsck/k9/mail/internet/MimeMessage.java @@ -130,20 +130,11 @@ public class MimeMessage extends Message { @Override public String getContentType() throws MessagingException { String contentType = getFirstHeader(MimeHeader.HEADER_CONTENT_TYPE); - if (contentType == null) { - return "text/plain"; - } else { - return contentType.toLowerCase(); - } + return (contentType == null) ? "text/plain" : contentType.toLowerCase(); } public String getDisposition() throws MessagingException { - String contentDisposition = getFirstHeader(MimeHeader.HEADER_CONTENT_DISPOSITION); - if (contentDisposition == null) { - return null; - } else { - return contentDisposition; - } + return getFirstHeader(MimeHeader.HEADER_CONTENT_DISPOSITION); } public String getContentId() throws MessagingException { return null;