moparisthebest
/
k-9
mirror of https://github.com/moparisthebest/k-9
1
0
Fork 0
Code Issues Releases Wiki Activity

Extract code to display error/status messages to a separate method

This commit is contained in:
cketti 2014-10-20 19:50:41 -04:00
parent dfe1771fcb
commit 187d760e5f
1 changed files with 13 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/com/fsck/k9/view/AttachmentView.java
View File

@ -287,9 +287,8 @@ public class AttachmentView extends FrameLayout implements OnClickListener, OnLo
* Abort early if there's no place to save the attachment. We don't want to spend * Abort early if there's no place to save the attachment. We don't want to spend
* the time downloading it and then abort. * the time downloading it and then abort.
*/ */
Toast.makeText(mContext, String message = mContext.getString(R.string.message_view_status_attachment_not_saved);
mContext.getString(R.string.message_view_status_attachment_not_saved), displayMessageToUser(message);
Toast.LENGTH_SHORT).show();
return; return;
} }
if (mMessage != null) { if (mMessage != null) {
@ -309,22 +308,24 @@ public class AttachmentView extends FrameLayout implements OnClickListener, OnLo
mContext.startActivity(intent); mContext.startActivity(intent);
} catch (Exception e) { } catch (Exception e) {
Log.e(K9.LOG_TAG, "Could not display attachment of type " + contentType, e); Log.e(K9.LOG_TAG, "Could not display attachment of type " + contentType, e);
Toast toast = Toast.makeText(mContext, mContext.getString(R.string.message_view_no_viewer, contentType),
Toast.LENGTH_LONG); String message = mContext.getString(R.string.message_view_no_viewer, contentType);
toast.show(); displayMessageToUser(message);
} }
} }
public void attachmentSaved(final String filename) { public void attachmentSaved(final String filename) {
Toast.makeText(mContext, String.format( String message = mContext.getString(R.string.message_view_status_attachment_saved, filename);
mContext.getString(R.string.message_view_status_attachment_saved), filename), displayMessageToUser(message);
Toast.LENGTH_LONG).show();
} }
public void attachmentNotSaved() { public void attachmentNotSaved() {
Toast.makeText(mContext, String message = mContext.getString(R.string.message_view_status_attachment_not_saved);
mContext.getString(R.string.message_view_status_attachment_not_saved), displayMessageToUser(message);
Toast.LENGTH_LONG).show(); }
private void displayMessageToUser(String message) {
Toast.makeText(mContext, message, Toast.LENGTH_LONG).show();
} }
public void setCallback(AttachmentFileDownloadCallback callback) { public void setCallback(AttachmentFileDownloadCallback callback) {