1
0
mirror of https://github.com/moparisthebest/curl synced 2024-08-13 17:03:50 -04:00
Go to file
Jay Satiro d934059afd Revert "multi: support verbose conncache closure handle"
This reverts commit b0972bc.

- No longer show verbose output for the conncache closure handle.

The offending commit was added so that the conncache closure handle
would inherit verbose mode from the user's easy handle. (Note there is
no way for the user to set options for the closure handle which is why
that was necessary.) Other debug settings such as the debug function
were not also inherited since we determined that could lead to crashes
if the user's per-handle private data was used on an unexpected handle.

The reporter here says he has a debug function to capture the verbose
output, and does not expect or want any output to stderr; however
because the conncache closure handle does not inherit the debug function
the verbose output for that handle does go to stderr.

There are other plausible scenarios as well such as the user redirects
stderr on their handle, which is also not inherited since it could lead
to crashes when used on an unexpected handle.

Short of allowing the user to set options for the conncache closure
handle I don't think there's much we can safely do except no longer
inherit the verbose setting.

Bug: https://curl.haxx.se/mail/lib-2019-05/0021.html
Reported-by: Kristoffer Gleditsch

Ref: https://github.com/curl/curl/pull/3598
Ref: https://github.com/curl/curl/pull/3618

Closes https://github.com/curl/curl/pull/3856
2019-05-10 15:01:57 -04:00
.github docs/BUG-BOUNTY: bug bounty time [skip ci] 2019-04-22 17:19:19 +02:00
CMake build: fix Codacy/CppCheck warnings 2019-04-11 21:08:44 +02:00
docs BUG-BOUNTY: minor formatting fixes [ci skip] 2019-05-09 23:30:26 +02:00
include urlapi: add CURLUPART_ZONEID to set and get 2019-05-05 15:52:46 +02:00
lib Revert "multi: support verbose conncache closure handle" 2019-05-10 15:01:57 -04:00
m4 configure: add --with-amissl 2019-03-15 10:22:42 +01:00
packages OS400/ccsidcurl.c: code style fixes 2019-05-03 23:19:56 +02:00
projects README: Schannel, stop calling it "winssl" 2019-04-10 22:05:38 +01:00
scripts scripts: fix typos 2019-03-31 22:55:09 +02:00
src tool_help: Warn if curl and libcurl versions do not match 2019-04-16 03:09:42 -04:00
tests Revert "multi: support verbose conncache closure handle" 2019-05-10 15:01:57 -04:00
winbuild gen_resp_file.bat: Removed unnecessary @ from all but the first command 2019-05-09 03:59:00 +01:00
.cirrus.yml cirrus: Customize the disabled tests per FreeBSD version 2019-04-01 10:16:10 +02:00
.dir-locals.el Add .dir-locals and set c-basic-offset to 2. 2015-12-23 10:16:14 +01:00
.gitattributes .gitattributes: make tabs in indentation a visible error 2018-12-06 20:21:17 +01:00
.gitignore scripts/completion.pl: also generate fish completion file 2019-03-02 11:31:18 +01:00
.lgtm.yml CI: add lgtm.yml for tweaking lgtm.com analysis 2018-03-22 00:04:55 +01:00
.mailmap URL and mailmap updates, remove an obsolete directory [ci skip] 2018-09-22 07:58:32 +00:00
.travis-iconv-env.sh travis: add build with iconv enabled 2018-02-15 14:18:34 +01:00
.travis.yml travis: update mesalink build to xenial 2019-05-08 10:24:19 +02:00
acinclude.m4 configure: add --with-amissl 2019-03-15 10:22:42 +01:00
appveyor.yml AppVeyor: enable testing for WinSSL build 2019-04-11 21:11:35 +02:00
buildconf includes: remove curl/curlbuild.h and curl/curlrules.h 2017-06-14 11:07:33 +02:00
buildconf.bat whitespace fixes 2018-09-23 22:24:02 +00:00
CHANGES CHANGES: spell fix, use correct path to script 2017-02-07 08:22:37 +01:00
CMakeLists.txt cmake: rename CMAKE_USE_DARWINSSL to CMAKE_USE_SECTRANSP 2019-04-27 11:51:23 +02:00
configure.ac configure: fix default location for fish completions 2019-04-05 13:26:46 +02:00
COPYING COPYING: it's 2019 2019-01-19 20:26:31 +01:00
curl-config.in curl-config.in: remove dependency on bc 2018-10-26 00:06:19 +02:00
GIT-INFO CHANGES.0: removed 2017-02-07 08:20:10 +01:00
libcurl.pc.in URLs: change all http:// URLs to https:// 2016-02-03 00:19:02 +01:00
MacOSX-Framework includes: remove curl/curlbuild.h and curl/curlrules.h 2017-06-14 11:07:33 +02:00
Makefile.am scripts/completion.pl: also generate fish completion file 2019-03-02 11:31:18 +01:00
Makefile.dist build: remove the Borland specific makefiles 2018-06-02 11:23:40 +02:00
maketgz maketgz: delete .bak files, fix indentation 2018-06-15 23:28:34 +00:00
README docs: minor polish to the bug bounty / security docs 2019-04-29 08:09:10 +02:00
README.md docs: minor polish to the bug bounty / security docs 2019-04-29 08:09:10 +02:00
RELEASE-NOTES RELEASE-NOTES: synced 2019-05-09 15:26:14 +02:00

curl logo

CII Best Practices Coverity passed Travis-CI Build Status AppVeyor Build Status Cirrus Build Status Coverage Status Backers on Open Collective Sponsors on Open Collective Language Grade: C/C++ Codacy Badge

Curl is a command-line tool for transferring data specified with URL syntax. Find out how to use curl by reading the curl.1 man page or the MANUAL document. Find out how to install Curl by reading the INSTALL document.

libcurl is the library curl is using to do its job. It is readily available to be used by your software. Read the libcurl.3 man page to learn how!

You find answers to the most frequent questions we get in the FAQ document.

Study the COPYING file for distribution terms and similar. If you distribute curl binaries or other binaries that involve libcurl, you might enjoy the LICENSE-MIXING document.

Contact

If you have problems, questions, ideas or suggestions, please contact us by posting to a suitable mailing list.

All contributors to the project are listed in the THANKS document.

Website

Visit the curl web site for the latest news and downloads.

Git

To download the very latest source from the Git server do this:

git clone https://github.com/curl/curl.git

(you'll get a directory named curl created, filled with the source code)

Security problems

Report suspected security problems via our HackerOne page and not in public!

Notice

Curl contains pieces of source code that is Copyright (c) 1998, 1999 Kungliga Tekniska Högskolan. This notice is included here to comply with the distribution terms.

Backers

Thank you to all our backers! 🙏 [Become a backer]

Sponsors

Support this project by becoming a sponsor. Your logo will show up here with a link to your website. [Become a sponsor]