mirror of
https://github.com/moparisthebest/curl
synced 2024-11-05 00:55:04 -05:00
9c1806ae46
- Disable warning C4127 "conditional expression is constant" globally
in curl_setup.h for when building with Microsoft's compiler.
This mainly affects building with the Visual Studio project files found
in the projects dir.
Prior to this change the cmake and winbuild build systems already
disabled 4127 globally for when building with Microsoft's compiler.
Also, 4127 was already disabled for all build systems in the limited
circumstance of the WHILE_FALSE macro which disabled the warning
specifically for while(0). This commit removes the WHILE_FALSE macro and
all other cruft in favor of disabling globally in curl_setup.
Background:
We have various macros that cause 0 or 1 to be evaluated, which would
cause warning C4127 in Visual Studio. For example this causes it:
#define Curl_resolver_asynch() 1
Full behavior is not clearly defined and inconsistent across versions.
However it is documented that since VS 2015 Update 3 Microsoft has
addressed this somewhat but not entirely, not warning on while(true) for
example.
Prior to this change some C4127 warnings occurred when I built with
Visual Studio using the generated projects in the projects dir.
Closes https://github.com/curl/curl/pull/4658
137 lines
4.2 KiB
CMake
137 lines
4.2 KiB
CMake
set(TARGET_LABEL_PREFIX "Test ")
|
|
|
|
function(setup_test TEST_NAME) # ARGN are the files in the test
|
|
add_executable( ${TEST_NAME} ${ARGN} )
|
|
string(TOUPPER ${TEST_NAME} UPPER_TEST_NAME)
|
|
|
|
include_directories(
|
|
${CURL_SOURCE_DIR}/lib # To be able to reach "curl_setup_once.h"
|
|
${CURL_BINARY_DIR}/lib # To be able to reach "curl_config.h"
|
|
${CURL_BINARY_DIR}/include # To be able to reach "curl/curl.h"
|
|
${CURL_SOURCE_DIR}/tests/libtest # To be able to build generated tests
|
|
)
|
|
if(USE_ARES)
|
|
include_directories(${CARES_INCLUDE_DIR})
|
|
endif()
|
|
|
|
target_link_libraries(${TEST_NAME} libcurl ${CURL_LIBS})
|
|
|
|
set_target_properties(${TEST_NAME}
|
|
PROPERTIES COMPILE_DEFINITIONS ${UPPER_TEST_NAME})
|
|
set_target_properties(${TEST_NAME}
|
|
PROPERTIES PROJECT_LABEL "${TARGET_LABEL_PREFIX}${TEST_NAME}")
|
|
endfunction()
|
|
|
|
|
|
transform_makefile_inc("Makefile.inc" "${CMAKE_CURRENT_BINARY_DIR}/Makefile.inc.cmake")
|
|
include(${CMAKE_CURRENT_BINARY_DIR}/Makefile.inc.cmake)
|
|
|
|
foreach(TEST_NAME ${noinst_PROGRAMS})
|
|
if(DEFINED ${TEST_NAME}_SOURCES)
|
|
setup_test(${TEST_NAME} ${${TEST_NAME}_SOURCES})
|
|
else()
|
|
setup_test(${TEST_NAME} ${nodist_${TEST_NAME}_SOURCES})
|
|
endif()
|
|
endforeach()
|
|
|
|
# Allows for hostname override to make tests machine independent.
|
|
# TODO this cmake build assumes a shared build, detect static linking here!
|
|
if(NOT WIN32)
|
|
add_library(hostname MODULE sethostname.c sethostname.h)
|
|
# Output to .libs for compatibility with autotools, the test data expects a
|
|
# library at (tests)/libtest/.libs/libhostname.so
|
|
set_target_properties(hostname PROPERTIES
|
|
LIBRARY_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/.libs)
|
|
if(HIDES_CURL_PRIVATE_SYMBOLS)
|
|
set_property(TARGET hostname APPEND PROPERTY COMPILE_DEFINITIONS "CURL_HIDDEN_SYMBOLS")
|
|
set_property(TARGET hostname APPEND PROPERTY COMPILE_FLAGS ${CURL_CFLAG_SYMBOLS_HIDE})
|
|
endif()
|
|
endif()
|
|
|
|
add_custom_command(
|
|
OUTPUT lib1521.c
|
|
COMMAND ${PERL_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/mk-lib1521.pl < ${CURL_SOURCE_DIR}/include/curl/curl.h > lib1521.c
|
|
DEPENDS
|
|
"${CMAKE_CURRENT_SOURCE_DIR}/mk-lib1521.pl"
|
|
"${CURL_SOURCE_DIR}/include/curl/curl.h"
|
|
VERBATIM)
|
|
|
|
set_property(TARGET chkdecimalpoint
|
|
APPEND PROPERTY COMPILE_DEFINITIONS "CURLX_NO_MEMORY_CALLBACKS;CURL_STATICLIB")
|
|
|
|
# # files used only in some libcurl test programs
|
|
# SET(TESTUTIL testutil.c testutil.h)
|
|
|
|
# # these files are used in every single test program below
|
|
# SET(SUPPORTFILES first.c test.h)
|
|
|
|
# # These are all libcurl test programs
|
|
# SET(noinst_PROGRAMS
|
|
# lib500 lib501 lib502 lib503 lib504 lib505 lib506
|
|
# lib507 lib508 lib510 lib511 lib512 lib513 lib514 lib515 lib516
|
|
# lib517 lib518 lib519 lib520 lib521 lib523 lib524 lib525 lib526
|
|
# #lib527
|
|
# #lib529
|
|
# lib530
|
|
# #lib532
|
|
# lib533 lib536 lib537 lib540 lib541 lib542 lib543
|
|
# lib544
|
|
# #lib545
|
|
# lib547
|
|
# #lib548
|
|
# lib549 lib552 lib553 lib554 lib555 lib556
|
|
# lib539 lib557
|
|
# lib560
|
|
# )
|
|
|
|
# SET(noinst_PROGRAMS_USE_TESTUTIL
|
|
# lib502 lib503 lib504
|
|
# lib507
|
|
# lib525 lib526 lib527
|
|
# lib529
|
|
# lib530
|
|
# lib532
|
|
# lib533 lib536
|
|
# lib555
|
|
# )
|
|
|
|
# MACRO(ADD_TESTUTIL_IF_NECESSARY TEST_NAME)
|
|
# LIST(FIND noinst_PROGRAMS_USE_TESTUTIL ${TEST_NAME} USES_TESTUTIL)
|
|
# IF(NOT ${USES_TESTUTIL} EQUAL -1)
|
|
# LIST(APPEND SOURCE ${TESTUTIL}) # Need TestUtil
|
|
# ENDIF()
|
|
# ENDMACRO()
|
|
|
|
# # General case
|
|
# FOREACH(TEST_NAME ${noinst_PROGRAMS})
|
|
# SET(SOURCE "${TEST_NAME}.c" ${SUPPORTFILES})
|
|
# ADD_TESTUTIL_IF_NECESSARY(${TEST_NAME})
|
|
# SETUP_TEST(${TEST_NAME} ${SOURCE})
|
|
# ENDFOREACH()
|
|
|
|
# # Special cases
|
|
# SET(TEST_NAME lib527)
|
|
# SET(SOURCE "lib526.c" ${SUPPORTFILES})
|
|
# ADD_TESTUTIL_IF_NECESSARY(${TEST_NAME})
|
|
# SETUP_TEST(${TEST_NAME} ${SOURCE})
|
|
|
|
# SET(TEST_NAME lib529)
|
|
# SET(SOURCE "lib525.c" ${SUPPORTFILES})
|
|
# ADD_TESTUTIL_IF_NECESSARY(${TEST_NAME})
|
|
# SETUP_TEST(${TEST_NAME} ${SOURCE})
|
|
|
|
# SET(TEST_NAME lib532)
|
|
# SET(SOURCE "lib526.c" ${SUPPORTFILES})
|
|
# ADD_TESTUTIL_IF_NECESSARY(${TEST_NAME})
|
|
# SETUP_TEST(${TEST_NAME} ${SOURCE})
|
|
|
|
# SET(TEST_NAME lib545)
|
|
# SET(SOURCE "lib544.c" ${SUPPORTFILES})
|
|
# ADD_TESTUTIL_IF_NECESSARY(${TEST_NAME})
|
|
# SETUP_TEST(${TEST_NAME} ${SOURCE})
|
|
|
|
# SET(TEST_NAME lib548)
|
|
# SET(SOURCE "lib547.c" ${SUPPORTFILES})
|
|
# ADD_TESTUTIL_IF_NECESSARY(${TEST_NAME})
|
|
# SETUP_TEST(${TEST_NAME} ${SOURCE})
|