mirror of
https://github.com/moparisthebest/curl
synced 2024-11-13 21:15:08 -05:00
bf6dc61967
I suspect this is a regression introduced in commit 207cf150, included
since 7.24.0.
Avoid showing '(nil)' as hostname in verbose output by making sure the
hostname fixup function is called early enough to set the pointers that
are used for this. The name data is set again for each request even for
re-used connections to handle multiple hostnames over the same
connection (like with proxy) or that the casing etc of the host name is
changed between requests (which has proven to be important at least once
in the past).
Test1011 was modified to use a redirect with a re-used a connection
since it then showed the bug and now lo longer does. There's currently
no easy way to have the test suite detect 'nil' texts in verbose ouputs
so no tests will detect if this problem gets reintroduced.
Bug: http://curl.haxx.se/mail/lib-2012-07/0111.html
Reported by: Gisle Vanem
77 lines
1.2 KiB
Plaintext
77 lines
1.2 KiB
Plaintext
<testcase>
|
|
<info>
|
|
<keywords>
|
|
HTTP
|
|
HTTP POST
|
|
followlocation
|
|
</keywords>
|
|
</info>
|
|
#
|
|
# Server-side
|
|
<reply>
|
|
<data>
|
|
HTTP/1.1 301 OK
|
|
Location: moo.html&testcase=/10110002
|
|
Date: Thu, 09 Nov 2010 14:49:00 GMT
|
|
Content-Length: 0
|
|
|
|
</data>
|
|
<data2>
|
|
HTTP/1.1 200 OK swsclose
|
|
Location: this should be ignored
|
|
Date: Thu, 09 Nov 2010 14:49:00 GMT
|
|
Connection: close
|
|
|
|
body
|
|
</data2>
|
|
<datacheck>
|
|
HTTP/1.1 301 OK
|
|
Location: moo.html&testcase=/10110002
|
|
Date: Thu, 09 Nov 2010 14:49:00 GMT
|
|
Content-Length: 0
|
|
|
|
HTTP/1.1 200 OK swsclose
|
|
Location: this should be ignored
|
|
Date: Thu, 09 Nov 2010 14:49:00 GMT
|
|
Connection: close
|
|
|
|
body
|
|
</datacheck>
|
|
</reply>
|
|
|
|
#
|
|
# Client-side
|
|
<client>
|
|
<server>
|
|
http
|
|
</server>
|
|
<name>
|
|
HTTP POST with 301 redirect
|
|
</name>
|
|
<command>
|
|
http://%HOSTIP:%HTTPPORT/blah/1011 -L -d "moo"
|
|
</command>
|
|
</client>
|
|
|
|
#
|
|
# Verify data after the test has been "shot"
|
|
<verify>
|
|
<strip>
|
|
^User-Agent:.*
|
|
</strip>
|
|
<protocol>
|
|
POST /blah/1011 HTTP/1.1
|
|
Host: %HOSTIP:%HTTPPORT
|
|
Accept: */*
|
|
Content-Length: 3
|
|
Content-Type: application/x-www-form-urlencoded
|
|
|
|
mooGET /blah/moo.html&testcase=/10110002 HTTP/1.1
|
|
User-Agent: curl/7.10 (i686-pc-linux-gnu) libcurl/7.10 OpenSSL/0.9.6c ipv6 zlib/1.1.3
|
|
Host: %HOSTIP:%HTTPPORT
|
|
Accept: */*
|
|
|
|
</protocol>
|
|
</verify>
|
|
</testcase>
|