265b14d6b3
Warning: this will make existing curl command lines that use metalink to stop working. Reasons for removal: 1. We've found several security problems and issues involving the metalink support in curl. The issues are not detailed here. When working on those, it become apparent to the team that several of the problems are due to the system design, metalink library API and what the metalink RFC says. They are very hard to fix on the curl side only. 2. The metalink usage with curl was only very briefly documented and was not following the "normal" curl usage pattern in several ways, making it surprising and non-intuitive which could lead to further security issues. 3. The metalink library was last updated 6 years ago and wasn't so active the years before that either. An unmaintained library means there's a security problem waiting to happen. This is probably reason enough. 4. Metalink requires an XML parsing library, which is complex code (even the smaller alternatives) and to this day often gets security updates. 5. Metalink is not a widely used curl feature. In the 2020 curl user survey, only 1.4% of the responders said that they'd are using it. In 2021 that number was 1.2%. Searching the web also show very few traces of it being used, even with other tools. 6. The torrent format and associated technology clearly won for downloading large files from multiple sources in parallel. Cloes #7176 |
||
---|---|---|
.. | ||
.gitignore | ||
CMakeLists.txt | ||
curlcheck.h | ||
Makefile.am | ||
Makefile.inc | ||
README.md | ||
unit1300.c | ||
unit1301.c | ||
unit1302.c | ||
unit1303.c | ||
unit1304.c | ||
unit1305.c | ||
unit1307.c | ||
unit1308.c | ||
unit1309.c | ||
unit1323.c | ||
unit1330.c | ||
unit1394.c | ||
unit1395.c | ||
unit1396.c | ||
unit1397.c | ||
unit1398.c | ||
unit1399.c | ||
unit1600.c | ||
unit1601.c | ||
unit1602.c | ||
unit1603.c | ||
unit1604.c | ||
unit1605.c | ||
unit1606.c | ||
unit1607.c | ||
unit1608.c | ||
unit1609.c | ||
unit1610.c | ||
unit1611.c | ||
unit1612.c | ||
unit1620.c | ||
unit1621.c | ||
unit1650.c | ||
unit1651.c | ||
unit1652.c | ||
unit1653.c | ||
unit1654.c | ||
unit1655.c | ||
unit1660.c | ||
unit1661.c |
Unit tests
The goal is to add tests for all functions in libcurl. If functions are too big and complicated, we should split them into smaller and testable ones.
Build Unit Tests
./configure --enable-debug
is required for the unit tests to build. To
enable unit tests, there will be a separate static libcurl built that will be
used exclusively for linking unit test programs. Just build everything as
normal, and then you can run the unit test cases as well.
Run Unit Tests
Unit tests are run as part of the regular test suite. If you have built
everything to run unit tests, to can do 'make test' at the root level. Or you
can cd tests
and make
and then invoke individual unit tests with
./runtests.pl NNNN
where NNNN
is the specific test number.
Debug Unit Tests
If a specific test fails you will get told. The test case then has output left
in the log/ subdirectory, but most importantly you can re-run the test again
using gdb by doing ./runtests.pl -g NNNN
. That is, add a -g
to make it
start up gdb and run the same case using that.
Write Unit Tests
We put tests that focus on an area or a specific function into a single C source file. The source file should be named 'unitNNNN.c' where NNNN is a previously unused number.
Add your test to tests/unit/Makefile.inc
(if it is a unit test). Add your
test data file name to tests/data/Makefile.inc
You also need a separate file called tests/data/testNNNN
(using the same
number) that describes your test case. See the test1300 file for inspiration
and the tests/FILEFORMAT.md
documentation.
For the actual C file, here's a very simple example:
#include "curlcheck.h"
#include "a libcurl header.h" /* from the lib dir */
static CURLcode unit_setup( void )
{
/* whatever you want done first */
return CURLE_OK;
}
static void unit_stop( void )
{
/* done before shutting down and exiting */
}
UNITTEST_START
/* here you start doing things and checking that the results are good */
fail_unless( size == 0 , "initial size should be zero" );
fail_if( head == NULL , "head should not be initiated to NULL" );
/* you end the test code like this: */
UNITTEST_STOP