mirror of
https://github.com/moparisthebest/curl
synced 2024-12-25 09:38:54 -05:00
0a04dc4d5d
This test does A LOT of *wakeup() calls and then calls curl_multi_poll() twice. The first *poll() is then expected to return early and the second not - as the first is supposed to drain the socketpair pipe. It turns out however that when given "excessive" amounts of writes to the pipe, some operating systems (the Solaris based are known) will return EAGAIN before the pipe is drained, which in our test case causes the second *poll() call to also abort early. This change attempts to avoid the OS-specific behaviors in the test by reducing the amount of wakeup calls from 1234567 to 10. Reported-by: Andy Fiddaman Fixes #5037 Closes #5058
143 lines
3.9 KiB
C
143 lines
3.9 KiB
C
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) 1998 - 2020, Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.haxx.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
***************************************************************************/
|
|
#include "test.h"
|
|
|
|
#include "testutil.h"
|
|
#include "warnless.h"
|
|
#include "memdebug.h"
|
|
|
|
#define TEST_HANG_TIMEOUT 60 * 1000
|
|
#define WAKEUP_NUM 10
|
|
|
|
int test(char *URL)
|
|
{
|
|
CURLM *multi = NULL;
|
|
int numfds;
|
|
int i;
|
|
int res = 0;
|
|
struct timeval time_before_wait, time_after_wait;
|
|
|
|
(void)URL;
|
|
|
|
start_test_timing();
|
|
|
|
global_init(CURL_GLOBAL_ALL);
|
|
|
|
multi_init(multi);
|
|
|
|
/* no wakeup */
|
|
|
|
time_before_wait = tutil_tvnow();
|
|
multi_poll(multi, NULL, 0, 1000, &numfds);
|
|
time_after_wait = tutil_tvnow();
|
|
|
|
if(tutil_tvdiff(time_after_wait, time_before_wait) < 500) {
|
|
fprintf(stderr, "%s:%d curl_multi_poll returned too early\n",
|
|
__FILE__, __LINE__);
|
|
res = TEST_ERR_MAJOR_BAD;
|
|
goto test_cleanup;
|
|
}
|
|
|
|
abort_on_test_timeout();
|
|
|
|
/* try a single wakeup */
|
|
|
|
multi_wakeup(multi);
|
|
|
|
time_before_wait = tutil_tvnow();
|
|
multi_poll(multi, NULL, 0, 1000, &numfds);
|
|
time_after_wait = tutil_tvnow();
|
|
|
|
if(tutil_tvdiff(time_after_wait, time_before_wait) > 500) {
|
|
fprintf(stderr, "%s:%d curl_multi_poll returned too late\n",
|
|
__FILE__, __LINE__);
|
|
res = TEST_ERR_MAJOR_BAD;
|
|
goto test_cleanup;
|
|
}
|
|
|
|
abort_on_test_timeout();
|
|
|
|
/* previous wakeup should not wake up this */
|
|
|
|
time_before_wait = tutil_tvnow();
|
|
multi_poll(multi, NULL, 0, 1000, &numfds);
|
|
time_after_wait = tutil_tvnow();
|
|
|
|
if(tutil_tvdiff(time_after_wait, time_before_wait) < 500) {
|
|
fprintf(stderr, "%s:%d curl_multi_poll returned too early\n",
|
|
__FILE__, __LINE__);
|
|
res = TEST_ERR_MAJOR_BAD;
|
|
goto test_cleanup;
|
|
}
|
|
|
|
abort_on_test_timeout();
|
|
|
|
/* try lots of wakeup */
|
|
|
|
for(i = 0; i < WAKEUP_NUM; ++i)
|
|
multi_wakeup(multi);
|
|
|
|
time_before_wait = tutil_tvnow();
|
|
multi_poll(multi, NULL, 0, 1000, &numfds);
|
|
time_after_wait = tutil_tvnow();
|
|
|
|
if(tutil_tvdiff(time_after_wait, time_before_wait) > 500) {
|
|
fprintf(stderr, "%s:%d curl_multi_poll returned too late\n",
|
|
__FILE__, __LINE__);
|
|
res = TEST_ERR_MAJOR_BAD;
|
|
goto test_cleanup;
|
|
}
|
|
|
|
abort_on_test_timeout();
|
|
|
|
#if !defined(WIN32) && !defined(_WIN32) && !defined(__WIN32__) \
|
|
&& !defined(__CYGWIN__)
|
|
/* Even lots of previous wakeups should not wake up this.
|
|
|
|
On Windows (particularly when using MinGW), the socketpair
|
|
used for curl_multi_wakeup() is really asynchronous,
|
|
meaning when it's called a lot, it can take some time
|
|
before all of the data can be read. Sometimes it can wake
|
|
up more than one curl_multi_poll() call. */
|
|
|
|
time_before_wait = tutil_tvnow();
|
|
multi_poll(multi, NULL, 0, 1000, &numfds);
|
|
time_after_wait = tutil_tvnow();
|
|
|
|
if(tutil_tvdiff(time_after_wait, time_before_wait) < 500) {
|
|
fprintf(stderr, "%s:%d curl_multi_poll returned too early\n",
|
|
__FILE__, __LINE__);
|
|
res = TEST_ERR_MAJOR_BAD;
|
|
goto test_cleanup;
|
|
}
|
|
|
|
abort_on_test_timeout();
|
|
#endif
|
|
|
|
test_cleanup:
|
|
|
|
curl_multi_cleanup(multi);
|
|
curl_global_cleanup();
|
|
|
|
return res;
|
|
}
|