mirror of
https://github.com/moparisthebest/curl
synced 2024-11-04 08:35:05 -05:00
365c5ba395
When doing multi-part formposts, libcurl used a pseudo-random value that was seeded with time(). This turns out to be bad for users who formpost data that is provided with users who then can guess how the boundary string will look like and then they can forge a different formpost part and trick the receiver. My advice to such implementors is (still even after this change) to not rely on the boundary strings being cryptographically strong. Fix your code and logic to not depend on them that much! I moved the Curl_rand() function into the sslgen.c source file now to be able to take advantage of the SSL library's random function if it provides one. If not, try to use the RANDOM_FILE for seeding and as a last resort keep the old logic, just modified to also add microseconds which makes it harder to properly guess the exact seed. The formboundary() function in formdata.c is now using 64 bit entropy for the boundary and therefore the string of dashes was reduced by 4 letters and there are 16 hex digits following it. The total length is thus still the same. Bug: http://curl.haxx.se/bug/view.cgi?id=1251 Reported-by: "Floris"
100 lines
3.8 KiB
C
100 lines
3.8 KiB
C
#ifndef HEADER_CURL_SSLUSE_H
|
|
#define HEADER_CURL_SSLUSE_H
|
|
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) 1998 - 2013, Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at http://curl.haxx.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
***************************************************************************/
|
|
|
|
#include "curl_setup.h"
|
|
|
|
#ifdef USE_SSLEAY
|
|
/*
|
|
* This header should only be needed to get included by sslgen.c and ssluse.c
|
|
*/
|
|
|
|
#include "urldata.h"
|
|
|
|
CURLcode Curl_ossl_connect(struct connectdata *conn, int sockindex);
|
|
CURLcode Curl_ossl_connect_nonblocking(struct connectdata *conn,
|
|
int sockindex,
|
|
bool *done);
|
|
|
|
/* close a SSL connection */
|
|
void Curl_ossl_close(struct connectdata *conn, int sockindex);
|
|
|
|
/* tell OpenSSL to close down all open information regarding connections (and
|
|
thus session ID caching etc) */
|
|
int Curl_ossl_close_all(struct SessionHandle *data);
|
|
|
|
/* Sets an OpenSSL engine */
|
|
CURLcode Curl_ossl_set_engine(struct SessionHandle *data, const char *engine);
|
|
|
|
/* function provided for the generic SSL-layer, called when a session id
|
|
should be freed */
|
|
void Curl_ossl_session_free(void *ptr);
|
|
|
|
/* Sets engine as default for all SSL operations */
|
|
CURLcode Curl_ossl_set_engine_default(struct SessionHandle *data);
|
|
|
|
/* Build list of OpenSSL engines */
|
|
struct curl_slist *Curl_ossl_engines_list(struct SessionHandle *data);
|
|
|
|
int Curl_ossl_init(void);
|
|
void Curl_ossl_cleanup(void);
|
|
|
|
size_t Curl_ossl_version(char *buffer, size_t size);
|
|
int Curl_ossl_check_cxn(struct connectdata *cxn);
|
|
int Curl_ossl_seed(struct SessionHandle *data);
|
|
|
|
int Curl_ossl_shutdown(struct connectdata *conn, int sockindex);
|
|
bool Curl_ossl_data_pending(const struct connectdata *conn,
|
|
int connindex);
|
|
void Curl_ossl_random(struct SessionHandle *data, unsigned char *entropy,
|
|
size_t length);
|
|
void Curl_ossl_md5sum(unsigned char *tmp, /* input */
|
|
size_t tmplen,
|
|
unsigned char *md5sum /* output */,
|
|
size_t unused);
|
|
|
|
/* this backend provides these functions: */
|
|
#define have_curlssl_random 1
|
|
#define have_curlssl_md5sum 1
|
|
|
|
/* API setup for OpenSSL */
|
|
#define curlssl_init Curl_ossl_init
|
|
#define curlssl_cleanup Curl_ossl_cleanup
|
|
#define curlssl_connect Curl_ossl_connect
|
|
#define curlssl_connect_nonblocking Curl_ossl_connect_nonblocking
|
|
#define curlssl_session_free(x) Curl_ossl_session_free(x)
|
|
#define curlssl_close_all Curl_ossl_close_all
|
|
#define curlssl_close Curl_ossl_close
|
|
#define curlssl_shutdown(x,y) Curl_ossl_shutdown(x,y)
|
|
#define curlssl_set_engine(x,y) Curl_ossl_set_engine(x,y)
|
|
#define curlssl_set_engine_default(x) Curl_ossl_set_engine_default(x)
|
|
#define curlssl_engines_list(x) Curl_ossl_engines_list(x)
|
|
#define curlssl_version Curl_ossl_version
|
|
#define curlssl_check_cxn Curl_ossl_check_cxn
|
|
#define curlssl_data_pending(x,y) Curl_ossl_data_pending(x,y)
|
|
#define curlssl_random(x,y,z) Curl_ossl_random(x,y,z)
|
|
#define curlssl_md5sum(a,b,c,d) Curl_ossl_md5sum(a,b,c,d)
|
|
|
|
#endif /* USE_SSLEAY */
|
|
#endif /* HEADER_CURL_SSLUSE_H */
|