mirror of
https://github.com/moparisthebest/curl
synced 2024-11-15 14:05:03 -05:00
9c1806ae46
- Disable warning C4127 "conditional expression is constant" globally in curl_setup.h for when building with Microsoft's compiler. This mainly affects building with the Visual Studio project files found in the projects dir. Prior to this change the cmake and winbuild build systems already disabled 4127 globally for when building with Microsoft's compiler. Also, 4127 was already disabled for all build systems in the limited circumstance of the WHILE_FALSE macro which disabled the warning specifically for while(0). This commit removes the WHILE_FALSE macro and all other cruft in favor of disabling globally in curl_setup. Background: We have various macros that cause 0 or 1 to be evaluated, which would cause warning C4127 in Visual Studio. For example this causes it: #define Curl_resolver_asynch() 1 Full behavior is not clearly defined and inconsistent across versions. However it is documented that since VS 2015 Update 3 Microsoft has addressed this somewhat but not entirely, not warning on while(true) for example. Prior to this change some C4127 warnings occurred when I built with Visual Studio using the generated projects in the projects dir. Closes https://github.com/curl/curl/pull/4658 |
||
---|---|---|
.. | ||
.gitignore | ||
CMakeLists.txt | ||
curlcheck.h | ||
Makefile.am | ||
Makefile.inc | ||
README | ||
unit1300.c | ||
unit1301.c | ||
unit1302.c | ||
unit1303.c | ||
unit1304.c | ||
unit1305.c | ||
unit1307.c | ||
unit1308.c | ||
unit1309.c | ||
unit1323.c | ||
unit1330.c | ||
unit1394.c | ||
unit1395.c | ||
unit1396.c | ||
unit1397.c | ||
unit1398.c | ||
unit1399.c | ||
unit1600.c | ||
unit1601.c | ||
unit1602.c | ||
unit1603.c | ||
unit1604.c | ||
unit1605.c | ||
unit1606.c | ||
unit1607.c | ||
unit1608.c | ||
unit1609.c | ||
unit1620.c | ||
unit1621.c | ||
unit1650.c | ||
unit1651.c | ||
unit1652.c | ||
unit1653.c | ||
unit1654.c | ||
unit1655.c |
Unit tests ========== The goal is to add tests for *ALL* functions in libcurl. If functions are too big and complicated, we should split them into smaller and testable ones. Build Unit Tests ================ './configure --enable-debug' is required for the unit tests to build. To enable unit tests, there will be a separate static libcurl built that will be used exclusively for linking unit test programs. Just build everything as normal, and then you can run the unit test cases as well. Run Unit Tests ============== Unit tests are run as part of the regular test suite. If you have built everything to run unit tests, to can do 'make test' at the root level. Or you can 'cd tests' and 'make' and then invoke individual unit tests with ./runtests.pl NNNN where NNNN is the specific test number. Debug Unit Tests ================ If a specific test fails you will get told. The test case then has output left in the log/ subdirectory, but most importantly you can re-run the test again using gdb by doing ./runtests.pl -g NNNN. That is, add a -g to make it start up gdb and run the same case using that. Write Unit Tests ================ We put tests that focus on an area or a specific function into a single C source file. The source file should be named 'unitNNNN.c' where NNNN is a number that starts with 1300 and you can pick the next free number. Add your test to tests/unit/Makefile.inc (if it is a unit test). Add your test data to tests/data/Makefile.inc You also need a separate file called tests/data/testNNNN (using the same number) that describes your test case. See the test1300 file for inspiration and the tests/FILEFORMAT documentation. For the actual C file, here's a very simple example: ----------------------- start ------------------------------- #include "curlcheck.h" #include "a libcurl header.h" /* from the lib dir */ static CURLcode unit_setup( void ) { /* whatever you want done first */ return CURLE_OK; } static void unit_stop( void ) { /* done before shutting down and exiting */ } UNITTEST_START /* here you start doing things and checking that the results are good */ fail_unless( size == 0 , "initial size should be zero" ); fail_if( head == NULL , "head should not be initiated to NULL" ); /* you end the test code like this: */ UNITTEST_STOP ----------------------- end -------------------------------