mirror of
https://github.com/moparisthebest/curl
synced 2024-08-13 17:03:50 -04:00
265b14d6b3
Warning: this will make existing curl command lines that use metalink to stop working. Reasons for removal: 1. We've found several security problems and issues involving the metalink support in curl. The issues are not detailed here. When working on those, it become apparent to the team that several of the problems are due to the system design, metalink library API and what the metalink RFC says. They are very hard to fix on the curl side only. 2. The metalink usage with curl was only very briefly documented and was not following the "normal" curl usage pattern in several ways, making it surprising and non-intuitive which could lead to further security issues. 3. The metalink library was last updated 6 years ago and wasn't so active the years before that either. An unmaintained library means there's a security problem waiting to happen. This is probably reason enough. 4. Metalink requires an XML parsing library, which is complex code (even the smaller alternatives) and to this day often gets security updates. 5. Metalink is not a widely used curl feature. In the 2020 curl user survey, only 1.4% of the responders said that they'd are using it. In 2021 that number was 1.2%. Searching the web also show very few traces of it being used, even with other tools. 6. The torrent format and associated technology clearly won for downloading large files from multiple sources in parallel. Cloes #7176
79 lines
2.6 KiB
C
79 lines
2.6 KiB
C
#ifndef HEADER_CURL_TOOL_OPERATE_H
|
|
#define HEADER_CURL_TOOL_OPERATE_H
|
|
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) 1998 - 2021, Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
***************************************************************************/
|
|
#include "tool_setup.h"
|
|
#include "tool_cb_hdr.h"
|
|
#include "tool_cb_prg.h"
|
|
#include "tool_sdecls.h"
|
|
|
|
struct per_transfer {
|
|
/* double linked */
|
|
struct per_transfer *next;
|
|
struct per_transfer *prev;
|
|
struct OperationConfig *config; /* for this transfer */
|
|
CURL *curl;
|
|
long retry_numretries;
|
|
long retry_sleep_default;
|
|
long retry_sleep;
|
|
struct timeval retrystart;
|
|
char *this_url;
|
|
unsigned int urlnum; /* the index of the given URL */
|
|
char *outfile;
|
|
bool infdopen; /* TRUE if infd needs closing */
|
|
int infd;
|
|
bool noprogress;
|
|
struct ProgressData progressbar;
|
|
struct OutStruct outs;
|
|
struct OutStruct heads;
|
|
struct OutStruct etag_save;
|
|
struct InStruct input;
|
|
struct HdrCbData hdrcbdata;
|
|
long num_headers;
|
|
bool was_last_header_empty;
|
|
char errorbuffer[CURL_ERROR_SIZE];
|
|
|
|
bool added; /* set TRUE when added to the multi handle */
|
|
time_t startat; /* when doing parallel transfers, this is a retry transfer
|
|
that has been set to sleep until this time before it
|
|
should get started (again) */
|
|
|
|
/* for parallel progress bar */
|
|
curl_off_t dltotal;
|
|
curl_off_t dlnow;
|
|
curl_off_t ultotal;
|
|
curl_off_t ulnow;
|
|
bool dltotal_added; /* if the total has been added from this */
|
|
bool ultotal_added;
|
|
|
|
/* NULL or malloced */
|
|
char *separator_err;
|
|
char *separator;
|
|
char *uploadfile;
|
|
};
|
|
|
|
CURLcode operate(struct GlobalConfig *config, int argc, argv_item_t argv[]);
|
|
|
|
extern struct per_transfer *transfers; /* first node */
|
|
|
|
#endif /* HEADER_CURL_TOOL_OPERATE_H */
|