1
0
mirror of https://github.com/moparisthebest/curl synced 2025-01-11 05:58:01 -05:00
Go to file
Johannes Schindelin 5450428491 schannel: add "best effort" revocation check option
- Implement new option CURLSSLOPT_REVOKE_BEST_EFFORT and
  --ssl-revoke-best-effort to allow a "best effort" revocation check.

A best effort revocation check ignores errors that the revocation check
was unable to take place. The reasoning is described in detail below and
discussed further in the PR.

---

When running e.g. with Fiddler, the schannel backend fails with an
unhelpful error message:

	Unknown error (0x80092012) - The revocation function was unable
	to check revocation for the certificate.

Sadly, many enterprise users who are stuck behind MITM proxies suffer
the very same problem.

This has been discussed in plenty of issues:
https://github.com/curl/curl/issues/3727,
https://github.com/curl/curl/issues/264, for example.

In the latter, a Microsoft Edge developer even made the case that the
common behavior is to ignore issues when a certificate has no recorded
distribution point for revocation lists, or when the server is offline.
This is also known as "best effort" strategy and addresses the Fiddler
issue.

Unfortunately, this strategy was not chosen as the default for schannel
(and is therefore a backend-specific behavior: OpenSSL seems to happily
ignore the offline servers and missing distribution points).

To maintain backward-compatibility, we therefore add a new flag
(`CURLSSLOPT_REVOKE_BEST_EFFORT`) and a new option
(`--ssl-revoke-best-effort`) to select the new behavior.

Due to the many related issues Git for Windows and GitHub Desktop, the
plan is to make this behavior the default in these software packages.

The test 2070 was added to verify this behavior, adapted from 310.

Based-on-work-by: georgeok <giorgos.n.oikonomou@gmail.com>
Co-authored-by: Markus Olsson <j.markus.olsson@gmail.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Closes https://github.com/curl/curl/pull/4981
2020-03-18 03:23:39 -04:00
.github CIfuzz: switch off 'dry_run' mode 2020-02-28 16:50:43 +01:00
CMake cmake: add support for building with wolfSSL 2020-03-16 22:56:50 +01:00
docs schannel: add "best effort" revocation check option 2020-03-18 03:23:39 -04:00
include schannel: add "best effort" revocation check option 2020-03-18 03:23:39 -04:00
lib schannel: add "best effort" revocation check option 2020-03-18 03:23:39 -04:00
m4 configure: convert -I to -isystem as a last step 2020-03-11 08:51:25 +01:00
packages schannel: add "best effort" revocation check option 2020-03-18 03:23:39 -04:00
plan9 plan9: fix installation instructions 2019-08-29 19:24:59 +02:00
projects checksrc.bat: Fix not being able to run script from the main curl directory 2020-02-07 21:51:36 +00:00
scripts CI: stop ignoring 323, it is disabled 2020-03-17 09:55:35 +01:00
src schannel: add "best effort" revocation check option 2020-03-18 03:23:39 -04:00
tests schannel: add "best effort" revocation check option 2020-03-18 03:23:39 -04:00
winbuild winbuild: Document CURL_STATICLIB requirement for static libcurl 2019-12-15 17:31:23 -05:00
.azure-pipelines.yml CI: stop ignoring 323, it is disabled 2020-03-17 09:55:35 +01:00
.cirrus.yml CI: stop ignoring 323, it is disabled 2020-03-17 09:55:35 +01:00
.dir-locals.el
.gitattributes .gitattributes: make tabs in indentation a visible error 2018-12-06 20:21:17 +01:00
.gitignore scripts/completion.pl: also generate fish completion file 2019-03-02 11:31:18 +01:00
.lgtm.yml CI: remove duplicate configure flag for LGTM.com 2019-08-31 11:40:09 +02:00
.mailmap RELEASE-NOTES: synced 2020-01-27 09:44:33 +01:00
.travis.yml tests: remove python_dependencies for smbserver from our tree 2020-03-15 10:01:38 +01:00
acinclude.m4 polarssl: remove more references and mentions 2020-03-05 07:57:45 +01:00
appveyor.yml seek: fix fallback for missing ftruncate on Windows 2020-03-07 10:59:27 +01:00
buildconf includes: remove curl/curlbuild.h and curl/curlrules.h 2017-06-14 11:07:33 +02:00
buildconf.bat copyrights: update all copyright notices to 2019 on files changed this year 2019-11-02 23:15:56 +01:00
CHANGES CHANGES: spell fix, use correct path to script 2017-02-07 08:22:37 +01:00
CMakeLists.txt cmake: add support for building with wolfSSL 2020-03-16 22:56:50 +01:00
configure.ac configure: convert -I to -isystem as a last step 2020-03-11 08:51:25 +01:00
COPYING COPYING: it's 2020! 2020-01-03 15:12:46 +01:00
curl-config.in curl-config.in: remove dependency on bc 2018-10-26 00:06:19 +02:00
GIT-INFO CHANGES.0: removed 2017-02-07 08:20:10 +01:00
libcurl.pc.in URLs: change all http:// URLs to https:// 2016-02-03 00:19:02 +01:00
MacOSX-Framework includes: remove curl/curlbuild.h and curl/curlrules.h 2017-06-14 11:07:33 +02:00
Makefile.am cmake: add support for building with wolfSSL 2020-03-16 22:56:50 +01:00
Makefile.dist build: remove the Borland specific makefiles 2018-06-02 11:23:40 +02:00
maketgz maketgz: delete .bak files, fix indentation 2018-06-15 23:28:34 +00:00
README README: mention that the docs is in docs/ 2020-01-27 13:06:45 +01:00
README.md README.md: add Azure DevOps Pipelines build status badge 2020-03-03 17:11:26 +01:00
RELEASE-NOTES RELEASE-NOTES: synced 2020-03-11 11:07:53 +01:00
SECURITY.md SECURITY.md: created 2019-06-10 10:16:02 +02:00

curl logo

CII Best Practices Coverity passed Travis-CI Build Status AppVeyor Build Status Azure DevOps Build Status Cirrus Build Status Backers on Open Collective Sponsors on Open Collective Language Grade: C/C++ Codacy Badge Fuzzing Status

Curl is a command-line tool for transferring data specified with URL syntax. Find out how to use curl by reading the curl.1 man page or the MANUAL document. Find out how to install Curl by reading the INSTALL document.

libcurl is the library curl is using to do its job. It is readily available to be used by your software. Read the libcurl.3 man page to learn how!

You can find answers to the most frequent questions we get in the FAQ document.

Study the COPYING file for distribution terms and similar. If you distribute curl binaries or other binaries that involve libcurl, you might enjoy the LICENSE-MIXING document.

Contact

If you have problems, questions, ideas or suggestions, please contact us by posting to a suitable mailing list.

All contributors to the project are listed in the THANKS document.

Website

Visit the curl web site for the latest news and downloads.

Git

To download the very latest source from the Git server do this:

git clone https://github.com/curl/curl.git

(you'll get a directory named curl created, filled with the source code)

Security problems

Report suspected security problems via our HackerOne page and not in public!

Notice

Curl contains pieces of source code that is Copyright (c) 1998, 1999 Kungliga Tekniska Högskolan. This notice is included here to comply with the distribution terms.

Backers

Thank you to all our backers! 🙏 [Become a backer]

Sponsors

Support this project by becoming a sponsor. Your logo will show up here with a link to your website. [Become a sponsor]