mirror of
https://github.com/moparisthebest/curl
synced 2024-11-05 17:15:04 -05:00
fc9312f717
- remove check for unsupported old CMake versions
- do not link to c-ares library twice
- modernize custom Find modules
- FindLibSSH2:
- pass version to FPHSA to show it in the output
- use LIBSSH2_VERSION define to extract the version number in
one shot. This variable exists in the header for 10 years.
- remove unneeded code
- FindNGHTTP2.cmake:
- drop needless FPHSA argument
- mark found variables as advanced
- FindNSS.cmake:
- show version number
- FindCARES.cmake:
- drop default paths
- use FPHSA instead of checking things by hand
- remove needless explict variable dereference
- simplify count_true()
- allow all policies up to version 3.16 to be set to NEW
- do not rerun check for -Wstrict-aliasing=3 every time
In contrast to every other compiler flag this has a = in it, which CMake
can't have in a variable name.
- only read the interesting strings from curlver.h
Reviewed-by: Peter Wu
Closes https://github.com/curl/curl/pull/4975
56 lines
2.3 KiB
CMake
56 lines
2.3 KiB
CMake
include(CheckCSourceCompiles)
|
|
|
|
option(CURL_HIDDEN_SYMBOLS "Set to ON to hide libcurl internal symbols (=hide all symbols that aren't officially external)." ON)
|
|
mark_as_advanced(CURL_HIDDEN_SYMBOLS)
|
|
|
|
if(CURL_HIDDEN_SYMBOLS)
|
|
set(SUPPORTS_SYMBOL_HIDING FALSE)
|
|
|
|
if(CMAKE_C_COMPILER_ID MATCHES "Clang")
|
|
set(SUPPORTS_SYMBOL_HIDING TRUE)
|
|
set(_SYMBOL_EXTERN "__attribute__ ((__visibility__ (\"default\")))")
|
|
set(_CFLAG_SYMBOLS_HIDE "-fvisibility=hidden")
|
|
elseif(CMAKE_COMPILER_IS_GNUCC)
|
|
if(NOT CMAKE_C_COMPILER_VERSION VERSION_LESS 3.4)
|
|
# note: this is considered buggy prior to 4.0 but the autotools don't care, so let's ignore that fact
|
|
set(SUPPORTS_SYMBOL_HIDING TRUE)
|
|
set(_SYMBOL_EXTERN "__attribute__ ((__visibility__ (\"default\")))")
|
|
set(_CFLAG_SYMBOLS_HIDE "-fvisibility=hidden")
|
|
endif()
|
|
elseif(CMAKE_C_COMPILER_ID MATCHES "SunPro" AND NOT CMAKE_C_COMPILER_VERSION VERSION_LESS 8.0)
|
|
set(SUPPORTS_SYMBOL_HIDING TRUE)
|
|
set(_SYMBOL_EXTERN "__global")
|
|
set(_CFLAG_SYMBOLS_HIDE "-xldscope=hidden")
|
|
elseif(CMAKE_C_COMPILER_ID MATCHES "Intel" AND NOT CMAKE_C_COMPILER_VERSION VERSION_LESS 9.0)
|
|
# note: this should probably just check for version 9.1.045 but I'm not 100% sure
|
|
# so let's do it the same way autotools do.
|
|
set(SUPPORTS_SYMBOL_HIDING TRUE)
|
|
set(_SYMBOL_EXTERN "__attribute__ ((__visibility__ (\"default\")))")
|
|
set(_CFLAG_SYMBOLS_HIDE "-fvisibility=hidden")
|
|
check_c_source_compiles("#include <stdio.h>
|
|
int main (void) { printf(\"icc fvisibility bug test\"); return 0; }" _no_bug)
|
|
if(NOT _no_bug)
|
|
set(SUPPORTS_SYMBOL_HIDING FALSE)
|
|
set(_SYMBOL_EXTERN "")
|
|
set(_CFLAG_SYMBOLS_HIDE "")
|
|
endif()
|
|
elseif(MSVC)
|
|
set(SUPPORTS_SYMBOL_HIDING TRUE)
|
|
endif()
|
|
|
|
set(HIDES_CURL_PRIVATE_SYMBOLS ${SUPPORTS_SYMBOL_HIDING})
|
|
elseif(MSVC)
|
|
if(NOT CMAKE_VERSION VERSION_LESS 3.7)
|
|
set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS TRUE) #present since 3.4.3 but broken
|
|
set(HIDES_CURL_PRIVATE_SYMBOLS FALSE)
|
|
else()
|
|
message(WARNING "Hiding private symbols regardless CURL_HIDDEN_SYMBOLS being disabled.")
|
|
set(HIDES_CURL_PRIVATE_SYMBOLS TRUE)
|
|
endif()
|
|
else()
|
|
set(HIDES_CURL_PRIVATE_SYMBOLS FALSE)
|
|
endif()
|
|
|
|
set(CURL_CFLAG_SYMBOLS_HIDE ${_CFLAG_SYMBOLS_HIDE})
|
|
set(CURL_EXTERN_SYMBOL ${_SYMBOL_EXTERN})
|