mirror of
https://github.com/moparisthebest/curl
synced 2024-11-14 13:35:03 -05:00
90d9e9460e
Make sure to run curl_global_cleanup() when shutting down the test
suite to release any resources allocated in the SSL setup. This is
clearly visible when running tests with PolarSSL where the thread
lock calloc() memory which isn't released when not running cleanup.
Below is an excerpt from the autobuild logs:
==12368== 96 bytes in 1 blocks are possibly lost in loss record 1 of 2
==12368== at 0x4837B65: calloc (vg_replace_malloc.c:752)
==12368== by 0x11A76E: curl_dbg_calloc (memdebug.c:205)
==12368== by 0x145CDF: Curl_polarsslthreadlock_thread_setup
(polarssl_threadlock.c:54)
==12368== by 0x145B37: Curl_polarssl_init (polarssl.c:865)
==12368== by 0x14129D: Curl_ssl_init (vtls.c:171)
==12368== by 0x118B4C: global_init (easy.c:158)
==12368== by 0x118BF5: curl_global_init (easy.c:221)
==12368== by 0x118D0B: curl_easy_init (easy.c:299)
==12368== by 0x114E96: test (lib1906.c:32)
==12368== by 0x115495: main (first.c:174)
Closes #3783
Reviewed-by: Marcel Raad <Marcel.Raad@teamviewer.com>
Reviewed-by: Daniel Stenberg <daniel@haxx.se>
75 lines
2.0 KiB
C
75 lines
2.0 KiB
C
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) 1998 - 2019, Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.haxx.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
***************************************************************************/
|
|
#include "curlcheck.h"
|
|
|
|
#include "hostip.h"
|
|
|
|
CURLcode Curl_shuffle_addr(struct Curl_easy *data,
|
|
Curl_addrinfo **addr);
|
|
|
|
#define NUM_ADDRS 8
|
|
static struct Curl_addrinfo addrs[NUM_ADDRS];
|
|
|
|
static CURLcode unit_setup(void)
|
|
{
|
|
int i;
|
|
for(i = 0; i < NUM_ADDRS - 1; i++) {
|
|
addrs[i].ai_next = &addrs[i + 1];
|
|
}
|
|
|
|
return CURLE_OK;
|
|
}
|
|
|
|
static void unit_stop(void)
|
|
{
|
|
|
|
}
|
|
|
|
UNITTEST_START
|
|
{
|
|
int i;
|
|
CURLcode code;
|
|
struct Curl_addrinfo* addrhead = addrs;
|
|
|
|
struct Curl_easy *easy = curl_easy_init();
|
|
abort_unless(easy, "out of memory");
|
|
|
|
code = curl_easy_setopt(easy, CURLOPT_DNS_SHUFFLE_ADDRESSES, 1L);
|
|
abort_unless(code == CURLE_OK, "curl_easy_setopt failed");
|
|
|
|
/* Shuffle repeatedly and make sure that the list changes */
|
|
for(i = 0; i < 10; i++) {
|
|
if(CURLE_OK != Curl_shuffle_addr(easy, &addrhead))
|
|
break;
|
|
if(addrhead != addrs)
|
|
break;
|
|
}
|
|
|
|
curl_easy_cleanup(easy);
|
|
curl_global_cleanup();
|
|
|
|
abort_unless(addrhead != addrs, "addresses are not being reordered");
|
|
|
|
return 0;
|
|
}
|
|
UNITTEST_STOP
|