2309b4e330
remove the CVSish $Id$ lines
2010-03-24 11:02:54 +01:00
19ca0c0fbe
- Improved Curl_read() to not ignore the error returned from Curl_ssl_recv().
2010-03-19 15:43:11 +00:00
7aef172a34
fix printf-style format strings
2010-02-04 19:44:31 +00:00
d1717e7c90
Fix compiler warning: conditional expression is constant
2010-02-02 16:25:07 +00:00
33ce0ec1f1
wrap long lines and do some indent policing
2010-01-22 23:21:39 +00:00
bc4582b68a
Chris Conroy brought support for RTSP transfers, and with it comes 8(!) new
...
libcurl options for controlling what to get and how to receive posssibly
interleaved RTP data. Initial commit.
2010-01-21 13:58:30 +00:00
352177090f
- Fabian Keil ran clang on the (lib)curl code, found a bunch of warnings and
...
contributed a range of patches to fix them.
2009-06-10 21:26:11 +00:00
3aa3d7e629
Internal cleanup: KEEP_WRITE and KEEP_READ are now called KEEP_SEND and
...
KEEP_RECV to better match the general terminology: receive and send is what we
do from the (remote) servers. We read and write from and to the local fs.
2009-05-11 07:53:38 +00:00
33a3753c3f
libcurl's memory.h renamed to curl_memory.h
2009-04-21 11:46:16 +00:00
bdec6f2b20
- Frank Hempel found out a bug and provided the fix:
...
curl_easy_duphandle did not necessarily duplicate the CURLOPT_COOKIEFILE
option. It only enabled the cookie engine in the destination handle if
data->cookies is not NULL (where data is the source handle). In case of a
newly initialized handle which just had the cookie support enabled by a
curl_easy_setopt(handle, CURL_COOKIEFILE, "")-call, handle->cookies was
still NULL because the setopt-call only appends the value to
data->change.cookielist, hence duplicating this handle would not have the
cookie engine switched on.
We also concluded that the slist-functionality would be suitable for being
put in its own module rather than simply hanging out in lib/sendf.c so I
created lib/slist.[ch] for them.
2009-03-09 12:21:46 +00:00
80ffd3581f
Created a CURLMIN macro to match CURLMAX
2009-01-07 19:39:35 +00:00
c76d939563
Christian Krause fixed a build failure when building with gss support
...
enabled and FTP disabled.
2008-11-16 12:42:53 +00:00
c331c73ec6
- Fixed a potential data loss in Curl_client_write() when the transfer is
...
paused.
2008-11-13 08:20:23 +00:00
484d549ece
Marked with TODO comments a number of problems in the Kerberos code detected
...
while investigating the issue in http://curl.haxx.se/mail/lib-2008-09/0262.html
I'm hesitant to fix them because I have no way of testing the result.
2008-11-02 05:01:39 +00:00
7fc4e8af0a
Changed some arrays of char* to arrays of char[] to reduce data size and
...
run-time relocations.
2008-10-22 05:46:29 +00:00
d61688923d
fix compiler warning: enumerated type mixed with another type
2008-09-30 12:50:52 +00:00
aff5408633
made Curl_read_plain() return an 'int' instead of CURLcode since it actually
...
returns -1 in EAGAIN cases and that's not valid CURLcode
2008-09-29 11:13:37 +00:00
391e8afd1f
- Made the SOCKS code use the new Curl_read_plain() function to fix the bug
...
Markus Moeller reported: http://curl.haxx.se/mail/archive-2008-09/0016.html
- recv() errors other than those equal to EAGAIN now cause proper
CURLE_RECV_ERROR to get returned. This made test case 160 fail so I've now
disabled it until we can figure out another way to exercise that logic.
2008-09-22 23:12:00 +00:00
59e378f48f
remove unnecessary typecasting of malloc()
2008-09-06 05:29:05 +00:00
3acd1146f9
Use realloc when paused in Curl_client_write
2008-09-05 17:21:54 +00:00
4c9768565e
- Introducing CURLOPT_CERTINFO and the corresponding CURLINFO_CERTINFO. By
...
enabling this feature with CURLOPT_CERTINFO for a request using SSL (HTTPS
or FTPS), libcurl will gather lots of server certificate info and that info
can then get extracted by a client after the request has completed with
curl_easy_getinfo()'s CURLINFO_CERTINFO option. Linus Nielsen Feltzing
helped me test and smoothen out this feature.
Unfortunately, this feature currently only works with libcurl built to use
OpenSSL.
This feature was sponsored by networking4all.com - thanks!
2008-09-05 14:29:21 +00:00
bb67388bbe
Made some variables const
2008-09-04 19:43:35 +00:00
422fd933f5
- Hans-Jurgen May pointed out that trying SCP or SFTP over a SOCKS proxy
...
crashed libcurl. This is now addressed by making sure we use "plain send"
internally when doing the socks handshake instead of the Curl_write()
function which is designed to use the "target" protocol. That's then SCP or
SFTP in this case. I also took the opportunity and cleaned up some ssh-
related #ifdefs in the code for readability.
2008-06-20 10:43:32 +00:00
e2b82b4325
- Make Curl_write and it's callees accept a const pointer, in preparation
...
of tetetest's patch for curl_easy_send()
2008-05-09 11:27:54 +00:00
53a549000c
- Based on initial work done by Gautam Kachroo to address a bug, we now keep
...
better control at the exact state of the connection's SSL status so that we
know exactly when it has completed the SSL negotiation or not so that there
won't be accidental re-uses of connections that are wrongly believed to be
in SSL-completed-negotiate state.
2008-02-20 09:56:26 +00:00
33d68653f0
this was modified this year so we bump the copyright year
2008-01-28 11:56:13 +00:00
ef0ed9b720
Dmitry Kurochkin removed the cancelled state for pipelining, as we agreed
...
that it is bad anyway. Starting now, removing a handle that is in used in a
pipeline will break the pipeline - it'll be set back up again but still...
2008-01-21 23:48:58 +00:00
de23b98522
Introducing curl_easy_pause() and new magic return codes for both the read
...
and the write callbacks that now can make a connection's reading and/or
writing get paused.
2008-01-08 14:52:05 +00:00
b0b40d9a00
Andrew Moise filed bug report #1847501
...
(http://curl.haxx.se/bug/view.cgi?id=1847501 ) and pointed out a memcpy()
that should be memmove() in the convert_lineends() function.
2007-12-09 22:31:53 +00:00
662bee7193
All static functions that were previously name Curl_* something no longer
...
use that prefix as we use that prefix only for library-wide internal global
symbols.
2007-12-08 22:50:55 +00:00
ad6e28073c
removed space after if and while before the parenthesis for better source code
...
consistency
2007-11-05 09:45:09 +00:00
0f77fe55b6
Reverted the const change--what was I thinking?
2007-10-29 20:57:03 +00:00
68ee002ad0
Made some pointers const
2007-10-29 18:32:20 +00:00
16b95fc773
Enabled a few more gcc warnings with --enable-debug. Renamed a few
...
variables to avoid shadowing global declarations.
2007-09-27 01:45:22 +00:00
5ecd56d964
Implemented only the parts of Patrick Monnerat's OS/400 patch that renamed
...
some few internal identifiers to avoid conflicts, which could be useful on
other platforms.
2007-07-23 18:51:22 +00:00
54967d2a3a
Thomas J. Moore provided a patch that introduces Kerberos5 support in
...
libcurl. This also makes the options change name to --krb (from --krb4) and
CURLOPT_KRBLEVEL (from CURLOPT_KRB4LEVEL) but the old names are still
2007-07-01 22:01:18 +00:00
3d513f7ab1
spell and language fix
2007-05-02 11:14:55 +00:00
bc1ae973da
Robert Iakobashvili made the 'master_buffer' get allocated first once it is
...
can/will be used as it then makes the common cases save 16KB of data for each
easy handle that isn't used for pipelining.
2007-04-24 10:18:06 +00:00
90ce18019c
reverted back to previous version => http://curl.haxx.se/mail/lib-2007-03/0258.html
2007-03-21 13:09:39 +00:00
fe10cb2ef5
avoid the use of variadic macros for greater portability
2007-03-21 08:17:13 +00:00
c514a2a89a
Removed inclusion of <sys/types.h> and <sys/stat.h> in .c-files
...
since they're already included through "setup.h".
2007-02-26 04:24:26 +00:00
a1d5983991
use macros ERRNO, SET_ERRNO(), SOCKERRNO and SET_SOCKERRNO() for errno handling
2007-02-16 18:19:35 +00:00
6a175b42db
Suppress warning "'nread' might be used uninitialized in this function".
2007-02-04 12:18:22 +00:00
abe90019d3
prefer using the (upcoming) non-blocking libssh2 API
2007-02-02 15:26:57 +00:00
cdbbb7d900
Compiler warning fix
2007-01-27 03:14:25 +00:00
7b704e173c
Supress "comparison between signed and unsigned" warning.
2007-01-17 15:15:21 +00:00
1886388791
restore previous addition to the amount of data that is returned
2007-01-16 21:28:45 +00:00
0fb5a65a58
- David McCreedy provided libcurl changes for doing HTTP communication on
...
non-ASCII platforms. It does add some complexity, most notably with more
#ifdefs, but I want to see this supported added and I can't see how we can
add it without the extra stuff added.
2007-01-14 14:57:51 +00:00
d8ff0336a5
- Matt Witherspoon fixed the flaw which made libcurl 7.16.0 always store
...
downloaded data in two buffers, just to be able to deal with a special HTTP
pipelining case. That is now only activated for pipelined transfers. In
Matt's case, it showed as a considerable performance difference,
2007-01-03 22:18:38 +00:00
5fd096da8d
Stefan Krause pointed out a compiler warning with a picky MSCV compiler when
...
passing a curl_off_t argument to the Curl_read_rewind() function which takes
an size_t argument. Curl_read_rewind() also had debug code left in it and it
was put in a different source file with no good reason when only used from
one single spot.
2006-12-05 21:40:14 +00:00
a634f64400
James Housley did lots of work and introduced SFTP downloads.
2006-11-24 22:14:39 +00:00
be0d17e812
cleaned up Curl_write() and the sub functions it uses for various protocols.
...
They all now return ssize_t to Curl_write().
Unfortunately, Curl_read() is in a sorrier state but it too would benefit from
a similar cleanup.
2006-11-11 21:34:43 +00:00
01926d66d7
add TODO note
2006-11-06 18:28:34 +00:00
2147284cad
James Housley brought support for SCP transfers
2006-11-02 21:56:40 +00:00
e1edd41e1b
Ravi Pratap provided a major update with pipelining fixes. We also no longer
...
re-use connections (for pipelining) before the name resolving is done.
2006-10-23 20:34:56 +00:00
3cd95eacdf
Compiler warning fix
2006-10-21 12:35:16 +00:00
5df4be1165
Check for USE_WINSOCK instead of WIN32 where the check was done
...
to verify winsock API availability.
2006-10-18 21:05:40 +00:00
ec956b0334
Explicit typecast for Curl_debug() size argument
2006-10-17 10:04:13 +00:00
5e0d9aea32
Support for FTP third party transfers is now dropped
2006-09-30 20:31:11 +00:00
733a184ce0
Compiler warning fix
2006-09-12 23:51:01 +00:00
b7eeb6e67f
Major overhaul introducing http pipelining support and shared connection
...
cache within the multi handle.
2006-09-07 21:49:20 +00:00
cfdcae4bc7
Based on a patch by Armel Asselin, the FTP code no longer re-issues the TYPE
...
command on subsequent requests on a re-used connection unless it has to.
2006-08-19 21:18:36 +00:00
58176d1484
Use platform's native types for recv() and send() arguments.
2006-07-12 05:19:00 +00:00
9bece2b313
additional renames of Curl_ourerrno => Curl_sockerrno
2006-05-05 10:24:27 +00:00
e85e30546c
Roland Blom filed bug report #1481217
...
(http://curl.haxx.se/bug/view.cgi?id=1481217 ), with follow-ups by Michele Bini
and David Byron. libcurl previously wrongly used GetLastError() on windows to
get error details after socket-related function calls, when it really should
use WSAGetLastError() instead.
When changing to this, the former function Curl_ourerrno() is now instead
called Curl_sockerrno() as it is necessary to only use it to get errno from
socket-related functions as otherwise it won't work as intended on Windows.
2006-05-04 22:39:47 +00:00
95152aec68
David McCreedy brought line end conversions when doing FTP ASCII
...
transfers. They are done on non-windows systems and translate CRLF to LF.
2006-04-26 07:40:37 +00:00
5a4b43848a
First commit of David McCreedy's EBCDIC and TPF changes.
2006-04-07 21:50:47 +00:00
6e61939382
GnuTLS support added. There's now a "generic" SSL layer that we use all over
...
internally, with code provided by sslgen.c. All SSL-layer-specific code is
then written in ssluse.c (for OpenSSL) and gtls.c (for GnuTLS).
As far as possible, internals should not need to know what SSL layer that is
in use. Building with GnuTLS currently makes two test cases fail.
TODO.gnutls contains a few known outstanding issues for the GnuTLS support.
GnuTLS support is enabled with configure --with-gnutls
2005-04-07 15:27:13 +00:00
62970da675
Removed security.h since it shadows an include file mingw needs when building
...
for SSPI support. The contents of the file has been moved into the krb4.h file.
2005-03-14 00:00:45 +00:00
7e42cb61f7
FTP third transfer support overhaul. See CHANGES for details.
2005-01-21 09:32:32 +00:00
444f6427b8
oops, variables first then code
2004-12-21 14:33:37 +00:00
a173e07eec
Prevent failf() from using the va_list variable more than once.
...
See bug report #1088962 and Single Unix Specification:
http://www.opengroup.org/onlinepubs/007908799/xsh/vfprintf.html
2004-12-21 14:22:10 +00:00
4435e3b269
Fixed so that the final error message is sent to the verbose info "stream"
...
even if no errorbuffer is set.
2004-12-06 23:04:30 +00:00
411e9b0c45
#include "strerror.h" to get the strerror proto
2004-10-12 12:49:38 +00:00
557b6cfd3f
add proper error message when send() fails
2004-10-12 07:24:19 +00:00
39af394a1c
removed tabs and trailing whitespace from source
2004-10-06 07:50:18 +00:00
89c312691e
additional typecasts to please MIPSPro on 64bit IRIX
2004-07-29 07:30:38 +00:00
bd3d5a17b4
Gisle's "SSL patch" from June 16th 2004, modified by me as discussed on the
...
mailing list.
2004-06-18 06:20:43 +00:00
f0969c9692
prevent compiler warning with picky compilers
2004-06-07 10:28:14 +00:00
4c58797607
When sending info about which host that sends what, include proper direction
...
to/from, based on a suggestion from Alexander Krasnostavsky
2004-06-07 07:01:29 +00:00
ea81dd9e2e
Alexander Krasnostavsky's FTP third party transfer (proxy) support
2004-06-03 11:41:05 +00:00
bbafb2eb27
curl_global_init_mem() allows the memory functions to be replaced.
...
memory.h is included everywhere for this.
2004-05-11 11:30:23 +00:00
b8541929c8
curl_slist_append() fixed to clear up properly if a memory function fails
2004-05-10 14:21:19 +00:00
dcf5e52b62
ERR_error_string() returns an unsigned long so we should use one of those
...
for the return code
2004-05-05 07:01:33 +00:00
1401d909e8
Fix the "lingering close" problem when re-using a connection, as test case
...
160 shows.
We got no data and we attempted to re-use a connection. This might happen if
the connection was left alive when we were done using it before, but that was
closed when we wanted to read from it again. Bad luck. Retry the same request
on a fresh connect!
Deleted the sockerror variable again, it serves no purpose anymore.
2004-04-21 08:49:14 +00:00
c39c55cb2d
Minor edit to avoid an unreachable break and to remove the extra {} body
...
within the switch.
2004-03-10 09:50:12 +00:00
ce5805a955
Use curl_socket_t instead of int for holding sockets. The typedefs and
...
defines are in setup.h.
2004-03-09 22:52:50 +00:00
2c756fa1d7
Commented the Curl_read() arguments.
2004-03-08 12:37:46 +00:00
d571064b65
Clear up int/long/size_t/ssize_t usage a bit
2004-02-26 13:40:43 +00:00
9eb6fc1fb6
clear the sockerror if no error was returned
2004-02-02 14:49:10 +00:00
df750c236c
Somewhat crude attempt at fixing the test 91 failures. I commit this now
...
so that the automatic testing hosts will test these changes over the weekend.
2004-01-30 12:08:18 +00:00
4d17d6876e
Dan Fandrich's cleanup patch to make pedantic compiler options cause less
...
warnings. Minor edits by me.
2004-01-29 13:56:45 +00:00
053f6c85ef
updated year in the copyright string
2004-01-07 09:19:33 +00:00
800052dc50
use the HAVE_KRB4 define instead of just KRB4
2003-12-02 13:27:29 +00:00
1e98727c55
FTPS support added as RFC2228 and the murray-ftp-auth-ssl draft describe it
2003-11-24 07:15:37 +00:00
203f66d0cb
James Bursa's fix to prevent failf() to write outside its buffer boundary
2003-10-27 06:35:47 +00:00
d9f961ed2d
better error output on SSL errors when receiving data - Georg Horn patch
2003-10-19 17:38:51 +00:00
749f5387c1
Gisle Vanem's IPv6-on-Windows patch applied!
2003-10-14 12:00:45 +00:00
96e217b496
the new cookie functions that require 'data' passed in
2003-08-11 09:56:06 +00:00
308bc9d919
use CURLDEBUG instead of MALLOCDEBUG for preprocessor conditions
2003-06-26 11:22:12 +00:00
bc7fe85f8a
Just moved around some logic in Curl_write() to make it easier to debug.
2003-06-06 14:56:50 +00:00
c41c05d4f4
Kevin Delafield reported another case where we didn't correctly check for
...
EAGAIN but only EWOULDBLOCK, which caused badness on HPUX. We also check for
and act the same on EINTR errors as well now.
2003-05-06 08:19:36 +00:00
f69ea2c68a
Use the proper Curl_ourerrno() function instead of plain errno, for better
...
portability. Also use Andy Cedilnik's compiler warning fixes.
2003-05-01 13:36:28 +00:00
3c3ad134ea
the default debugfunction shows incoming headers as well
2003-04-09 11:57:06 +00:00
e5b7dc56e6
syntax error
2003-03-11 19:12:07 +00:00
c2d8025a0a
Christophe Demory fixed the check to work better for non-blocking on HP-UX
...
systems. Bug report #701749 .
2003-03-11 19:07:41 +00:00
a7c72b7abf
removed the local variables for emacs and vim, use the new sample.emacs
...
way for emacs, and vim users should provide a similar non-polluting style
2003-01-29 10:14:20 +00:00
f26a338a54
copyright year update in the source header
2003-01-16 21:08:12 +00:00
d0cffdec5d
when sending an error message to the debugfunction, we append a newline so
...
that the output looks better
2003-01-07 11:23:52 +00:00
9b4f92130f
return -1 even if SSL_pending() doesn't return non-zero, as we don't really
...
care how many bytes that is readable NOW. Philippe Raoult reported the
bug in 7.10.3-pre3.
2002-12-29 16:27:31 +00:00
39dc14c002
Fixed the usage of SSL_read() to properly return -1 if the EWOULDBLOCK
...
situation occurs, which it previously didn't!
This was reptoed by Evan Jordan in bug report #653022 .
Also, if ERROR_SYSCALL is returned from SSL_write(), include the errno number
in the error string for easier error detection.
2002-12-19 15:45:15 +00:00
cbf28daed9
Lehel Bernadt's fix to prevent debug message to get sent on errors when
...
debug wasn't enabled
2002-11-05 11:11:10 +00:00
91b84b89e4
failf() now sends the text to the debug function callback
2002-10-08 16:10:37 +00:00
ba4e69bebc
updated source code boilerplate/header
2002-09-03 11:52:59 +00:00
394832c2d6
Markus Oberhumer improved an out-of-memory check
...
I reformatted some functions using a different indent than the rest
of the file.
2002-08-22 19:38:17 +00:00
d321056e8d
made VERBOSE output more like it used to be, HEADER_IN is thus also ignored
...
by the internal debugfunction callback
2002-05-04 15:36:07 +00:00
3f6133be27
Jean-Philippe Barrette-LaPierre provided his patch that introduces
...
CURLOPT_DEBUGFUNCTION and CURLOPT_DEBUGDATA.
2002-04-12 07:21:11 +00:00
e8109b09b1
error code cleanup, use the new SEND/RECV errors
2002-04-10 13:44:42 +00:00
547e91dbf0
Clarence Gardner pointed out the not-taken-care-of return codes from SSL_read
2002-04-02 09:33:38 +00:00
974f314f57
copyright string (year) update
2002-03-19 07:54:55 +00:00
bc9705f758
sendf() now deals with Curl_write() returning -1 properly, which it might
...
do if the write would've blocked
2002-03-13 13:09:37 +00:00
ddbcccd43d
Kevin Roth's discovered SSL download problem
2002-02-05 15:33:00 +00:00
907a6e0eed
Georg Horn the previous SSL_read() fix, this was actually the fix I did
...
on my test machine! :-)
2002-01-30 21:49:29 +00:00
b28051881e
Georg Horn found yet another SSL reading problem caused by the non-blocks.
...
This was a real bummer!
2002-01-30 15:11:47 +00:00
8edfb370a8
Added #include <errno.h>
2002-01-18 09:25:58 +00:00
4c08c8f7db
Andrés García patched. It now checks for EWOULDBLOCK properly on windows
...
boxes.
2002-01-18 08:03:54 +00:00
e177f14595
SSL writes passed back a silly length...
2002-01-16 23:28:58 +00:00
df01507582
Curl_read() and Curl_write() are both now adjusted to return properly in
...
cases where EWOULDBLOCK or equivalent is returned. We must not block.
2002-01-16 14:49:08 +00:00
4931fbce49
Curl_read() now returns a negative return code if EWOULDBLOCK or similar
2002-01-14 23:14:59 +00:00
eecb86bfb0
this seems to correct the SSL reading problem introduced when switching
...
over to non-blocking sockets, but this loops very nastily. We should return
back to the select() and wait there until more data arrives, not just blindly
attempt again and again...
2002-01-08 23:19:32 +00:00
c67f2da283
solaris 2.5.1 needs the sys/types.h file before the sys/socket.h
2001-12-11 15:08:27 +00:00
e192261788
failf() calls should not have newlines in the message string!
2001-12-11 13:13:01 +00:00
436d147925
Eric's #include fixes for better macos compiles
2001-12-04 13:03:08 +00:00
4163b86cd2
failf() now only overwrites the error buffer the first time it gets called
...
for each *_perform(). It makes things a lot easier, as the first one that
detects the error get to write the final error reason...
2001-11-02 22:30:34 +00:00
eaf475b538
return type cleanup
2001-10-31 15:07:45 +00:00
8e91d5de8e
looks nicer and is better compatible with older vim versions
2001-10-11 09:32:19 +00:00
6147879837
Added formatting sections for emacs and vim
2001-09-07 04:01:32 +00:00
0ece1b5c34
Major rename and redesign of the internal "backbone" structs. Details will
...
be posted in a minute to the libcurl list.
2001-08-30 22:48:34 +00:00
1b00298b52
modified to use the renamed kerberos functions with Curl_ prefix
2001-08-17 10:14:06 +00:00
5f42ef8f5b
cleaned up some of the size_t and const mess
2001-08-14 08:34:09 +00:00
944f9a73f4
Jonathan Hseu noticed that you couldn't get a header callback unless you
...
set CURLOPT_WRITEHEADER to non-NULL, even if you didn't care about that
data. This is now fixed.
2001-08-06 08:22:26 +00:00
fe82ddda46
CURLOPT_MUTE and data->bits.mute are history, removed, gone!
2001-05-31 13:50:28 +00:00
025fa762f6
Added new CURLOPT_HEADERFUNCTION callback for writing headers only
2001-04-10 06:49:32 +00:00
c622f2bb4e
failf() now respects the mute flag
2001-03-13 13:22:58 +00:00
071c7de9fe
removed curl_read() and curl_write() - they weren't used and the public
...
"low leve" interface is dumped
2001-03-09 15:14:22 +00:00
b6fa2f882c
moved the slist-functions here from FTP since they're more generic than simply
...
for FTP-stuff
2001-03-02 07:42:11 +00:00
a1d6ad2610
multiple connection support initial commit
2001-02-20 17:35:51 +00:00
c41c5a0ef2
curl_read() and Curl_read() now have ssize_t in the last argument
2001-01-31 13:54:12 +00:00
1552bd9c8c
sendf is now only Curl_sendf
...
Curl_write() and Curl_read() are here
2001-01-25 12:20:30 +00:00
4031104404
Internal symbols that aren't static are now prefixed with 'Curl_'
2001-01-05 10:11:41 +00:00
Daniel Stenberg