Steve Holme
ddac43b38e
url: Fixed missing length check in parse_proxy()
...
Commit 11332577b3
removed the length check that was performed by the
old scanf() code.
2013-04-21 18:29:33 +01:00
Steve Holme
416ecc1584
url: Fixed crash when no username or password supplied for proxy
...
Fixed an issue in parse_proxy(), introduced in commit 11332577b3
,
where an empty username or password (For example: http://:@example.com )
would cause a crash.
2013-04-21 16:55:19 +01:00
Steve Holme
455ba691a7
url: Removed unused text length constants
2013-04-21 12:16:12 +01:00
Steve Holme
11332577b3
url: Updated proxy URL parsing to use parse_login_details()
2013-04-21 12:12:29 +01:00
Steve Holme
702b0dd408
url: Tidy up of setstropt_userpwd() parameters
...
Updated the naming convention of the login parameters to match those of
other functions.
2013-04-21 10:27:42 +01:00
Steve Holme
e8a9f794f0
url: Tidy up of code and comments following recent changes
...
Tidy up of variable names and comments in setstropt_userpwd() and
parse_login_details().
2013-04-21 10:23:47 +01:00
Steve Holme
bddf3d4705
url: Simplified setstropt_userpwd() following recent changes
...
There is no need to perform separate clearing of data if a NULL option
pointer is passed in. Instead this operation can be performed by simply
not calling parse_login_details() and letting the rest of the code do
the work.
2013-04-20 20:04:00 +01:00
Steve Holme
e99c81a07c
url: Correction to scope of if statements when setting data
2013-04-20 19:10:10 +01:00
Steve Holme
fe880475ed
url: Fixed memory leak in setstropt_userpwd()
...
setstropt_userpwd() was calling setstropt() in commit fddb7b44a7
to
set each of the login details which would duplicate the strings and
subsequently cause a memory leak.
2013-04-20 18:40:13 +01:00
Steve Holme
d535c4a2e1
url: Added overriding of URL login options from CURLOPT_USERPWD
2013-04-20 09:18:51 +01:00
Steve Holme
fddb7b44a7
url: Added support for parsing login options from the CURLOPT_USERPWD
...
In addition to parsing the optional login options from the URL, added
support for parsing them from CURLOPT_USERPWD, to allow the following
supported command line:
--user username:password;options
2013-04-20 09:08:28 +01:00
Steve Holme
49184c3723
url: Added bounds checking to parse_login_details()
...
Added bounds checking when searching for the separator characters within
the login string as this string may not be NULL terminated (For example
it is the login part of a URL). We do this in preference to allocating a
new string to copy the login details into which could then be passed to
parse_login_details() for performance reasons.
2013-04-19 19:37:55 +01:00
Steve Holme
cc7f6a2ddf
url: Added size_t cast to pointer based length calculations
2013-04-19 14:11:43 +01:00
Steve Holme
90fe59b829
url: Corrected minor typo in comment
2013-04-19 12:53:59 +01:00
Steve Holme
8763374f0e
url: Fix chksrc longer than 79 columns warning
2013-04-18 20:21:11 +01:00
Steve Holme
63388fe1f3
url: Fix incorrect variable type for result code
2013-04-18 19:18:02 +01:00
Steve Holme
b75a88aa72
url: Fix compiler warning
...
signed and unsigned type in conditional expression
2013-04-18 19:14:25 +01:00
Steve Holme
bb20989a63
url: Moved parsing of login details out of parse_url_login()
...
Separated the parsing of login details from the processing of them in
parse_url_login() ready for use by setstropt_userpwd().
2013-04-18 18:09:53 +01:00
Steve Holme
0d49e408a4
url: Re-factored set_userpass() and parse_url_userpass()
...
Re-factored these functions to reflect their new behaviour following the
addition of login options.
2013-04-18 17:36:15 +01:00
Steve Holme
90c87f311e
url: Reworked URL parsing to allow overriding by CURLOPT_USERPWD
2013-04-18 17:20:43 +01:00
Steve Holme
c306d2e42f
smtp: Re-factored all perform based functions
...
Standardised the naming of all perform based functions to be in the form
smtp_perform_something().
2013-04-16 19:48:20 +01:00
Steve Holme
f737e3a3dd
smtp: Added description comments to all perform based functions
2013-04-16 19:44:53 +01:00
Steve Holme
686586b0f9
smtp: Moved smtp_quit() to be with the other perform functions
2013-04-16 19:44:52 +01:00
Steve Holme
e621a5f6ea
smtp: Moved smtp_rcpt_to() to be with the other perform functions
2013-04-16 19:44:49 +01:00
Steve Holme
8093f9541e
smtp: Moved smtp_mail() to be with the other perform functions
2013-04-16 19:44:47 +01:00
Steve Holme
552ba67bb1
pop3: Added missing comment for pop3_state_apop_resp()
2013-04-15 20:27:49 +01:00
Steve Holme
651254dcc7
smtp: Updated the coding style of smtp_state_servergreet_resp()
...
Updated the coding style, in this function, to be consistant with other
response functions rather then performing a hard return on failure.
2013-04-15 20:27:47 +01:00
Steve Holme
26bdafcbf9
pop3: Updated the coding style of pop3_state_servergreet_resp()
...
Updated the coding style, in this function, to be consistent with other
response functions rather then performing a hard return on failure.
2013-04-15 20:27:45 +01:00
Steve Holme
02dc9e788f
pop3: Re-factored all perform based functions
...
Standardised the naming of all perform based functions to be in the form
pop3_perform_something() following the changes made to IMAP.
2013-04-14 10:06:10 +01:00
Steve Holme
e11c6e9961
pop3: Added description comments to all perform based functions
2013-04-14 10:06:08 +01:00
Steve Holme
e4eaa92728
pop3: Moved pop3_quit() to be with the other perform functions
2013-04-14 10:06:07 +01:00
Steve Holme
577f8e5ac6
pop3: Moved pop3_command() to be with the other perform functions
...
Started to apply the same tidy up to the POP3 code as applied to the
IMAP code in the 7.30.0 release.
2013-04-14 10:06:05 +01:00
Steve Holme
8723cade21
smtp: Added support for ;auth=<mech> in the URL
...
Added support for specifying the preferred authentication mechanism in
the URL as per Internet-Draft 'draft-earhart-url-smtp-00'.
2013-04-13 16:23:00 +01:00
Steve Holme
d956d9db47
pop3: Reworked authentication type constants
...
... to use left-shifted values, like those defined in curl.h, rather
than 16-bit hexadecimal values.
2013-04-13 16:20:48 +01:00
Steve Holme
ecf93ac986
pop3: Small consistency tidy up
2013-04-13 16:16:23 +01:00
Steve Holme
b3a01be2f3
pop3: Added support for ;auth=<mech> in the URL
...
Added support for specifying the preferred authentication type and SASL
mechanism in the URL as per RFC-2384.
2013-04-13 16:16:21 +01:00
Steve Holme
00045a3009
imap: Added support for ;auth=<mech> in the URL
...
Added support for specifying the preferred authentication mechanism in
the URL as per RFC-5092.
2013-04-13 16:11:27 +01:00
Steve Holme
3f7188dd94
sasl: Reworked SASL mechanism constants
...
... to use left-shifted values, like those defined in curl.h, rather
than 16-bit hexadecimal values.
2013-04-13 13:29:50 +01:00
Steve Holme
720218fea1
sasl: Added predefined preferred mechanism values
...
In preparation for the upcoming changes to IMAP, POP3 and SMTP added
preferred mechanism values.
2013-04-13 13:11:37 +01:00
Steve Holme
73aa95592f
url: Added support for parsing login options from the URL
...
As well as parsing the username and password from the URL, added support
for parsing the optional options part from the login details, to allow
the following supported URL format:
schema://username:password;options@example.com/path?q=foobar
This will only be used by IMAP, POP3 and SMTP at present but any
protocol that may be given login options in the URL will be able to
add support for them.
2013-04-13 10:49:42 +01:00
Steve Holme
ad3fdbc0a4
smtp: Fix compiler warning
...
warning: unused variable 'smtp' introduced in commit 73cbd21b5e
.
2013-04-13 00:06:19 +01:00
Steve Holme
73cbd21b5e
smtp: Moved parsing of url path into separate function
2013-04-12 23:15:51 +01:00
Daniel Stenberg
c5ba0c2f54
FTP: handle a 230 welcome response
...
...instead of the 220 we otherwise expect.
Made the ftpserver.pl support sending a custom "welcome" and then
created test 1219 to verify this fix with such a 230 welcome.
Bug: http://curl.haxx.se/mail/lib-2013-02/0102.html
Reported by: Anders Havn
2013-04-12 23:59:37 +02:00
Daniel Stenberg
61d259f950
FTP: access files in root dir correctly
...
Accessing a file with an absolute path in the root dir but with no
directory specified was not handled correctly. This fix comes with four
new test cases that verify it.
Bug: http://curl.haxx.se/mail/lib-2013-04/0142.html
Reported by: Sam Deane
2013-04-12 22:43:13 +02:00
Steve Holme
c01735865f
pop3: Reworked the function description for Curl_pop3_write()
2013-04-12 20:22:14 +01:00
Steve Holme
ca46c5dbe2
pop3: Added function description to pop3_parse_custom_request()
2013-04-12 20:22:12 +01:00
Steve Holme
2da127abb5
pop3: Moved utility functions to end of pop3.c
2013-04-12 20:22:10 +01:00
Nick Zitzmann
bc33f2200d
darwinssl: add TLS session resumption
...
This ought to speed up additional TLS handshakes, at least in theory.
2013-04-12 12:20:10 -06:00
Steve Holme
fd399cde00
imap: Added function description to imap_parse_custom_request()
2013-04-12 18:27:51 +01:00
Steve Holme
00c74019f4
imap: Moved utility functions to end of imap.c (Part 3/3)
...
Moved imap_is_bchar() be with the other utility based functions.
2013-04-12 18:24:46 +01:00