moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2024-12-25 09:38:54 -05:00
Code Issues Releases Wiki Activity
23,321 Commits 10 Branches 144 Tags 113 MiB
d390541944
Commit Graph

48 Commits

Author SHA1 Message Date
Daniel Stenberg
cb529b713f
checksrc: make sure sizeof() is used *with* parentheses 
... and unify the source code to adhere.

Closes #2563
 2018-05-21 23:21:47 +02:00
Daniel Gustafsson
2f13e3d23d
checksrc: force indentation of lines after an else 
This extends the INDENTATION case to also handle 'else' statements
and require proper indentation on the following line. Also fixes the
offending cases found in the codebase.

Closes #2532
 2018-04-27 00:51:35 +02:00
Daniel Gustafsson
9b96e0bb44 checksrc: Fix typo 
Fix typo in "semicolon" spelling and remove stray tab character.

Closes https://github.com/curl/curl/pull/2498
 2018-04-15 03:05:45 -04:00
Viktor Szakats
cd3903127f checksrc.pl: add -i and -m options 
To sync it with changes made for the libssh2 project.
Also cleanup some whitespace.
 2018-03-12 18:20:29 +00:00
Viktor Szakats
7e35eb7729 spelling fixes 
Detected using the `codespell` tool.

Also contains one URL protocol upgrade.

Closes https://github.com/curl/curl/pull/2334
 2018-02-23 23:29:01 +00:00
Jay Satiro
d4e40f0690 scripts: allow all perl scripts to be run directly 
- Enable execute permission (chmod +x)

- Change interpreter to /usr/bin/env perl

Closes https://github.com/curl/curl/pull/2222
 2018-01-07 15:42:11 -05:00
Daniel Stenberg
59813726d1
checksrc: detect and warn for multiple spaces 2017-09-12 09:50:24 +02:00
Daniel Stenberg
67ade28571
checksrc: verify space after semicolons 2017-09-12 09:50:24 +02:00
Daniel Stenberg
ca86006deb
checksrc: detect and warn for lack of spaces next to plus signs 2017-09-11 09:29:50 +02:00
Daniel Stenberg
e155f38d1e
checksrc: verify spaces around equals signs 
... as the code style mandates.
 2017-09-11 09:27:28 +02:00
Patrick Monnerat
ea4e7bdc81 checksrc: disable SPACEBEFOREPAREN for case statement. 
The case keyword may be followed by a constant expression and thus should
allow it to start with an open parenthesis.
 2017-09-02 12:58:55 +01:00
Daniel Stenberg
60cf84f7f2 checksrc: escape open brace in regex 
... to silence warning.
 2017-07-27 01:13:19 +02:00
Jay Satiro
c2402b6e02 tests: checksrc compliance 2016-12-19 02:31:59 -05:00
Daniel Stenberg
1c3e8bbfed checksrc: warn for assignments within if() expressions 
... they're already frowned upon in our source code style guide, this
now enforces the rule harder.
 2016-12-14 01:29:44 +01:00
Daniel Stenberg
b228d2952b checksrc: stricter no-space-before-paren enforcement 
In order to make the code style more uniform everywhere
 2016-12-13 23:39:11 +01:00
Daniel Stenberg
80e7cfeb87 checksrc: detect wrongly placed open braces in func declarations 2016-11-24 23:58:22 +01:00
Daniel Stenberg
ec0a5c96ac checksrc: verify ASTERISKNOSPACE 
Detects (char*) and 'char*foo' uses.
 2016-11-24 23:58:22 +01:00
Daniel Stenberg
bc7e08471c checksrc: add ASTERISKSPACE 
Verifies a 'char *name' style, with no space after the asterisk.
 2016-11-24 23:48:45 +01:00
Daniel Stenberg
5871dfcc16 checksrc: detect strtok() use 
... as that function slipped through once before.
 2016-09-07 10:41:57 +02:00
Jay Satiro
84a48e5732 checksrc: Add LoadLibrary to the banned functions list 
LoadLibrary was supplanted by Curl_load_library for security
reasons in 6df916d.
 2016-06-05 21:07:03 -04:00
Steve Holme
0a2422753f checksrc.pl: Added variants of strcat() & strncat() to banned function list 
Added support for checking the tchar, unicode and mbcs variants of
strcat() and strncat() in the banned function list.
 2016-05-23 12:13:41 +01:00
Daniel Stenberg
6109e0f509 checksrc: taught to skip comments 
... but output non-stripped version of the line, even if that then can
make the script identify the wrong position in the line at
times. Showing the line stripped (ie without comments) is just too
surprising.
 2016-04-19 08:52:22 +02:00
Daniel Stenberg
9d194a1143 checksrc: check for more malplaced spaces 2016-04-03 22:38:36 +02:00
Daniel Stenberg
19fafa1f5a checksrc: remove debug crap 2016-04-03 22:38:36 +02:00
Daniel Stenberg
21e8e5d990 checksrc: allow ignore of specific warnings within a file (section) 2016-04-03 22:38:36 +02:00
Daniel Stenberg
dc3ff47dc7 checksrc: add warning names, explain on help output 2016-04-03 22:38:36 +02:00
Daniel Stenberg
5ea3d2ff06 checksrc: improve the fopen() parser somewhat 
The quote scanner was too fragile, now look for a comma instead to find
the mode argument.
 2016-04-03 11:29:14 +02:00
Daniel Stenberg
4af40b3646 URLs: change all http:// URLs to https:// 2016-02-03 00:19:02 +01:00
Daniel Stenberg
9744ef2289 checksrc: add crude // detection 2015-10-21 23:18:04 +02:00
Daniel Stenberg
33ee411848 checksrc: detect fopen() for text without the FOPEN_* macros 
Follow-up to e8423f9ce1 with discussionis in
https://github.com/bagder/curl/pull/258

This check scans for fopen() with a mode string without 'b' present, as
it may indicate that an FOPEN_* define should rather be used.
 2015-06-02 08:28:10 +02:00
Jay Satiro
6419aee248 checksrc: Windows-specific input fixes 
lib/config-win32ce.h
- Fix whitespace for checksrc compliance.

lib/checksrc.pl
- Remove trailing carriage returns from input.

projects/checksrc.bat
- Ignore tool_hugehelp.c.
 2015-03-30 22:39:13 +02:00
Dan Fandrich
252e9acd50 checksrc: Fix whitelist on out-of-tree builds 2015-03-17 23:26:48 +01:00
Daniel Stenberg
2dc1a5ce93 checksrc: detect and remove space before trailing semicolons 2015-03-17 14:06:48 +01:00
Daniel Stenberg
0037eb5805 checksrc: introduce a whitelisting concept 2015-03-17 13:57:37 +01:00
Daniel Stenberg
9395999543 checksrc: use space after comma 2015-03-17 13:57:37 +01:00
Daniel Stenberg
a6b8fe2a5f checksrc: use space before paren in "return (expr);" 2015-03-17 13:05:01 +01:00
Daniel Stenberg
7f963a19ec checksrc: ban unsafe functions 
The list of unsafe functions currently consists of sprintf, vsprintf,
strcat, strncat and gets.

Subsequently, some existing code needed updating to avoid warnings on
this.
 2013-03-07 11:08:05 +01:00
Daniel Stenberg
58a7c51362 checksrc: detect "}else" uses as well 2011-09-07 22:45:43 +02:00
Yang Tse
40e1d03c5d checksrc.pl: add quotes to var 2011-08-05 21:24:59 +02:00
Yang Tse
c95fec5e5b keep a single copy of config-win32.h in version control repository - followup 
Allow configure builds to generate src/config-win32.h

Skip checksrc on src/config-win32.h contents already checked at lib/config-win32.h

Allow multiple -W in checksrc.pl
 2011-08-05 21:01:39 +02:00
Daniel Stenberg
dc97475ded checksrc: detect open brace without space 
We use "if(condition) {" with a space between the close paren and the
open brace.
 2011-07-04 22:08:14 +02:00
Yang Tse
f461c6e61d Make checksrc.pl work on more out-of-tree builds 
Source files given with relative paths do not have the
-D directory specifier prepended.
 2011-05-26 19:17:10 +02:00
Daniel Stenberg
bb7ff942d3 checksrc: trailing whitespace detection fix 2011-05-16 15:21:32 +02:00
Dan Fandrich
cbd98b2c28 Make checksrc.pl work on out-of-tree builds 
Source files given with absolute paths do not have the
-D directory specifier prepended.
 2011-04-27 12:42:15 -07:00
Daniel Stenberg
6a6981503e checksrc: add -W to allow a file to be whitelisted 
Useful when a known file just doesn't comply and there's no intention to
make it do so.
 2011-04-27 09:09:35 +02:00
Daniel Stenberg
7ddcc8fea4 checksrc: scan many files, more checks 
It now scans multiple files and outputs an error+warning count summary
at the end in case at least one was detected.

-D can be used to specify in which dir the files are located

The script now scans for conditions that starts with a space for
if/while/for lines.
 2011-04-27 09:09:35 +02:00
Daniel Stenberg
92f722017c checksrc: exit error code if warnings or errors 2011-04-27 09:09:35 +02:00
Daniel Stenberg
b903186fa0 source cleanup: unify look, style and indent levels 
By the use of a the new lib/checksrc.pl script that checks that our
basic source style rules are followed.
 2011-04-27 09:09:35 +02:00