Ben Winslow
27b8814017
progress: reset flags at transfer start
...
When an easy handle is used to download an URI which has no
Content-Length header (or equivalent) after downloading an URI which
does, the value from the previous transfer is reused and returned by
CURLINFO_CONTENT_LENGTH_DOWNLOAD. This is because the progress flags
(used to determine whether such a header was received) are not reset
between transfers.
Bug: http://curl.haxx.se/bug/view.cgi?id=3370895
2011-07-22 22:50:58 +02:00
Daniel Stenberg
b903186fa0
source cleanup: unify look, style and indent levels
...
By the use of a the new lib/checksrc.pl script that checks that our
basic source style rules are followed.
2011-04-27 09:09:35 +02:00
Fabian Keil
1702a2c08d
Fix a couple of spelling errors in lib/
...
Found with codespell.
2011-04-21 07:55:53 -07:00
Julien Chaffraix
34ef39015e
progress: don't print the last update on a separate line.
...
Curl_posttransfer is called too soon to add the final new line.
Moved the new line logic to pgrsDone as there is no more call to
update the progress status after this call.
Reported by: Dmitri Shubin <sbn_at_tbricks.com>
http://curl.haxx.se/mail/lib-2010-12/0162.html
2011-03-21 21:00:56 -07:00
Daniel Stenberg
2309b4e330
remove the CVSish $Id$ lines
2010-03-24 11:02:54 +01:00
Yang Tse
3f56d12830
avoid division by zero
2009-11-05 15:00:28 +00:00
Daniel Stenberg
257f2376d5
- I fixed several problems with the transfer progress meter. It showed the
...
wrong percentage for small files, most notable for <1000 bytes and could
easily end up showing more than 100% at the end. It also didn't show any
percentage, transfer size or estimated transfer times when transferring
less than 100 bytes.
2009-11-04 23:09:17 +00:00
Daniel Stenberg
223d848104
- Gabriel Kuri reported a problem with CURLINFO_CONTENT_LENGTH_DOWNLOAD if the
...
download was 0 bytes, as libcurl would then return the size as unknown (-1)
and not 0. I wrote a fix and test case 566 to verify it.
2009-10-31 18:51:50 +00:00
Yang Tse
2ecf22e37e
fix compiler warning: explicit conversion of a 64-bit integral type to a smaller integral type
2008-10-11 01:56:04 +00:00
Yang Tse
3e2487493e
Use SIZEOF_OFF_T definition from config file
2008-08-26 01:40:19 +00:00
Yang Tse
ad638da2c2
Library internal only C preprocessor macros FORMAT_OFF_T and FORMAT_OFF_TU
...
remain in use as internal curl_off_t print formatting strings for the internal
*printf functions which still cannot handle print formatting string directives
such as "I64d", "I64u", and others available on MSVC, MinGW, Intel's ICC, and
other DOS/Windows compilers.
This reverts previous commit part which did:
FORMAT_OFF_T -> CURL_FORMAT_CURL_OFF_T
FORMAT_OFF_TU -> CURL_FORMAT_CURL_OFF_TU
2008-08-16 01:33:59 +00:00
Yang Tse
66fb9ca5f6
For congruency sake with the naming of other CURL_XXXXXX_CURL_OFF_T macros,
...
the names of the curl_off_t formatting string directives now become
CURL_FORMAT_CURL_OFF_T and CURL_FORMAT_CURL_OFF_TU.
CURL_FMT_OFF_T -> CURL_FORMAT_CURL_OFF_T
CURL_FMT_OFF_TU -> CURL_FORMAT_CURL_OFF_TU
Remove the use of an internal name for the curl_off_t formatting string directives
and use the common one available from the inside and outside of the library.
FORMAT_OFF_T -> CURL_FORMAT_CURL_OFF_T
FORMAT_OFF_TU -> CURL_FORMAT_CURL_OFF_TU
2008-08-15 02:58:15 +00:00
Yang Tse
4d1cd0da93
Fix curl_off_t sized constants usage
2008-08-12 18:49:33 +00:00
Yang Tse
24b1890710
s/SIZEOF_CURL_OFF_T/CURL_SIZEOF_CURL_OFF_T/g
2008-08-11 01:22:57 +00:00
Daniel Stenberg
7c648782bc
Introcuding a new timestamp for curl_easy_getinfo():
...
CURLINFO_APPCONNECT_TIME. This is set with the "application layer"
handshake/connection is completed (typically SSL, TLS or SSH). By using this
you can figure out the application layer's own connect time. You can extract
the time stamp using curl's -w option and the new variable named
'time_appconnect'. This feature was sponsored by Lenny Rachitsky at NeuStar.
2008-07-03 06:56:03 +00:00
Daniel Stenberg
13648f8ccd
struct HandleData is now called struct SingleRequest, and is only for data that
...
is inited at the start of the DO action. I removed the Curl_transfer_keeper
struct completely, and I had to move out a few struct members (that had to
be set before DO or used after DONE) to the UrlState struct. The SingleRequest
struct is accessed with SessionHandle->req.
One of the biggest reasons for doing this was the bunch of duplicate struct
members in HandleData and Curl_transfer_keeper since it was really messy to
keep track of two variables with the same name and basically the same purpose!
2007-11-24 23:16:55 +00:00
Daniel Stenberg
8e719e3ef5
- Prevent the internal progress meter from updating more frequently than once
...
per second.
2007-04-18 20:02:41 +00:00
Yang Tse
34afb0b257
Change spelling, ONE_TERRABYTE -> ONE_TERABYTE
...
Shave off a couple of function calls in the part of
Curl_pgrsUpdate() which is always executed when called.
Fix a couple of comments.
2007-03-23 04:23:53 +00:00
Yang Tse
072a8b2955
Bryan Henderson fixed the progress function so that it can get called
...
more frequently allowing same calling frecuency for the client progress
callback, while keeping the once a second frecuency for speed calculations
and internal display of the transfer progress.
2007-03-19 12:02:33 +00:00
Daniel Stenberg
c8cd13337e
reverted the pselect patch => http://curl.haxx.se/mail/lib-2007-03/0100.html
2007-03-11 09:11:29 +00:00
Daniel Stenberg
dbaf4f9361
- Bryan Henderson introduces two things:
...
1) the progress callback gets called more frequently (at times)
2) libcurl *might* call the callback when it receives a signal
2007-03-10 12:11:21 +00:00
Yang Tse
772a985dc3
Update copyright year, since the file has been modified
2006-10-27 03:47:57 +00:00
Daniel Stenberg
b7eeb6e67f
Major overhaul introducing http pipelining support and shared connection
...
cache within the multi handle.
2006-09-07 21:49:20 +00:00
Daniel Stenberg
ffe17a8197
As reported in Mandrake's bug tracker bug 12289
...
(http://qa.mandrakesoft.com/show_bug.cgi?id=12289 ), curl would print a newline
to "finish" the progress meter after each redirect and not only after a
completed transfer.
2004-11-26 14:33:13 +00:00
Daniel Stenberg
fe46572f2b
prevent warning with comparison between signed and unsigned
2004-10-08 08:16:02 +00:00
Daniel Stenberg
39af394a1c
removed tabs and trailing whitespace from source
2004-10-06 07:50:18 +00:00
Daniel Stenberg
9dbd6659dc
more typecasts to please picky compilers
2004-08-10 06:41:13 +00:00
Daniel Stenberg
aedadfc779
explicit typecasts to double to prevent warnings about implicit conversions
...
that might lose accuracy
2004-07-02 11:56:26 +00:00
Daniel Stenberg
18dc8fbc26
typecast to int when the variable is int!
2004-07-01 07:28:36 +00:00
Daniel Stenberg
feb2dd2835
Replaced all uses of sprintf() with the safer snprintf(). It is just a
...
precaution to prevent mistakes to lead to buffer overflows.
2004-06-24 11:54:11 +00:00
Daniel Stenberg
aadc797225
quickfix to avoid division by zero, possibly we should go over all of these
...
once and for all
2004-05-21 12:23:53 +00:00
Daniel Stenberg
60f9450594
calculate upload and download speed using doubles to keep precision.
...
deleted trailing whitespace
2004-05-20 20:35:42 +00:00
Daniel Stenberg
9cf04dff6a
hm, avoid division by zero more carefully with that new percentage math
2004-05-05 14:22:46 +00:00
Daniel Stenberg
3f21fe60fc
Gisle fixed the percentage to work, I adjusted it slightly to not as easily
...
overflow on 32bit filesize-systems
2004-05-05 13:44:44 +00:00
Daniel Stenberg
6062ac7c37
made the progress meter display not overflow even if _very_ large files
...
are transfered. The maximum size we support now is 8 exabytes, which equals
to 8192 petabytes...
2004-05-05 08:43:23 +00:00
Daniel Stenberg
caf7854a3c
if the values allow it, avoid floting point math for the current speed
2004-05-05 07:45:21 +00:00
Daniel Stenberg
5887945828
Gisle Vanem corrected a mistake in a recent progress fix
2004-04-19 07:18:26 +00:00
Daniel Stenberg
2fd463e979
Dirk Manske increased the resolution for what the CURLINFO_*_TIME return.
2004-04-09 09:36:31 +00:00
Daniel Stenberg
7ba4d3464f
Dirk Manske's feedback:
...
* bring back subsecond resolution to CURLINFO_TOTAL_TIME
* Fix the Curl_pgrsDone() so that the final progress update is shown properly
2004-04-02 07:32:03 +00:00
Daniel Stenberg
306ff5649a
made time2str() use longs internally instead to prevent compiler warnings
...
when converting to ints
2004-03-23 15:06:14 +00:00
Daniel Stenberg
1c652dfc5d
added explicit typecasts to prevent compiler warnings on variable conversions
2004-03-23 15:01:19 +00:00
Daniel Stenberg
0aa720fa26
it actually fits to make a NNNd NNh display so this can be used up to
...
999 days
2004-03-23 11:46:31 +00:00
Daniel Stenberg
d44f3f84f8
Fixed the time fields no never get wider than 8 letters. They can now switch
...
to a "days + hours" or even "just days" display if the time value is very
large. I also switched several calculations over to fixed-point instead of the
previous doubles.
2004-03-23 11:43:34 +00:00
Daniel Stenberg
1d5a914c1c
Made max5data() take a curl_off_t size as argument instead of double. Should
...
make the progress meter more accurate for large files. Also made the sprintf
usage in that function avoid floating point.
2004-03-11 21:48:15 +00:00
Daniel Stenberg
0d1fc73f21
Use more curl_off_t variables when doing the progress meter calculations and
...
argument passing and try to convert to double only when providing data to the
external world.
2004-03-10 16:20:33 +00:00
Daniel Stenberg
353f764119
Yet another curl_off_t printf format attempt, we now exclude the %-letter from
...
FORMAT_OFF_T to allow additional options to get specified, like with '"%5"
FORMAT_OFF_T'.
2004-03-02 09:31:18 +00:00
Daniel Stenberg
7ab3b5b3bb
use FORMAT_OFF_T instead of CURL_FORMAT_OFF_T to reduce the complexity of
...
having to redef that name
2004-03-02 07:25:39 +00:00
Daniel Stenberg
cb72a80fe0
Use CURL_FORMAT_OFF_T for printf()inf curl_off_t variables.
2004-03-01 16:28:00 +00:00
Daniel Stenberg
4d17d6876e
Dan Fandrich's cleanup patch to make pedantic compiler options cause less
...
warnings. Minor edits by me.
2004-01-29 13:56:45 +00:00
Daniel Stenberg
e096072745
very big transfers now get nicer progress displayed after 9999 megabytes have
...
been transfered!
2004-01-27 12:25:37 +00:00
Daniel Stenberg
fac1c13895
fixed the progress meter display for files >32 bit, Gisle Vanem reported
2004-01-23 08:02:12 +00:00
Daniel Stenberg
686c70c5b5
use the %dk display for one extra k of progress
2004-01-15 13:08:12 +00:00
Daniel Stenberg
053f6c85ef
updated year in the copyright string
2004-01-07 09:19:33 +00:00
Daniel Stenberg
b60e0fa97e
David J Meyer's large file support.
2004-01-05 22:29:29 +00:00
Daniel Stenberg
749f5387c1
Gisle Vanem's IPv6-on-Windows patch applied!
2003-10-14 12:00:45 +00:00
Daniel Stenberg
22569681bc
George Comninos provided a fix that calls the progress meter when waiting
...
for FTP command responses take >1 second.
2003-05-14 06:31:00 +00:00
Daniel Stenberg
a7c72b7abf
removed the local variables for emacs and vim, use the new sample.emacs
...
way for emacs, and vim users should provide a similar non-polluting style
2003-01-29 10:14:20 +00:00
Daniel Stenberg
f26a338a54
copyright year update in the source header
2003-01-16 21:08:12 +00:00
Daniel Stenberg
ba4e69bebc
updated source code boilerplate/header
2002-09-03 11:52:59 +00:00
Daniel Stenberg
982c5460f0
Andrew Francis removed the need for/use of MSVC pragmas
2002-08-26 17:20:29 +00:00
Daniel Stenberg
bce5e0d82c
T. Bharath fixed the TIMER_REDIRECT.
2002-06-03 12:46:04 +00:00
Daniel Stenberg
39028f1bd4
make sure our own printf() clones are used
2002-05-03 12:06:04 +00:00
Daniel Stenberg
62d205a2ec
Dirk Manske brought the patch that introduces two new CURLINFO_* values:
...
CURLINFO_REDIRECT_TIME and CURLINFO_REDIRECT_COUNT.
2002-04-16 07:59:20 +00:00
Daniel Stenberg
974f314f57
copyright string (year) update
2002-03-19 07:54:55 +00:00
Daniel Stenberg
ca0fd33d2d
Georg Horn's STARTTRANSFER_TIME patch
2001-11-20 15:00:50 +00:00
Daniel Stenberg
c55d0bb804
We need at least one millisecond to calculate current speed with! I also
...
made the getinfo() stuff divide with 1000.0 now to enforce floating point
since Paul Harrington claims the 7.9.1 still uses even second resolution
in the timers there
2001-11-12 08:50:59 +00:00
Daniel Stenberg
bbdc9f15e7
added typecasts to make the timers calculate with doubles, not longs as they
...
accidentally did after the Curl_tvdiff() interface change
2001-10-31 14:45:47 +00:00
Daniel Stenberg
babb985f1a
made 'timespent' a double, which makes more accurate calculations for quick
...
downloads
2001-10-26 11:25:03 +00:00
Daniel Stenberg
ef48c73783
extensively commented source code, parts refreshened, the "current speed" is
...
now more accurate since it is based on actual spent time without the
assumptions from before
2001-10-12 12:31:06 +00:00
Sterling Hughes
8e91d5de8e
looks nicer and is better compatible with older vim versions
2001-10-11 09:32:19 +00:00
Sterling Hughes
6147879837
Added formatting sections for emacs and vim
2001-09-07 04:01:32 +00:00
Daniel Stenberg
0ece1b5c34
Major rename and redesign of the internal "backbone" structs. Details will
...
be posted in a minute to the libcurl list.
2001-08-30 22:48:34 +00:00
Daniel Stenberg
d5fbfa3d0b
As Andrés García reported we need to fflush() the data->err so that the
...
progress meter looks better on windows (and if the data->err is redirected
from stderr it also makes a point)
2001-08-21 06:29:56 +00:00
Daniel Stenberg
4b6c240832
moved the download/upload speed calculations, to be made on every invoke
...
of the progressupdate, as on very quick transfers they wouldn't always get
calculated!
2001-08-10 06:24:49 +00:00
Daniel Stenberg
2b44fdab2e
don't do final newline output when using progress callback
2001-08-02 17:05:11 +00:00
Daniel Stenberg
3fd65fb7d8
Remade resume stuff to keep data in the connectdata struct instead of the
...
main handle struct to work with persistant connections
2001-04-18 07:25:11 +00:00
Daniel Stenberg
8274bee963
init the speed index variable between transfers
2001-04-17 15:00:17 +00:00
Daniel Stenberg
c8a546c941
The progess meter title get an extra output when a resumed transfer is
...
taking place
2001-01-27 18:23:59 +00:00
Daniel Stenberg
c43a9d9068
timespent is now updated in every call to the progress meter update function
2001-01-25 12:32:40 +00:00
Daniel Stenberg
abcd1e7d5a
Björn Stenberg's patch for making the progress meter betterlooking
2001-01-22 16:21:05 +00:00
Daniel Stenberg
4031104404
Internal symbols that aren't static are now prefixed with 'Curl_'
2001-01-05 10:11:41 +00:00
Daniel Stenberg
24dee483e9
dual-license fix
2001-01-03 09:29:33 +00:00
Daniel Stenberg
77bbbd868b
data->err must be used, not stderr
2000-11-16 07:20:12 +00:00
Daniel Stenberg
e05922c428
modified pgrsTime() to the new functionality
2000-11-06 15:32:16 +00:00
Daniel Stenberg
f353258ff6
corrected bad data re-use and buffer problems
2000-09-25 21:49:37 +00:00
Daniel Stenberg
b6e18f2f66
#include "setup.h" moved first of all includes
2000-08-24 14:26:33 +00:00
Daniel Stenberg
1ef3600a07
haxx.nu => haxx.se
2000-06-20 15:31:26 +00:00
Daniel Stenberg
435f17195e
removed lots of #if 0'ed code
...
removed the "mode" concept
moved all #-stuff to the client
2000-06-16 13:15:36 +00:00
Daniel Stenberg
6d522c9c1d
made getenv() more threadsafe for win32
2000-05-29 23:07:22 +00:00
Daniel Stenberg
96dde76b99
moved here from the newlib branch
2000-05-22 14:12:12 +00:00
Daniel Stenberg
eb856b04fe
Improved the looks of the progress meter when the file size is between
...
9999 KB and 100 MB since it then can display the size as XX.X MB instead of
just XX as before.
2000-04-08 19:28:23 +00:00
Daniel Stenberg
ff3fd842d8
Marco G. Salvagno's OS/2 fixes
2000-03-19 19:54:13 +00:00
Daniel Stenberg
5fb1d20ed9
added pgrsTime() to store various time stamps for the -w option
2000-03-01 21:59:59 +00:00
Daniel Stenberg
947a644d5a
moved a few more variables to the progress struct and I had some problems
...
on how to approach the -# progress bar in the new style transfers...
2000-02-21 23:50:27 +00:00
Daniel Stenberg
b4a47dda27
re-arranged the progress meter columns, made the hour-field two characters
...
wide and made the pgrsUpdate() make a final meter update so that the final
values actually are displayed last.
2000-02-16 00:00:27 +00:00
Daniel Stenberg
7413ee668f
all new progress stuff on the way in
2000-02-14 23:15:08 +00:00
Daniel Stenberg
ede7cf175e
assume 79 columns instead of 80 in case we don't know, to better work on
...
win32 systems
2000-01-31 22:19:17 +00:00
Daniel Stenberg
7c8bb5dfff
Made the progress bar cooler, with ideas from Björn Stenberg <bjorn@haxx.nu>
2000-01-16 18:52:53 +00:00
Daniel Stenberg
ae1912cb0d
Initial revision
1999-12-29 14:20:26 +00:00