Marcel Raad
10b7067eb7
examples: reduce variable scopes
...
Closes https://github.com/curl/curl/pull/3919
2019-05-22 10:06:21 +02:00
Marcel Raad
918987a844
http2-download: fix format specifier
...
Closes https://github.com/curl/curl/pull/3919
2019-05-22 10:06:17 +02:00
Daniel Stenberg
269f7df0ae
PolarSSL: deprecate support step 1. Removed from configure.
...
Also removed mentions from most docs.
Discussed: https://curl.haxx.se/mail/lib-2019-05/0045.html
Closes #3888
2019-05-22 10:00:56 +02:00
Daniel Stenberg
c9c4f7b547
configure/cmake: check for if_nametoindex()
...
- adds the check to cmake
- fixes the configure check to work for cross-compiled windows builds
Closes #3917
2019-05-22 09:49:19 +02:00
Daniel Stenberg
12e564ca20
parse_proxy: use the IPv6 zone id if given
...
If the proxy string is given as an IPv6 numerical address with a zone
id, make sure to use that for the connect to the proxy.
Reported-by: Edmond Yu
Fixes #3482
Closes #3918
2019-05-22 09:45:43 +02:00
Daniel Stenberg
885ce31401
RELEASE-NOTES: 7.65.0 release
2019-05-22 07:48:44 +02:00
Daniel Stenberg
adea6eddba
THANKS: from the 7.65.0 release-notes
2019-05-22 07:48:44 +02:00
Daniel Stenberg
8fba2d6a6b
url: convert the zone id from a IPv6 URL to correct scope id
...
Reported-by: GitYuanQu on github
Fixes #3902
Closes #3914
2019-05-21 18:58:45 +02:00
Daniel Stenberg
9406d93e77
configure: detect getsockname and getpeername on windows too
...
Made detection macros for these two functions in the same style as other
functions possibly in winsock in the hope this will work better to
detect these functions when cross-compiling for Windows.
Follow-up to e91e481612
Fixes #3913
Closes #3915
2019-05-21 13:42:25 +02:00
Marcel Raad
b069815a7a
examples: remove unused variables
...
Fixes Codacy/CppCheck warnings.
Closes
2019-05-21 09:47:03 +02:00
Daniel Gustafsson
528b284e4b
udpateconninfo: mark variable unused
...
When compiling without getpeername() or getsockname(), the sockfd
paramter to Curl_udpateconninfo() became unused after commit e91e481612
added ifdef guards.
Closes #3910
Fixes https://curl.haxx.se/dev/log.cgi?id=20190520172441-32196
Reviewed-by: Marcel Raad, Daniel Stenberg
2019-05-21 09:42:22 +02:00
Daniel Gustafsson
8986d3c6f4
ftp: move ftp_ccc in under featureflag
...
Commit e91e481612
moved ftp_ccc in under
the FTP featureflag in the UserDefined struct, but vtls callsites were
still using it unprotected.
Closes #3912
Fixes: https://curl.haxx.se/dev/log.cgi?id=20190520044705-29865
Reviewed-by: Daniel Stenberg, Marcel Raad
2019-05-21 09:38:11 +02:00
Daniel Stenberg
31b77c1877
curl: report error for "--no-" on non-boolean options
...
Reported-by: Olen Andoni
Fixes #3906
Closes #3907
2019-05-20 19:04:54 +02:00
Guy Poizat
0da8441298
mbedtls: enable use of EC keys
...
Closes #3892
2019-05-20 19:00:59 +02:00
Daniel Stenberg
8b038bcc95
lib1560: add tests for parsing URL with too long scheme
...
Ref: #3905
2019-05-20 15:27:07 +02:00
Omar Ramadan
c454d7f3f4
urlapi: increase supported scheme length to 40 bytes
...
The longest currently registered URI scheme at IANA is 36 bytes long.
Closes #3905
Closes #3900
2019-05-20 15:27:02 +02:00
Marcel Raad
10db3ef21e
lib: reduce variable scopes
...
Fixes Codacy/CppCheck warnings.
Closes https://github.com/curl/curl/pull/3872
2019-05-20 08:51:11 +02:00
Marcel Raad
27af2ec219
tool_formparse: remove redundant assignment
...
Just initialize word_begin with the correct value.
Closes https://github.com/curl/curl/pull/3873
2019-05-20 08:06:24 +02:00
Marcel Raad
320cec284d
ssh: move variable declaration to where it's used
...
This way, we need only one call to free.
Closes https://github.com/curl/curl/pull/3873
2019-05-20 08:06:22 +02:00
Marcel Raad
c92a4debd2
ssh-libssh: remove unused variable
...
sock was only used to be assigned to fd_read.
Closes https://github.com/curl/curl/pull/3873
2019-05-20 08:06:05 +02:00
Daniel Stenberg
f943347496
test332: verify the blksize fix
2019-05-20 07:59:11 +02:00
Daniel Stenberg
2576003415
tftp: use the current blksize for recvfrom()
...
bug: https://curl.haxx.se/docs/CVE-2019-5436.html
Reported-by: l00p3r on hackerone
CVE-2019-5436
2019-05-20 07:57:49 +02:00
Daniel Gustafsson
9a87fe704e
version: make ssl_version buffer match for multi_ssl
...
When running a multi TLS backend build the version string needs more
buffer space. Make the internal ssl_buffer stack buffer match the one
in Curl_multissl_version() to allow for the longer string. For single
TLS backend builds there is no use in extended to buffer. This is a
fallout from #3863 which fixes up the multi_ssl string generation to
avoid a buffer overflow when the buffer is too small.
Closes #3875
Reviewed-by: Daniel Stenberg <daniel@haxx.se>
2019-05-19 22:06:26 +02:00
Steve Holme
7ca7f82ba7
http_ntlm_wb: Handle auth for only a single request
...
Currently when the server responds with 401 on NTLM authenticated
connection (re-used) we consider it to have failed. However this is
legitimate and may happen when for example IIS is set configured to
'authPersistSingleRequest' or when the request goes thru a proxy (with
'via' header).
Implemented by imploying an additional state once a connection is
re-used to indicate that if we receive 401 we need to restart
authentication.
Missed in fe6049f0
.
2019-05-18 19:01:11 +01:00
Steve Holme
2697d63363
http_ntlm_wb: Cleanup handshake after clean NTLM failure
...
Missed in 50b87c4e
.
2019-05-18 19:01:10 +01:00
Steve Holme
bd21fc9d2f
http_ntlm_wb: Return the correct error on receiving an empty auth message
...
Missed in fe20826b
as it wasn't implemented in http.c in b4d6db83
.
Closes #3894
2019-05-18 19:00:51 +01:00
Daniel Stenberg
697b1f911b
curl: make code work with protocol-disabled libcurl
...
Closes #3844
2019-05-18 16:14:10 +02:00
Daniel Stenberg
e91e481612
libcurl: #ifdef away more code for disabled features/protocols
2019-05-17 23:24:34 +02:00
Daniel Stenberg
3b06e68b77
progress: CURL_DISABLE_PROGRESS_METER
2019-05-17 23:24:34 +02:00
Daniel Stenberg
3cfcdf08d8
hostip: CURL_DISABLE_SHUFFLE_DNS
2019-05-17 23:24:34 +02:00
Daniel Stenberg
1f8a584f6a
netrc: CURL_DISABLE_NETRC
2019-05-17 23:24:34 +02:00
Viktor Szakats
f3e0f071b1
docs: Markdown and misc improvements [ci skip]
...
Approved-by: Daniel Stenberg
Closes #3896
2019-05-16 22:11:27 +00:00
Viktor Szakats
196ae60402
docs/RELEASE-PROCEDURE: link to live iCalendar [ci skip]
...
Ref: 0af41b40b2 (commitcomment-33563135)
Approved-by: Daniel Stenberg
Closes #3895
2019-05-16 18:56:42 +00:00
Daniel Stenberg
eeb37d7191
travis: add an osx http-only build
...
Closes #3887
2019-05-16 15:32:42 +02:00
Daniel Stenberg
8ece8177f1
cleanup: remove FIXME and TODO comments
...
They serve very little purpose and mostly just add noise. Most of them
have been around for a very long time. I read them all before removing
or rephrasing them.
Ref: #3876
Closes #3883
2019-05-16 09:16:56 +02:00
Daniel Stenberg
f506ce099f
curl: don't set FTP options for FTP-disabled builds
...
... since libcurl has started to be totally unaware of options for
disabled protocols they now return error.
Bug: c9c5304dd4 (commitcomment-33533937)
Reported-by: Marcel Raad
Closes #3886
2019-05-16 08:11:37 +02:00
Steve Holme
fe20826b58
http_ntlm_wb: Move the type-2 message processing into a dedicated function
...
This brings the code inline with the other HTTP authentication mechanisms.
Closes #3890
2019-05-16 00:03:30 +01:00
Daniel Stenberg
ab4616f8cb
RELEASE-NOTES: synced
2019-05-15 14:35:00 +02:00
Daniel Stenberg
0af41b40b2
docs/RELEASE-PROCEDURE: updated coming releases dates [ci skip]
2019-05-15 13:56:19 +02:00
Daniel Stenberg
f778c356a8
CURLOPT_READFUNCTION.3: see also CURLOPT_UPLOAD_BUFFERSIZE [ci skip]
...
Reported-by: Roy Bellingan
Bug: #3885
2019-05-15 12:05:49 +02:00
Daniel Stenberg
ee68bbe29c
parse_proxy: use the URL parser API
...
As we treat a given proxy as a URL we should use the unified URL parser
to extract the parts out of it.
Closes #3878
2019-05-15 12:02:05 +02:00
Steve Holme
e832d1ef74
http_negotiate: Move the Negotiate state out of the negotiatedata structure
...
Given that this member variable is not used by the SASL based protocols
there is no need to have it here.
Closes #3882
2019-05-15 00:32:42 +01:00
Steve Holme
85bef18ca1
http_ntlm: Move the NTLM state out of the ntlmdata structure
...
Given that this member variable is not used by the SASL based protocols
there is no need to have it here.
2019-05-15 00:31:45 +01:00
Steve Holme
0c73adfad3
url: Move the negotiate state type into a dedicated enum
2019-05-15 00:31:35 +01:00
Steve Holme
be9fd703e0
url: Remove duplicate clean up of the winbind variables in conn_shutdown()
...
Given that Curl_disconnect() calls Curl_http_auth_cleanup_ntlm() prior
to calling conn_shutdown() and it in turn performs this, there is no
need to perform the same action in conn_shutdown().
Closes #3881
2019-05-14 14:35:11 +01:00
Daniel Stenberg
9f9ec7da57
urlapi: require a non-zero host name length when parsing URL
...
Updated test 1560 to verify.
Closes #3880
2019-05-14 13:39:10 +02:00
Daniel Stenberg
c60042fe09
configure: error out if OpenSSL wasn't detected when asked for
...
If --with-ssl is used and configure still couldn't enable SSL this
creates an error instead of just silently ignoring the fact.
Suggested-by: Isaiah Norton
Fixes #3824
Closes #3830
2019-05-14 13:19:47 +02:00
Daniel Gustafsson
bd91e7f340
imap: Fix typo in comment
2019-05-14 12:38:23 +02:00
Steve Holme
b5d1de8e21
url: Remove unnecessary initialisation from allocate_conn()
...
No need to set variables to zero as calloc() does this for us.
Closes #3879
2019-05-14 09:48:16 +01:00
Daniel Stenberg
6123d718aa
CURLOPT_CAINFO.3: with Schannel, you want Windows 8 or later [ci skip]
...
Clues-provided-by: Jay Satiro
Clues-provided-by: Jeroen Ooms
Fixes #3711
Closes #3874
2019-05-14 08:19:58 +02:00