Daniel Stenberg
0aedccc18a
curl_formget: fix FILE * leak
...
Properly deal with the fact that the last fread() call most probably is
a short read, and when using callbacks in fact all calls can be short
reads. No longer consider a file read done until it returns a 0 from the
read function.
Reported by: Aaron Orenstein
Bug: http://curl.haxx.se/mail/lib-2011-06/0048.html
2011-06-13 22:32:00 +02:00
Daniel Stenberg
85881f9f35
curl_formget: treat CURLFORM_STREAM better
...
If a piece is set to use a callback to get the data, it should not be
treated as data. It unfortunately also requires that curl_easy_perform()
or similar has been used as otherwise the callback function hasn't been
figured out and curl_formget won't know how to get the content.
2011-06-13 22:05:13 +02:00
Daniel Stenberg
ee015947d4
long/int mess
...
Typecast when converting to int from long to avoid some compiler warnings
2011-06-11 22:56:45 +02:00
Daniel Stenberg
c4dd8df081
splay: add unit tests
...
The test code that was #ifdef'ed in the code was converted into unit
tests in test case 1309. I also removed the #if 0'ed code from splay.c
2011-06-10 20:19:35 +02:00
Daniel Stenberg
0f7bea7c3a
unittest: mark all unit tested functions
...
With "@unittest: [num]" in the header comment for each tested function.
Shows we have a log way to go still...
2011-06-10 14:40:46 +02:00
Kamil Dudka
f551aa5c16
disconnect: wipe out the keeps_speed time stamp
...
When closing a connection, the speedchecker's timestamp is now deleted
so that it cannot accidentally be used by a fresh connection on the same
handle when examining the transfer speed.
Bug: https://bugzilla.redhat.com/679709
2011-06-08 00:23:41 +02:00
Yang Tse
377f88364e
urldata: use uniform inclusion style for OpenSSL headers
2011-06-07 18:35:42 +02:00
Daniel Stenberg
c0b9dd27b5
HTTP time condition: force closure for 200 OK
...
When a time condition isn't met, so that no body is delivered to the
application even though a 2xx response is being read from the server, we
must close the connection to avoid a re-use of the connection to be
completely tricked.
Added test 1128 to verify.
2011-06-07 13:40:11 +02:00
Daniel Stenberg
7559b77727
wait_ms: takes an int argument
...
Typecasts added since I changed more code to use long for timeouts
2011-06-05 12:06:50 +02:00
Daniel Stenberg
4f170ee8f9
Curl_socket_ready: make timeout a 'long'
...
It was mostly typecasted to int all over the code so switching to long
instead all over should be a net gain.
2011-06-04 21:19:14 +02:00
Daniel Stenberg
9776f3445d
cookie_output: made private
2011-06-03 20:02:07 +02:00
Daniel Stenberg
adeac15d8e
digest_cleanup_one: made private
2011-06-03 19:54:17 +02:00
Daniel Stenberg
5d4e5593d5
privatise: make private functions static
2011-06-03 19:51:08 +02:00
Daniel Stenberg
c2eb8c932d
Curl_fileinfo_dup: removed, not used
2011-06-03 19:33:23 +02:00
Daniel Stenberg
a6f14e17b7
parsedate: turn private and static
...
I removed the prefix as well accordingly.
2011-06-03 19:31:32 +02:00
Yang Tse
65a9fa59dc
Remove unnecessary typecast
2011-06-02 19:42:24 +02:00
Yang Tse
9eea43dce2
compiler warning: fix
...
Fix compiler warning: cast increases required alignment
2011-06-02 19:19:36 +02:00
Yang Tse
970117ef2d
OpenSSL enabled: require OPENSSL_VERSION_NUMBER definition before usage.
2011-06-02 12:52:52 +02:00
Yang Tse
aa76dec33a
unit tests: more build adjustments
2011-06-01 21:40:09 +02:00
Yang Tse
685359d4c3
makefile: avoid preprocessor definition usage when linking
2011-06-01 14:43:25 +02:00
Yang Tse
a689072f33
warnless: icc 9.1 workaround
2011-06-01 12:13:42 +02:00
Yang Tse
ecfe0b5b18
Makefile.am: fix spurious CFLAGS duplication
2011-05-30 22:34:06 +02:00
Yang Tse
7dd449d843
warnless: header inclusion fix
2011-05-27 06:56:56 +02:00
Yang Tse
f461c6e61d
Make checksrc.pl work on more out-of-tree builds
...
Source files given with relative paths do not have the
-D directory specifier prepended.
2011-05-26 19:17:10 +02:00
Yang Tse
3c9ff41a1f
compiler warning: fix
...
Fix compiler warning: conversion may lose significant bits
2011-05-26 15:44:53 +02:00
Yang Tse
c8c8816a97
socks: fix unaligned memory access
2011-05-26 14:53:13 +02:00
Daniel Stenberg
017ee34bba
create_conn: only switch protocol handler if necessary
...
When switching to HTTP because a HTTP proxy is being used, the existing
handler is now checked if it already is "compatible". This allows the https
handler remain while other non-http handlers will be redirected.
Bug: http://curl.haxx.se/mail/lib-2011-05/0214.html
Reported by: Jerome Robert
2011-05-25 15:57:38 +02:00
Yang Tse
a947a9ac62
compiler warning: fix followup
...
Fix compiler warning: variable was set but never used
Fix compiler warning: clobber ignored
2011-05-25 09:56:57 +02:00
Yang Tse
b735717606
compiler warning: fix
...
Fix compiler warning: variable was set but never used
Fix compiler warning: clobber ignored
2011-05-24 20:39:58 +02:00
Yang Tse
a41c7f9736
build: inclusion guard
...
Enclose header file in an inclusion guard
2011-05-24 15:42:02 +02:00
Yang Tse
512b2f7740
compiler warning: fix
...
Fix compiler warning: expression has no effect
2011-05-24 15:18:26 +02:00
Yang Tse
8bdc48eddb
compiler warning: fix
...
Fix compiler warning: `keycheck' might be used uninitialized in this function.
Fix compiler warning: `keybit' might be used uninitialized in this function.
2011-05-23 19:37:41 +02:00
Yang Tse
328600e02b
compiler warning: fix
...
Fix variable declaration placement
2011-05-23 19:04:49 +02:00
Yang Tse
e2747ebbc0
compiler warning: fix
...
Fix missing semicolon
2011-05-23 16:59:43 +02:00
Yang Tse
41ebda02b2
compiler warning: fix
...
Fix compiler warning: expression has no effect
Fix OOM handling
2011-05-23 16:55:49 +02:00
Yang Tse
30c9799f72
compiler warning: fix
...
Fix compiler warning: expression has no effect
2011-05-23 16:55:09 +02:00
Yang Tse
bed6b89a2f
compiler warning: fix
...
Fix compiler warning: unused variable 'data'
2011-05-23 12:57:23 +02:00
Yang Tse
3e70c28ce5
compiler warning: fix
...
Fix compiler warning: enumerated type mixed with another type
2011-05-21 15:06:50 +02:00
Yang Tse
79cc6c244a
compiler warning: fix
...
Fix compiler warning: enumerated type mixed with another type
2011-05-21 14:59:03 +02:00
Yang Tse
d30ddd9977
compiler warning: fix
...
Fix compiler warning: enumerated type mixed with another type
2011-05-21 14:55:10 +02:00
Yang Tse
fce7276f54
compiler warning: fix
...
Fix compiler warning: enumerated type mixed with another type
2011-05-21 14:10:17 +02:00
Yang Tse
004d84fcc1
compiler warning: fix
...
Fix compiler warning: empty body in an if-statement
2011-05-21 13:46:37 +02:00
Ola Mork
3912e7bde3
cyassl: build without filesystem
...
Get cyassl's NO_FILESYSTEM to work with libcurl. Otherwise I'd get linker
errors for the missing "SSL_CTX_load_verify_locations" functions.
2011-05-20 23:40:59 +02:00
Yang Tse
5db30a1d8c
version: linkage fix
...
Fix linkage on c-ares enabled Windows static builds
2011-05-19 11:50:20 +02:00
Daniel Stenberg
60f0ebbdc9
CLOSESOCKETFUNCTION: use the callback
...
Fix the return type of the callback to match close() and make use of it.
2011-05-18 22:56:46 +02:00
Daniel Stenberg
b5d170b551
CLOSESOCKETFUNCTION: added
...
Introduced the initial setup to allow closesocket callbacks by making
sure sclose() is only ever called from one place in the libcurl source
and still run all test cases fine.
2011-05-18 22:56:46 +02:00
Daniel Stenberg
d4e000906a
GnuTLS handshake: fix timeout
...
Commit cbf4961bf3
garbled the timeout handling while doing SSL
handshaking (in an attempt at fixing another bug). This puts sanity
back.
Bug: http://curl.haxx.se/mail/lib-2011-05/0167.html
Reported by: Ethan Glasser Camp
2011-05-18 20:48:42 +02:00
Daniel Stenberg
bb7ff942d3
checksrc: trailing whitespace detection fix
2011-05-16 15:21:32 +02:00
Marcel Roelofs
48a40f0402
negotiate sspi: fix sequential requests
2011-05-16 15:21:32 +02:00
Dan Fandrich
2a02c07a15
Fixed compilation when RTSP is disabled
2011-05-06 13:48:59 -07:00