e6b7dae947
imap: Added required mailbox check for FETCH and APPEND commands
2013-03-03 16:39:50 +00:00
fa637c6cab
pingpong.c: Fix enumerated type mixed with another type
2013-03-03 13:55:01 +00:00
036366f1ef
smtp: Updated the coding style for state changes after a send operation
...
Some state changes would be performed after a failure test that
performed a hard return, whilst others would be performed within a test
for success. Updated the code, for consistency, so all instances are
performed within a success test.
2013-03-03 13:48:22 +00:00
757aa7b09d
pop3: Updated the coding style for state changes after a send operation
...
Some state changes would be performed after a failure test that
performed a hard return, whilst others would be performed within a test
for success. Updated the code, for consistency, so all instances are
performed within a success test.
2013-03-03 13:36:12 +00:00
b1ebf4bda1
imap: Fixed typo in variable assignment
2013-03-03 13:13:59 +00:00
284ea5f924
imap: Fixed custom request handling in imap_done()
...
Fixed imap_done() so that neither the FINAL states are not entered when
a custom command has been performed.
2013-03-03 13:10:36 +00:00
c03cad3a61
imap: Enabled custom requests in imap_select_resp()
...
Changed imap_select_resp() to invoke imap_custom() instead of
imap_fetch() after the mailbox has been selected if a custom
command has been set.
2013-03-03 13:10:34 +00:00
ad8b76d094
imap: Enabled custom requests in imap_perform()
...
Modified imap_perform() to start with the custom command instead of
SELECT when a custom command is to be performed and no mailbox has
been given.
2013-03-03 13:10:32 +00:00
226c1c6876
imap: Added custom request perform and response handler functions
...
Added imap_custom(), which initiates the custom command processing,
and an associated response handler imap_state_custom_resp(), which
handles any responses by sending them to the client as body data.
All untagged responses with the same name as the first word of the
custom request string are accepted, with the exception of SELECT and
EXAMINE which have responses that cannot be easily identified. An
extra check has been provided for them so that any untagged responses
are accepted for them.
2013-03-03 13:10:31 +00:00
711065e4df
pop3: Fixed unnecessary parent structure reference
...
Updated pop3 code following recent imap changes.
2013-03-03 11:10:24 +00:00
ee7034800d
imap: Added custom request parsing
...
Added imap_parse_custom_request() for parsing the CURLOPT_CUSTOMREQUEST
parameter which URL decodes the value and separates the request from
any parameters - This makes it easier to filter untagged responses
by the request command.
2013-03-03 11:06:55 +00:00
1d3ccf27ec
imap: Introduced custom request parameters
...
Added custom request parameters to the per-request structure.
2013-03-03 11:03:45 +00:00
51dbaae432
imap: Introduced IMAP_CUSTOM state
2013-03-03 10:13:13 +00:00
dcffd936e1
imap: Minor code tidy up
...
Minor tidy up of code layout and comments following recent changes.
2013-03-02 21:22:44 +00:00
e94fbcabd7
imap: Simplified the imap_state_append_resp() function
...
Introduced the result code variable to simplify the state changes and
remove the hard returns.
2013-03-02 20:40:38 +00:00
ec38ac38c7
imap: Changed successful response logic in imap_state_append_resp()
...
For consistency changed the logic of the imap_state_append_resp()
function to test for an unsucessful continuation response rather than a
succesful one.
2013-03-02 20:35:03 +00:00
0f64dd086a
imap: Standardised imapcode condition tests
...
For consistency changed two if(constant != imapcode) tests to be
if(imapcode != constant).
2013-03-02 20:29:27 +00:00
459e1bffee
imap: Moved imap_append() to be with the other perform functions
2013-03-02 20:24:49 +00:00
7b471fb344
imap: Enabled APPEND support in imap_perform()
...
Added logic in imap_perform() to perform an APPEND rather than SELECT
and FETCH if an upload has been specified.
2013-03-02 20:17:45 +00:00
f8c8c76d39
imap: Implemented APPEND final processing
...
The APPEND operation needs to be performed in several steps:
1) We send "<tag> APPEND <mailbox> <flags> {<size>}\r\n"
2) Server responds with continuation respose "+ ...\r\n"
3) We start the transfer and send <size> bytes of data
4) Only now we end the request command line by sending "\r\n"
5) Server responds with "<tag> OK ...\r\n"
This commit performs steps 4 and 5, in the DONE phase, as more
processing is required after the transfer.
2013-03-02 19:34:25 +00:00
90b7d0ea59
imap: Added APPEND perform and response handler functions
...
Added imap_append() function to initiate upload and imap_append_resp()
to handle the continuation response and start the transfer.
2013-03-02 19:17:18 +00:00
1383522e3a
imap: Introduced IMAP_APPEND and IMAP_APPEND_FINAL states
2013-03-02 19:06:35 +00:00
d46d107e0c
imap: Updated setting of transfer variables in imap_state_fetch_resp()
...
Add number of bytes retrieved from the PP cache to req.bytecount and set
req.maxdownload only when starting a proper download.
2013-03-02 18:37:56 +00:00
25884aa197
imap: Improved FETCH response parsing
...
Added safer parsing of the untagged FETCH response line and the size of
continuation data.
2013-03-02 18:37:54 +00:00
be51a46353
imap: Fixed accidentally lossing the result code
...
Accidentally lost the result code in imap_state_capability() and
imap_state_login() with commit b06a786226
2013-02-28 23:09:28 +00:00
48596f87a9
imap: Another minor comment addition / tidy up
2013-02-28 22:51:32 +00:00
b06a786226
imap: Updated the coding style for state changes after a send operation
...
Some state changes would be performed after a failure test that
performed a hard return, whilst others would be performed within a test
for success. Updated the code, for consistency, so all instances are
performed within a success test.
2013-02-28 22:46:22 +00:00
b4eb08e7fb
pop3 / smtp: Small comment tidy up
...
Small tidy up to keep some comments consistant across each of the email
protocols.
2013-02-28 22:27:10 +00:00
10549ee08f
imap: FETCH response handler cleanup before further changes
...
Removed superfluous NULL assignment after Curl_safefree() and rewrote
some comments and logging messages.
2013-02-28 22:13:34 +00:00
d9235e74ed
pop3: Small tidy up of function arguments
2013-02-28 21:22:49 +00:00
6ff7197e70
imap: Small tidy up of function arguments
2013-02-28 21:18:36 +00:00
0be2251394
smtp: Corrected debug message for POP3_AUTH_FINAL constant
...
Following commit ad3177da24
2013-02-28 21:11:02 +00:00
4cef525992
pop3: Corrected debug message for POP3_AUTH_FINAL constant
...
Following commit afad1ce753
2013-02-28 21:10:11 +00:00
11a22f3264
imap: Corrected debug message for IMAP_AUTHENTICATE_FINAL constant
...
Following commit 13006f3de9
2013-02-28 21:09:27 +00:00
025ba6e9be
imap: Fixed error code returned for invalid FETCH response
...
If the FETCH command does not result in an untagged response the the
UID is probably invalid. As such do not return CURLE_OK.
2013-02-28 21:00:13 +00:00
cdea86ff67
imap: Added processing of the final FETCH responses
...
Not processing the final FETCH responses was not optimal, not only
because the response code would be ignored but it would also leave data
unread on the socket which would prohibit connection reuse.
2013-02-28 21:00:11 +00:00
974c663471
imap: Introduced FETCH_FINAL state for processing final fetch responses
...
A typical FETCH response can be broken down into four parts:
1) "* <uid> FETCH (<what> {<size>}\r\n", using continuation syntax
2) <size> bytes of the actual message
3) ")\r\n", finishing the untagged response
4) "<tag> OK ...", finishing the command
Part 1 is read in imap_fetch_resp(), part 2 is consumed in the PERFORM
phase by the transfer subsystem, parts 3 and 4 are currently ignored.
2013-02-28 21:00:10 +00:00
692ef0e158
imap: fix autobuild warning
...
Removed whitespace from imap_perform()
2013-02-28 10:23:50 +00:00
17f032c0d9
imap: fix compiler warning
...
error: declaration of 'imap' shadows a previous local
2013-02-28 07:31:41 +00:00
ad3177da24
smtp: Re-factored the final SMTP_AUTH constant
...
Changed the final SMTP_AUTH constant to SMTP_AUTH_FINAL for consistency
with the response function.
2013-02-27 21:20:55 +00:00
afad1ce753
pop3: Re-factored the final POP3_AUTH constant
...
Changed the final POP3_AUTH constant to POP3_AUTH_FINAL for consistency
with the response function.
2013-02-27 21:20:11 +00:00
13006f3de9
imap: Re-factored final IMAP_AUTHENTICATE constant
...
Changed the final IMAP_AUTHENTICATE constant to IMAP_AUTHENTICATE_FINAL
for consistency with the response function.
2013-02-27 21:19:48 +00:00
1d86d813c3
imap: Updated the coding style of imap_state_servergreet_resp()
...
Updated the coding style, in this function, to be consistant with other
response functions rather then performing a hard return on failure.
2013-02-27 21:00:35 +00:00
f53ed631b3
imap: Reversed the logic of the (un)successful tagged SELECT response
...
Reversed the logic of the unsuccessful vs successful tagged SELECT
response in imap_state_select_resp() to be more logical to read.
2013-02-27 20:53:34 +00:00
5b3736b533
imap: Reversed the logic of the (un)successful tagged CAPABILITY response
...
Reversed the logic of the unsuccessful vs successful tagged CAPABILITY
response in imap_state_capability_resp() to be more logical to read.
2013-02-27 20:48:24 +00:00
cce08581ac
imap: Corrected char* references with char *
...
Corrected char* references made in commit: 709b3506cd
2013-02-27 20:35:04 +00:00
c368fbcb10
imap: Added processing of more than one response when sent in same packet
...
Added a loop to imap_statemach_act() in which Curl_pp_readresp() is
called until the cache is drained. Without this multiple responses
received in a single packet could result in a hang or delay.
2013-02-27 20:08:04 +00:00
b644c47192
imap: Added skipping of SELECT command if already in the same mailbox
...
Added storage and checking of the last mailbox userd to prevent
unnecessary switching.
2013-02-27 20:08:02 +00:00
d03aa16164
imap: Introduced the mailbox variable
...
Added the mailbox variable to the per-connection structure in
preparation for checking for an already selected mailbox.
2013-02-27 20:08:00 +00:00
aa44ec62aa
email: Slight reordering of connection based variables
...
Reordered the state and ssl_done variables in order to provide more
consistency between the email protocols as well as for for an upcoming
change.
2013-02-26 23:15:16 +00:00
Jiri Hruska