Daniel Stenberg
8c0807aa16
create_conn: prefer multiplexing to using new connections
...
... as it would previously prefer new connections rather than
multiplexing in most conditions! The (now removed) code was a leftover
from the Pipelining code that was translated wrongly into a
multiplex-only world.
Reported-by: Kunal Ekawde
Bug: https://curl.haxx.se/mail/lib-2019-12/0060.html
Closes #4732
2019-12-19 09:00:56 +01:00
Daniel Stenberg
fba8301338
test1456: remove the use of a fixed local port
...
Fixup the test to instead not compare the port number. It sometimes
caused problems like this:
"curl: (45) bind failed with errno 98: Address already in use"
Closes #4733
2019-12-19 08:59:10 +01:00
Jay Satiro
c1592cc92b
CURLOPT_QUOTE.3: fix typos
...
Prior to this change the EXAMPLE in the QUOTE/PREQUOTE/POSTQUOTE man
pages would not compile because a variable name was incorrect.
Reported-by: Bylon2@users.noreply.github.com
Fixes https://github.com/curl/curl/issues/4736
2019-12-18 15:21:58 -05:00
Gisle Vanem
ac7b1fb10c
strerror: Fix compiler warning "empty expression"
...
- Remove the final semi-colon in the SEC2TXT() macro definition.
Before: #define SEC2TXT(sec) case sec: txt = #sec; break;
After: #define SEC2TXT(sec) case sec: txt = #sec; break
Prior to this change SEC2TXT(foo); would generate break;; which caused
the empty expression warning.
Ref: https://github.com/curl/curl/commit/5b22e1a#r36458547
2019-12-18 14:10:23 -05:00
Daniel Stenberg
23e4d98e7e
curl/parseconfig: use curl_free() to free memory allocated by libcurl
...
Reported-by: bxac on github
Fixes #4730
Closes #4731
2019-12-18 14:48:41 +01:00
Daniel Stenberg
f098c9e6f6
curl/parseconfig: fix mem-leak
...
When looping, first trying '.curlrc' and then '_curlrc', the function
would not free the first string.
Closes #4731
2019-12-18 14:48:32 +01:00
Daniel Stenberg
14f8b6e69e
CURLOPT_URL.3: "curl supports SMB version 1 (only)"
...
[skip ci]
2019-12-18 10:14:18 +01:00
Daniel Stenberg
9973dabeb6
test1270: a basic -w redirect_url test
...
Closes #4728
2019-12-18 08:26:03 +01:00
Daniel Stenberg
4ec4787a10
HISTORY: the SMB(S) support landed in 2014
2019-12-18 08:25:51 +01:00
Daniel Stenberg
0caf1423e5
define: remove HAVE_ENGINE_LOAD_BUILTIN_ENGINES, not used anymore
...
It is covered by USE_OPENSSL_ENGINE now.
Reported-by: Gisle Vanem
Bug: 87b9337c8f (commitcomment-36447951)
Closes #4725
2019-12-17 07:58:46 +01:00
Daniel Stenberg
bdb5b6dd5b
lib: remove ASSIGNWITHINCONDITION exceptions, use our code style
...
... even for macros
Reviewed-by: Daniel Gustafsson
Reviewed-by: Jay Satiro
Reported-by: Jay Satiro
Fixes #4683
Closes #4722
2019-12-17 07:36:11 +01:00
Daniel Stenberg
7282093458
tests: make sure checksrc runs on header files too
2019-12-16 22:46:48 +01:00
Daniel Stenberg
31e637d224
Revert "checksrc: fix regexp for ASSIGNWITHINCONDITION"
...
This reverts commit ba82673dac
.
Bug: #4683
2019-12-16 22:46:35 +01:00
Daniel Stenberg
3ab45a9876
KNOWN_BUGS: TLS session cache doesn't work with TFO
...
[skip ci]
Closes #4301
2019-12-16 16:20:16 +01:00
Daniel Stenberg
8a9d6eeb32
KNOWN_BUGS: Connection information when using TCP Fast Open
...
Also point to #4296 for more details
Closes #4296
2019-12-16 16:17:16 +01:00
Daniel Stenberg
73ca946753
KNOWN_BUGS: LDAP on Windows doesn't work
...
Closes #4261
2019-12-16 16:15:39 +01:00
Daniel Stenberg
4147d58aee
docs: TLS SRP doesn't work with TLS 1.3
...
Reported-by: sayrer on github
Closes #4262
[skip ci]
2019-12-16 16:03:22 +01:00
Dan Fandrich
35f908072c
cirrus: Switch to the FreeBSD 12.1 point release & enable more tests.
...
A few tests are now passing on FreeBSD, so no longer skip them.
[skip ci]
2019-12-16 13:30:53 +01:00
Daniel Stenberg
5eda54c0f0
azure: the macos cmake doesn't need to install cmake
...
Error: cmake 3.15.5 is already installed
To upgrade to 3.16.1, run `brew upgrade cmake`.
Closes #4723
2019-12-16 10:11:49 +01:00
Jay Satiro
b0a9e3c28c
winbuild: Document CURL_STATICLIB requirement for static libcurl
...
A static libcurl (ie winbuild mode=static) requires that the user define
CURL_STATICLIB when using it in their application. This is already
covered in the FAQ and INSTALL.md, but is a pretty important point so
now it's noted in the BUILD.WINDOWS.txt as well.
Assisted-by: Michael Vittiglio
Closes https://github.com/curl/curl/pull/4721
2019-12-15 17:31:23 -05:00
Santino Keupp
1d2d3feb21
libssh2: add support for ECDSA and ed25519 knownhost keys
...
... if a new enough libssh2 version is present.
Source: https://curl.haxx.se/mail/archive-2019-12/0023.html
Co-Authored-by: Daniel Stenberg
Closes #4714
2019-12-15 23:03:39 +01:00
Daniel Stenberg
38797e8811
lib1591: free memory properly on OOM, in the trailers callback
...
Detected by torture tests.
Closes #4720
2019-12-15 18:19:01 +01:00
Daniel Stenberg
571f2c81d1
runtests: --repeat=[num] to repeat tests
...
Closes #4715
2019-12-15 11:54:45 +01:00
Daniel Stenberg
024981cd1e
RELEASE-NOTES: synced
2019-12-15 00:37:52 +01:00
Daniel Stenberg
69ed88f474
azure: add a torture test on mac
...
Uses --shallow=25 to keep it small enough to get through in time.
Closes #4712
2019-12-14 23:34:44 +01:00
Daniel Stenberg
29ca9fc596
multi: free sockhash on OOM
...
This would otherwise leak memory in the error path.
Detected by torture test 1540.
Closes #4713
2019-12-13 22:46:46 +01:00
Marcel Raad
38ad9ea1b8
tests: use DoH feature for DoH tests
...
Previously, http/2 was used instead.
Assisted-by: Jay Satiro
Closes https://github.com/curl/curl/pull/4692
2019-12-13 20:55:52 +01:00
Marcel Raad
4457e08a7a
hostip: suppress compiler warning
...
With `--disable-doh --disable-threaded-resolver`, the `dns` parameter
is not used.
Closes https://github.com/curl/curl/pull/4692
2019-12-13 20:55:51 +01:00
Marcel Raad
9f239811fd
tests: fix build with CURL_DISABLE_DOH
...
Closes https://github.com/curl/curl/pull/4692
2019-12-13 20:55:50 +01:00
Daniel Stenberg
ec3758b95f
azure: add a torture test
...
Skipping all FTP tests for speed reasons.
Closes #4697
2019-12-13 14:50:39 +01:00
Daniel Stenberg
1fb2a48752
azure: make the default build use --enable-debug --enable-werror
2019-12-13 13:01:32 +01:00
Daniel Stenberg
68ffe6c17d
ntlm_wb: fix double-free in OOM
...
Detected by torture testing test 1310
Closes #4710
2019-12-13 13:01:01 +01:00
Dan Fandrich
86f9c67629
cirrus: Drop the FreeBSD 10.4 build
...
Upstream support for 10.4 ended a year ago, and it looks like the image
is now gone, too.
[skip ci]
2019-12-13 09:23:37 +01:00
Daniel Stenberg
d00aa703f4
unit1620: fix bad free in OOM
...
Closes #4709
2019-12-13 08:16:35 +01:00
Daniel Stenberg
5ada900458
unit1609: fix mem-leak in OOM
...
Closes #4709
2019-12-13 08:16:32 +01:00
Daniel Stenberg
f389953da0
unit1607: fix mem-leak in OOM
...
Closes #4709
2019-12-13 08:16:29 +01:00
Daniel Stenberg
197d8aaf6d
lib1559: fix mem-leak in OOM
...
Closes #4709
2019-12-13 08:16:24 +01:00
Daniel Stenberg
6a15d1d4e5
lib1557: fix mem-leak in OOM
...
Closes #4709
2019-12-13 08:16:06 +01:00
Daniel Stenberg
5dc56eb95d
altsvc: make the save function ignore NULL filenames
...
It might happen in OOM situations. Detected bv torture tests.
Closes #4707
2019-12-12 14:10:09 +01:00
Daniel Stenberg
70a6541515
curl: fix memory leak in OOM in etags logic
...
Detected by torture tests
Closes #4706
2019-12-12 11:03:55 +01:00
Daniel Stenberg
4940bb8568
doh: make it behave when built without proxy support
...
Reported-by: Marcel Raad
Bug: https://github.com/curl/curl/pull/4692#issuecomment-564115734
Closes #4704
2019-12-12 09:26:08 +01:00
Daniel Stenberg
dc4900eea7
curl: improved cleanup in upload error path
...
Memory leak found by torture test 58
Closes #4705
2019-12-12 09:23:45 +01:00
Daniel Stenberg
5a1b0f4c5b
mailmap: fix Andrew Ishchuk
2019-12-11 09:59:32 +01:00
Daniel Stenberg
e66d5fa785
travis: make torture use --shallow=40
...
As a first step to enable it to run over a more diverse set of tests in
a reasonable time.
2019-12-11 09:55:22 +01:00
Daniel Stenberg
7c1bd03576
runtests: introduce --shallow to reduce huge torture tests
...
When set, shallow mode limits runtests -t to make no more than NUM fails
per test case. If more are found, it will randomly discard entries until
the number is right. The random seed can also be set.
This is particularly useful when running MANY tests as then most torture
failures will already fail the same functions over and over and make the
total operation painfully tedious.
Closes #4699
2019-12-11 09:55:15 +01:00
Daniel Stenberg
1d5c427d7f
conncache: CONNECT_ONLY connections assumed always in-use
...
This makes them never to be considered "the oldest" to be discarded when
reaching the connection cache limit. The reasoning here is that
CONNECT_ONLY is primarily used in combination with using the
connection's socket post connect and since that is used outside of
curl's knowledge we must assume that it is in use until explicitly
closed.
Reported-by: Pavel Pavlov
Reported-by: Pavel Löbl
Fixes #4426
Fixes #4369
Closes #4696
2019-12-11 09:25:56 +01:00
Gisle Vanem
2c0362ee04
vtls: make BearSSL possible to set with CURL_SSL_BACKEND
...
Ref: 9b879160df (commitcomment-36355622)
Closes #4698
2019-12-10 15:35:23 +01:00
Daniel Stenberg
de68a70166
RELEASE-NOTES: synced
2019-12-10 14:56:55 +01:00
Daniel Stenberg
83c0e96057
travis: remove "coverage", make it "torture"
...
The coveralls service and test coverage numbers are just too unreliable.
Removed badge from README.md as well.
Fixes #4694
Closes #4695
2019-12-10 13:39:29 +01:00
Daniel Stenberg
275e02bdea
azure: add libssh2 and cmake macos builds
...
Removed the macos libssh2 build from travis
Closes #4686
2019-12-10 12:34:46 +01:00