Daniel Stenberg
0fc73d364e
CODE_STYLE: Space around operators
...
As just discussed on the mailing list, also document how we prefer
spacing in expressions.
2016-03-14 14:31:14 +01:00
Daniel Stenberg
4ef6d6b1bc
curl: glob_range: no need to check unsigned variable for negative
...
cppcheck warned:
[src/tool_urlglob.c:283]: (style) Checking if unsigned variable 'step_n'
is less than zero.
2016-03-14 10:51:25 +01:00
Daniel Stenberg
2ad3cf2fba
CODE_STYLE: add example for indent style as well
2016-03-14 10:40:02 +01:00
Daniel Stenberg
c5c7a3e40f
CODE_STYLE: mention braces for functions too
2016-03-14 10:36:51 +01:00
Daniel Stenberg
519835c4b0
docs/Makefile.am: include CODE_STYLE in tarball too
2016-03-14 10:31:36 +01:00
Daniel Stenberg
1b3d736ae3
CONTRIBUTE: moved out code style to a separate document
2016-03-14 10:31:00 +01:00
Daniel Stenberg
303bf719ff
CODE_STYLE: initial version
...
Ripped out from CONTRIBUTE into its own document, but also extended from
there.
2016-03-14 10:28:54 +01:00
Daniel Stenberg
3c6238b3eb
curl_sasl.c: minor code indent fixes
2016-03-14 09:55:38 +01:00
Daniel Stenberg
c3aca6ed47
multi: simplified singlesocket
...
Since sh_getentry() now checks for invalid sockets itself and by
narrowing the scope of the remove_sock_from_hash variable.
2016-03-14 09:44:14 +01:00
Daniel Stenberg
8eaf884417
multi: introduce sh_getentry() for looking up sockets in the sockhash
...
Simplify the code by using a single entry that looks for a socket in the
socket hash. As indicated in #712 , the code looked for CURL_SOCKET_BAD
at some point and that is ineffective/wrong and this makes it easier to
avoid that.
2016-03-14 09:18:01 +01:00
Jaime Fullaondo
c0717a7059
multi hash: ensure modulo performed on curl_socket_t
...
Closes #712
2016-03-14 08:16:52 +01:00
Steve Holme
5dc43b975b
base64: Minor coding standard and style updates
2016-03-13 17:59:06 +00:00
Steve Holme
0e16de870f
base64: Use 'CURLcode result' for curl result codes
2016-03-13 17:14:57 +00:00
Steve Holme
9eb158821f
negotiate: Use 'CURLcode result' for curl result codes
2016-03-13 17:09:58 +00:00
Maksim Kuzevanov
d7e3942814
multi_runsingle: avoid loop in CURLM_STATE_WAITPROXYCONNECT
...
Closes #703
2016-03-13 12:41:17 +01:00
Daniel Stenberg
d807fbd66d
TODO: Use the RFC6265 test suite
2016-03-13 11:02:06 +01:00
Steve Holme
a8c7f0fcbf
checksrc.bat: Added the ability to scan src and lib source independently
2016-03-13 01:01:33 +00:00
Steve Holme
e4a0a9ef18
digest: Use boolean based success code for Curl_sasl_digest_get_pair()
...
Rather than use a 0 and 1 integer base result code use a TRUE / FALSE
based success code.
2016-03-12 17:25:15 +00:00
Steve Holme
a7a653fd58
digest: Corrected some typos in comments
2016-03-12 13:20:03 +00:00
Steve Holme
f0fbd099b4
krb5: Corrected some typos in function descriptions
2016-03-12 11:59:52 +00:00
Steve Holme
dbb90e7e9f
ntlm: Corrected some typos in function descriptions
2016-03-12 11:56:10 +00:00
Steve Holme
06ccaa0c68
url: Corrected indentation when calling idna_to_ascii_lz()
2016-03-11 07:46:09 +00:00
Steve Holme
58e4a06743
idn_win32: Use boolean based success codes
...
Rather than use 0 and 1 integer base result codes use a FALSE / TRUE
based success code.
2016-03-11 07:24:39 +00:00
Daniel Stenberg
b084173989
idn_win32.c: warning: Trailing whitespace
2016-03-10 23:32:45 +01:00
Steve Holme
28477fd67a
idn_win32.c: Fixed compilation warning from commit 9e7fcd4291
...
warning C4267: 'function': conversion from 'size_t' to 'int',
possible loss of data
2016-03-10 21:52:09 +00:00
Daniel Stenberg
eab769518e
THANKS-filter: unify Michael König
2016-03-10 14:10:05 +01:00
Daniel Stenberg
53e2ca6896
RELEASE-NOTES: synced with 863c5766dd
2016-03-10 14:09:44 +01:00
Daniel Stenberg
863c5766dd
ftp: remove a check for NULL(!)
...
... as it implies we need to check for that on all the other variable
references as well (as Coverity otherwise warns us for missing NULL
checks), and we're alredy making sure that the pointer is never NULL.
2016-03-10 13:52:22 +01:00
Daniel Stenberg
7f7fcd0d75
cookies: first n/v pair in Set-Cookie: is the cookie, then parameters
...
RFC 6265 section 4.1.1 spells out that the first name/value pair in the
header is the actual cookie name and content, while the following are
the parameters.
libcurl previously had a more liberal approach which causes significant
problems when introducing new cookie parameters, like the suggested new
cookie priority draft.
The previous logic read all n/v pairs from left-to-right and the first
name used that wassn't a known parameter name would be used as the
cookie name, thus accepting "Set-Cookie: Max-Age=2; person=daniel" to be
a cookie named 'person' while an RFC 6265 compliant parser should
consider that to be a cookie named 'Max-Age' with an (unknown) parameter
'person'.
Fixes #709
2016-03-10 11:26:12 +01:00
Daniel Stenberg
4d4ce84bb3
krb5: improved type handling to avoid clang compiler warnings
2016-03-10 10:40:10 +01:00
Daniel Stenberg
549b1a433a
url.c: fix clang warning: no newline at end of file
2016-03-10 09:36:49 +01:00
Daniel Stenberg
77e1726719
curl_multi_wait: never return -1 in 'numfds'
...
Such a return value isn't documented but could still happen, and the
curl tool code checks for it. It would happen when the underlying
Curl_poll() function returns an error. Starting now we mask that error
as a user of curl_multi_wait() would have no way to handle it anyway.
Reported-by: Jay Satiro
Closes #707
2016-03-10 08:17:25 +01:00
Daniel Stenberg
b6665c7a44
HTTP2.md: add CURL_HTTP_VERSION_2TLS and updated alt-svc link
2016-03-09 11:09:39 +01:00
Daniel Stenberg
b7f3fe125a
curl_multi_wait.3: add example
2016-03-09 08:35:17 +01:00
Steve Holme
a5aec58726
imap/pop3/smtp: Fixed connections upgraded with TLS are not reused
...
Regression since commit 710f14edba
.
Bug: https://github.com/curl/curl/issues/422
Reported-by: Justin Ehlert
2016-03-08 19:36:46 +00:00
Jay Satiro
307f3cf3b3
opt-docs: fix heading macros
...
..SH should be .SH
Bug: https://github.com/curl/curl/issues/705
Reported-by: Eric S. Raymond
2016-03-08 13:23:35 -05:00
Tim Rühsen
c140bd7891
cookie: do not refuse cookies for localhost
...
Closes #658
2016-03-08 15:27:43 +01:00
Daniel Stenberg
cb222bcfef
ftp_done: clear tunnel_state when secondary socket closes
...
Introducing a function for closing the secondary connection to make this
bug less likely to happen again.
Reported-by: daboul
Closes #701
2016-03-08 15:00:53 +01:00
Gisle Vanem
a7ec58a89f
openssl: use the correct OpenSSL/BoringSSL/LibreSSL in messages
2016-03-08 14:19:01 +01:00
Daniel Stenberg
f0a6929553
HTTP2.md: HTTP/2 by default for curl's HTTPS connections
2016-03-08 08:15:47 +01:00
Anders Bakken
46bf7ff78d
pipeline: Sanity check pipeline pointer before accessing it.
...
I got a crash with this stack:
curl/lib/url.c:2873 (Curl_removeHandleFromPipeline)
curl/lib/url.c:2919 (Curl_getoff_all_pipelines)
curl/lib/multi.c:561 (curl_multi_remove_handle)
curl/lib/url.c:415 (Curl_close)
curl/lib/easy.c:859 (curl_easy_cleanup)
Closes #704
2016-03-08 00:25:53 +01:00
Daniel Stenberg
7e8b65c00b
HTTP2.md: mention the disable ALPN and NPN options
2016-03-08 00:08:31 +01:00
Daniel Stenberg
52a0b934ef
TODO: 17.12 keep running, read instructions from pipe/socket
...
And delete trailing whitespace
And rename section 17 to "command line tool" from "client"
Closes #702
2016-03-07 23:21:50 +01:00
Daniel Stenberg
d42dbe6423
README.md: linkified
...
It also makes it less readable as plain text, so let's keep this
primarily for github use.
Removed the top ascii art logo, as it looks weird when markdownified.
2016-03-07 11:09:56 +01:00
Daniel Stenberg
01ccac8773
README.md: markdown version of README
...
Attempt to make it look more appealing on github
2016-03-07 11:03:55 +01:00
Jay Satiro
1e58922f1e
mprintf: update trio project link
2016-03-06 22:57:47 -05:00
Daniel Stenberg
b90f9fa5ee
CURLOPT_ACCEPTTIMEOUT_MS.3: added example
2016-03-06 23:33:18 +01:00
Daniel Stenberg
4da5e65dee
CURLOPT_ACCEPT_ENCODING.3: added example
2016-03-06 23:30:42 +01:00
Daniel Stenberg
c13a54a2fb
CURLOPT_APPEND.3: added example
2016-03-06 23:28:35 +01:00
Daniel Stenberg
4ce153c62c
CURLOPT_NOPROGRESS.3: added example, conform to stardard style
2016-03-06 23:14:23 +01:00