Daniel Stenberg
371a25eee9
When curl_easy_duphandle() fails because it can't get or make a connection
...
cache, we must make sure not to derefence the NULL pointer...
CID 6 coverity.com scan
2007-03-31 11:28:03 +00:00
Daniel Stenberg
e535a71c71
The info types cannot be checked for explicity by ANDing the types since they
...
have not been properly defined to allow this! Instead of changing the defines
and break the ABI/API, I opted to modify the code to check for exact type
matches.
CID 10 coverity.com scan
2007-03-31 11:12:28 +00:00
Daniel Stenberg
b9e5fecf5f
Check for a NULL easy->easy_conn in multi_getsock() since it can in fact
...
happen when curl_multi_remove_handle() is called.
CID 13. coverity.com scan
2007-03-31 10:56:07 +00:00
Daniel Stenberg
3af08472ad
Removed check for ftpcode being NULL, as later it is derefenced unconditionally
...
anyway and we can just as well rely on it being valid.
CID 12, coverity.com scan
2007-03-31 10:39:54 +00:00
Daniel Stenberg
75db459f0a
Pointer "conn" dereferenced before NULL check. found by coverity.com scan
2007-03-30 20:54:32 +00:00
Daniel Stenberg
74e54c5a49
Pointer "cur_pos" dereferenced before NULL check, found by coverity.com scan.
...
Removed the NULL check since the pointer must be valid already.
2007-03-30 20:52:42 +00:00
Daniel Stenberg
3dcc7202d5
dead code removed, found by the coverity.com scan
2007-03-30 19:59:15 +00:00
Dan Fandrich
ffb11ad5c6
Don't tear down the ftp connection if the maximum filesize was exceeded
...
and added tests 290 and 291 to check.
2007-03-30 01:13:47 +00:00
Dan Fandrich
7763bb9172
Send an EOF message before closing a channel, as recommended by RFC4254.
...
Enable libssh2 tracing when ssh debugging is turned on.
2007-03-29 19:17:18 +00:00
Yang Tse
a1e5c621c0
fix compiler warning
2007-03-29 12:29:32 +00:00
Yang Tse
3d5a8515a6
fix error introduced in last commit
2007-03-29 00:11:55 +00:00
Yang Tse
bfa0f8c6c2
fix compiler warning
2007-03-28 19:05:43 +00:00
Yang Tse
869d192ffc
Improve detection of socket events which allow a further recv() call
...
to complete with no delay and actually find out what happened with
the socket. As well as detection of socket send()able condition.
This also allows removal of a Cygwin specific block of code.
2007-03-28 18:59:42 +00:00
Gisle Vanem
60bc103a78
djgpp uses gcc which has varadic macros.
2007-03-28 04:48:11 +00:00
Gisle Vanem
8a0a7ce3a8
Fix compiler warning.
2007-03-28 04:44:14 +00:00
Gisle Vanem
25c064c888
Simplified code around 'tld_errmsg' a bit.
2007-03-28 04:23:33 +00:00
Gunter Knauf
45b2577974
added variadic macro stuff.
2007-03-27 19:27:43 +00:00
Yang Tse
d58c7a8bdd
Update message
2007-03-27 18:16:35 +00:00
Yang Tse
eed47311f8
New Internal wrapper function Curl_select() around select (2), it
...
uses poll() when a fine poll() is available, so now libcurl can be
built without select() support at all if a fine poll() is available.
2007-03-27 18:15:26 +00:00
Yang Tse
59eaae42b8
don't retry select() call upon unrecoverable error EBADF
2007-03-27 15:22:49 +00:00
Yang Tse
4294cac701
Platforms that lack autotools support should define HAVE_VARIADIC_MACROS_C99
...
and/or HAVE_VARIADIC_MACROS_GCC for specific compiler versions that support
variadic macros with C99 style and/or old gcc style in their specific config.h
file.
If previous definitions are not done, even when aplicable, and --disable-verbose
is used, the fallback (void) method will be used to define infof, avoiding the
inclusion of unwanted strings in the resulting library/executable.
2007-03-27 04:17:26 +00:00
Yang Tse
fba4cd0e62
Internal function Curl_select() renamed to Curl_socket_ready()
2007-03-26 23:23:46 +00:00
Gunter Knauf
8272abef28
changed link lib order to make nlmconv happy.
2007-03-26 17:01:35 +00:00
Gunter Knauf
5fbc93c3eb
added CVS Id tag.
2007-03-26 01:54:06 +00:00
Gunter Knauf
8851df41c5
fixed build to use compiler-default lib extension.
2007-03-26 01:50:44 +00:00
Daniel Stenberg
6c56b5301f
- Daniel Johnson fixed multi code to traverse the easy handle list properly.
...
A left-over bug from the February 21 fix.
2007-03-25 08:16:16 +00:00
Yang Tse
fa0780bb91
fix compiler warning
2007-03-25 03:20:17 +00:00
Yang Tse
f08ac86834
fix compiler warning
2007-03-25 02:30:58 +00:00
Yang Tse
d6eca89229
fix compiler warning
2007-03-25 01:59:52 +00:00
Dan Fandrich
2bd1d7e996
Fixed a couple of compile problems.
2007-03-24 17:23:01 +00:00
Dan Fandrich
0dd1219668
Fixed a memory leak when specifying a proxy with a file: URL and added
...
test case 288 to verify it.
2007-03-24 02:15:20 +00:00
Daniel Stenberg
3d528e1b15
add missing state name for the debug state switch output
2007-03-23 22:25:04 +00:00
Daniel Stenberg
f9a339a225
fix debug message
2007-03-23 22:24:33 +00:00
Dan Fandrich
0043e87014
Added --pubkey option to curl and made --key also work for SCP/SFTP,
...
plus made --pass work on an SSH private key as well.
2007-03-23 17:59:40 +00:00
Yang Tse
0f634a0c89
fix yet another leftover in previous commit
2007-03-23 12:13:08 +00:00
Yang Tse
047cd1a533
fix leftover in previous commit
2007-03-23 12:09:16 +00:00
Yang Tse
f9eb61e90a
fix compiler warning: empty body in an if/else-statement
2007-03-23 12:01:19 +00:00
Yang Tse
34afb0b257
Change spelling, ONE_TERRABYTE -> ONE_TERABYTE
...
Shave off a couple of function calls in the part of
Curl_pgrsUpdate() which is always executed when called.
Fix a couple of comments.
2007-03-23 04:23:53 +00:00
Dan Fandrich
6bb9bd8b69
Don't shut down sftp in an error if it was never started.
2007-03-23 00:03:34 +00:00
Dan Fandrich
3229a80c9f
Fixed unused variable compiler warning.
2007-03-22 17:58:01 +00:00
Dan Fandrich
5eba84eed3
Use C99-style variadic macros when available.
2007-03-22 17:18:41 +00:00
Yang Tse
4fb483012c
Add a couple of local macros to improve code readability.
...
For completeness sake, wait_ms() might also get interrupted when
experimental CURL_ACKNOWLEDGE_EINTR is defined.
2007-03-22 15:32:28 +00:00
Yang Tse
90ce18019c
reverted back to previous version => http://curl.haxx.se/mail/lib-2007-03/0258.html
2007-03-21 13:09:39 +00:00
Yang Tse
fe10cb2ef5
avoid the use of variadic macros for greater portability
2007-03-21 08:17:13 +00:00
Yang Tse
842be6c52f
fix compiler warning: implicit conversion from "long" to "int"
2007-03-21 07:29:03 +00:00
Yang Tse
e4b754f64e
Fixed: When a signal was caught awaiting for an event using Curl_select()
...
or Curl_poll() with a non-zero timeout both functions would restart the
specified timeout. This could even lead to the extreme case that if a
signal arrived with a frecuency lower to the specified timeout neither
function would ever exit.
Added experimental symbol definition check CURL_ACKNOWLEDGE_EINTR in
Curl_select() and Curl_poll(). When compiled with CURL_ACKNOWLEDGE_EINTR
defined both functions will return as soon as a signal is caught. Use it
at your own risk, all calls to these functions in the library should be
revisited and checked before fully supporting this feature.
2007-03-20 20:00:40 +00:00
Gisle Vanem
34ed4642ec
Remove unneeded 'HAVE_*' defines.
2007-03-20 16:30:14 +00:00
Yang Tse
072a8b2955
Bryan Henderson fixed the progress function so that it can get called
...
more frequently allowing same calling frecuency for the client progress
callback, while keeping the once a second frecuency for speed calculations
and internal display of the transfer progress.
2007-03-19 12:02:33 +00:00
Yang Tse
da2b75a026
Fix compiler warning/error: ISO C90 forbids mixed declarations and code
2007-03-18 17:29:24 +00:00
Yang Tse
0e2d3b7b6c
Code refactoring, extracting a new function wait_ms() from Curl_select and
...
Curl_poll() which is called whenever not a single valid file descriptor is
passed to these functions.
Improve readibility using a poll() macro to replace WSApoll().
2007-03-18 04:51:40 +00:00
