Daniel Stenberg
1c3e8bbfed
checksrc: warn for assignments within if() expressions
...
... they're already frowned upon in our source code style guide, this
now enforces the rule harder.
2016-12-14 01:29:44 +01:00
Daniel Stenberg
8657c268e1
checksrc: white space edits to comply to stricter checksrc
2016-11-24 23:58:22 +01:00
Dan Fandrich
56bb7b1a3c
tests: fixed variable might be clobbered warning
...
This stops the compiler from potentially making invalid assumptions
about the immutability of sdp and sap across the longjmp boundary.
2016-11-12 12:37:24 +01:00
Daniel Stenberg
a332c4f769
tests/server: comply with our code style
2016-04-03 22:38:36 +02:00
Marc Hoersken
18c95d4bc0
tftpd server: add Windows support by writing files in binary mode
2015-12-23 13:04:00 +01:00
Daniel Stenberg
60c86297bf
tftp tests: verify sent options too
...
The tftpd test server now logs all received options and thus all TFTP
test cases need to match them exactly.
Extended test 283 to use and verify --tftp-blksize.
2015-11-06 10:55:30 +01:00
Markus Elfring
29c655c0a6
Bug #149 : Deletion of unnecessary checks before calls of the function "free"
...
The function "free" is documented in the way that no action shall occur for
a passed null pointer. It is therefore not needed that a function caller
repeats a corresponding check.
http://stackoverflow.com/questions/18775608/free-a-null-pointer-anyway-or-check-first
This issue was fixed by using the software Coccinelle 1.0.0-rc24.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
2015-03-16 12:13:56 +01:00
Steve Holme
1abe65d928
code/docs: Use Unix rather than UNIX to avoid use of the trademark
...
Use Unix when generically writing about Unix based systems as UNIX is
the trademark and should only be used in a particular product's name.
2014-12-26 21:42:44 +00:00
Dan Fandrich
9597b0ebcb
tests: Fix portability issue with the tftpd server and timeouts
...
gcc spit out warning: variable 'x' might be clobbered by 'longjmp' or
'vfork' messages for a few variables. These automatic variables were
expected to be changed between a setjmp/longjmp and hold their values,
so are now marked volatile.
2014-05-29 09:39:39 +02:00
Daniel Stenberg
06d1b10cbe
tftpd: support "writedelay" within <servercmd>
2013-08-22 19:23:08 +02:00
Daniel Stenberg
816b639035
tftpd: convert 6 global variables into local ones
2013-08-22 13:44:37 +02:00
Marc Hoersken
b4fae9d73f
tftpd.c: Apply sread timeout to the whole data transfer session
2013-04-06 19:00:42 +02:00
Marc Hoersken
9474c4a9a5
tftpd.c: Follow up cleanup and restore of previous sockopt
2013-04-06 17:18:41 +02:00
Marc Hoersken
a181e7b084
tftpd.c: Fixed sread timeout on Windows by setting it manually
2013-04-06 14:39:56 +02:00
Yang Tse
308cce8231
test servers: handle W32/W64 SIGBREAK with exit_signal_handler
2013-01-09 22:23:50 +01:00
Yang Tse
a6848250d2
test servers: fix errno, ERRNO and SOCKERRNO usage for W32/W64
2013-01-09 22:23:50 +01:00
Yang Tse
4a5aa6682d
Revert changes relative to lib/*.[ch] recent renaming
...
This reverts renaming and usage of lib/*.h header files done
28-12-2012, reverting 2 commits:
f871de0... build: make use of 76 lib/*.h renamed files
ffd8e12... build: rename 76 lib/*.h files
This also reverts removal of redundant include guard (redundant thanks
to changes in above commits) done 2-12-2013, reverting 1 commit:
c087374... curl_setup.h: remove redundant include guard
This also reverts renaming and usage of lib/*.c source files done
3-12-2013, reverting 3 commits:
13606bb... build: make use of 93 lib/*.c renamed files
5b6e792... build: rename 93 lib/*.c files
7d83dff... build: commit 13606bbfde
follow-up 1
Start of related discussion thread:
http://curl.haxx.se/mail/lib-2013-01/0012.html
Asking for confirmation on pushing this revertion commit:
http://curl.haxx.se/mail/lib-2013-01/0048.html
Confirmation summary:
http://curl.haxx.se/mail/lib-2013-01/0079.html
NOTICE: The list of 2 files that have been modified by other
intermixed commits, while renamed, and also by at least one
of the 6 commits this one reverts follows below. These 2 files
will exhibit a hole in history unless git's '--follow' option
is used when viewing logs.
lib/curl_imap.h
lib/curl_smtp.h
2013-01-06 18:20:27 +01:00
Yang Tse
f871de0064
build: make use of 76 lib/*.h renamed files
...
76 private header files renamed to use our standard naming scheme.
This change affects 322 files in libcurl's source tree.
2012-12-28 19:37:11 +01:00
Yang Tse
a0b207164c
setup_once.h: refactor inclusion of <unistd.h> and <sys/socket.h>
...
Inclusion of top two most included header files now done in setup_once.h
2012-12-14 17:38:18 +01:00
Yang Tse
4d3fb91fb4
test servers: build adjustment
...
Undefine CURL_HIDDEN_SYMBOLS libcurl private preprocessor macro that might
leak from lib/setup.h into source files where this should not be defined.
2012-04-10 17:32:06 +02:00
Daniel Stenberg
950fb3efcc
write: add return code checks when used
...
These were just warnings in test code but it still makes it nicer to not
generate them.
2011-06-11 23:01:09 +02:00
Dan Fandrich
c22c258029
Changed some nonportable types
2011-04-05 22:31:45 -07:00
Paul Howarth
1df74d886d
tftpd: avoid buffer overflow report from glibc
2010-12-17 19:08:43 +01:00
Yang Tse
a768e39b2d
test servers: fix strict aliasing compiler warnings
2010-11-19 19:20:38 +01:00
Daniel Stenberg
2309b4e330
remove the CVSish $Id$ lines
2010-03-24 11:02:54 +01:00
Yang Tse
439f62bfa8
convert Curl_ultous() and Curl_ultouc() functions to curlx_ultous() and
...
curlx_ultouc(), exposing them through curlx.h to allow proper code reuse
later in our test harness.
2010-02-22 18:56:29 +00:00
Yang Tse
048438345a
fix compiler warning
2010-02-19 18:02:38 +00:00
Yang Tse
6e461e45c3
fix compiler warning
2010-02-18 12:31:24 +00:00
Yang Tse
68d83a8142
Overhauled test suite getpart() function. Fixing potential out of bounds
...
stack and memory overwrites triggered with huge test case definitions.
2010-02-14 13:14:17 +00:00
Yang Tse
f47b84b57f
Validate server port argument
2010-02-04 17:17:19 +00:00
Yang Tse
232d17ec64
avoid possibility of using obsoleted stuff
2010-02-02 12:39:10 +00:00
Yang Tse
703fa98a48
PKTSIZE might have been already defined in arpa/tftp.h
2010-01-23 13:51:53 +00:00
Yang Tse
184f92d243
Remove extra line feed
2010-01-08 12:01:35 +00:00
Yang Tse
a114b7b1c0
sws and tftpd command line option naming adjustments
2010-01-08 01:48:54 +00:00
Yang Tse
d14bf09ab8
Fix 'uploaded' file descriptor leak
2009-12-03 20:37:49 +00:00
Yang Tse
2286f566d0
signal handling to cleanup on SIGINT and SIGTERM
2009-12-02 15:02:30 +00:00
Yang Tse
cbd527843b
Only attempt to clear the server-logs lock when previously set by this same server.
2009-11-26 10:15:08 +00:00
Yang Tse
094afbeb56
Enhance some debug messages for initialization failures.
...
Fix compiler warning: conditional expression is constant.
2009-11-23 16:11:50 +00:00
Yang Tse
ede2ac0ea2
Attempt to silence bogus compiler warning: "Potential null pointer dereference"
2009-09-17 15:33:32 +00:00
Yang Tse
3ca0b9bb47
fix compiler warning
2009-06-11 17:46:33 +00:00
Yang Tse
9137e717b0
Use build-time configured curl_socklen_t instead of socklen_t
2009-05-02 02:37:32 +00:00
Yang Tse
af41fb79b5
Include <arpa/inet.h> if HAVE_ARPA_INET_H is defined
2009-04-27 23:59:41 +00:00
Daniel Stenberg
082b0d822c
test 1099: "TFTP get first a non-existing file then an existing" added disabled
...
as things don't work right here!
2009-04-24 21:46:42 +00:00
Gunter Knauf
2b96c3f5ce
add back most likely acciedently removed function name justtimeout to fix autobuild breaks.
2009-04-09 02:46:56 +00:00
Gisle Vanem
59997ecad5
Avoid warnings when HAVE_ALRM and SIGALRM are not defined.
2009-04-08 18:37:11 +00:00
Yang Tse
068ba17e21
moved some definitions from tftp.h to tftpd.c
2008-10-23 14:34:08 +00:00
Yang Tse
4d10c96aa6
fix compiler warning
2008-10-23 14:07:28 +00:00
Yang Tse
e16bccbb91
attempt to fix compiler warning:
...
`variable' might be clobbered by `longjmp' or `vfork'
2008-10-14 17:35:25 +00:00
Yang Tse
445e4a9792
revert change introduced in tftpd.c revision 1.44
2008-10-03 03:42:44 +00:00
Yang Tse
26a651f7ae
fix compiler warning: variable' might be clobbered by
longjmp' or `vfork'
2008-10-02 13:28:10 +00:00