Viktor Szakats
d707a9fa64
windows: fix comparison of mismatched types warning
...
clang 10, mingw-w64:
```
vtls/openssl.c:2917:33: warning: comparison of integers of different signs: 'DWORD' (aka 'unsigned long') and 'HRESULT' (aka 'long')
[-Wsign-compare]
if(GetLastError() != CRYPT_E_NOT_FOUND)
~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~
```
Approved-by: Daniel Stenberg
Closes #6062
2020-10-12 10:18:53 +00:00
Viktor Szakats
c8ca705474
src/Makefile.m32: fix undefined curlx_dyn_* errors
...
by linking `lib/dynbuf.c` when building a static curl binary.
Previously this source file was only included when building
a dynamic curl binary. This was likely possibly because no
functions from the `src/Makefile.inc` / `CURLX_CFILES` sources
were actually required for a curl tool build. This has
recently changed with the introduction of `curlx_dyn_*()`
memory functions and their use by the tool sources.
Closes #6060
2020-10-11 23:42:18 +02:00
Daniel Stenberg
a4c26b0abe
HISTORY: curl verifies SSL certs by default since version 7.10
2020-10-09 17:29:33 +02:00
Marc Hoersken
1101fbbf49
runtests.pl: use $LIBDIR variable instead of hardcoded path
...
Reviewed-by: Daniel Stenberg
Closes #6051
2020-10-08 21:36:43 +02:00
Daniel Stenberg
7d8c89d47b
checksrc: detect // comments on column 0
...
Spotted while working on #6045
Closes #6048
2020-10-07 10:14:50 +02:00
Frederik Wedel-Heinen
bc5455fa74
mbedtls: add missing header when defining MBEDTLS_DEBUG
...
Closes #6045
2020-10-07 09:15:39 +02:00
Daniel Stenberg
ec1cb755bf
curl: make sure setopt CURLOPT_IPRESOLVE passes on a long
...
Previously, it would pass on a define (int) which could make libcurl
read junk as a value - which prevented the CURLOPT_IPRESOLVE option to
"take". This could then make test 2100 do two DoH requests instead of
one!
Fixes #6042
Closes #6043
2020-10-05 10:06:58 +02:00
Daniel Stenberg
d3a3cacd3d
RELEASE-NOTES: synced
2020-10-05 08:33:44 +02:00
Daniel Stenberg
06488441a5
scripts/release-notes.pl: don't "embed" $ in format string for printf()
...
... since they might contain %-codes that mess up the output!
2020-10-05 08:29:28 +02:00
M.R.T
af782db0e3
build-wolfssl: fix build with Visual Studio 2019
...
Closes https://github.com/curl/curl/pull/6033
2020-10-05 02:20:12 -04:00
Daniel Stenberg
b8e4d1cb0a
runtests: add %repeat[]% for test files
...
... and use this new keywords in all the test files larger than 50K to reduce
their sizes and make them a lot easier to read and understand.
Closes #6040
2020-10-04 17:16:53 +02:00
Emil Engler
639c6bfcfa
--help: move two options from the misc category
...
The cmdline opts delegation and suppress-connect-headers
fit better into auth and proxy rather than misc.
Follow-up to aa8777f63fCloses #6038
2020-10-03 22:59:50 +02:00
Samanta Navarro
2ead0ca482
docs/opts: fix typos in two manual pages
...
Closes #6039
2020-10-03 22:53:16 +02:00
Daniel Stenberg
6497ed45bd
ldap: reduce the amount of #ifdefs needed
...
Closes #6035
2020-10-03 22:49:39 +02:00
Daniel Stenberg
e6b21d422e
runtests: provide curl's version string as %VERSION for tests
...
... so that we can check HTTP requests for User-Agent: curl/%VERSION
Update 600+ test cases accordingly.
Closes #6037
2020-10-02 22:54:23 +02:00
Daniel Stenberg
26a7d51c21
checksrc: warn on space after exclamation mark
...
Closes #6034
2020-10-02 16:35:53 +02:00
Daniel Stenberg
ddecd28268
test1465: verify --libcurl with binary POST data
2020-10-02 09:35:38 +02:00
Daniel Stenberg
2dd53e82f1
runtests: allow generating a binary sequence from hex
2020-10-02 09:35:38 +02:00
Daniel Stenberg
01327600e3
tool_setopt: escape binary data to hex, not octal
2020-10-02 09:35:37 +02:00
Daniel Stenberg
3997b3e2a4
curl: make --libcurl show binary posts correctly
...
Reported-by: Stephan Mühlstrasser
Fixes #6031
Closes #6032
2020-10-02 09:35:37 +02:00
Jay Satiro
9a13f7c2a7
strerror: fix null deref on winapi out-of-memory
...
Follow-up to bed5f84https://github.com/curl/curl/pull/6005
2020-10-01 13:34:59 -04:00
Kamil Dudka
7920be9473
vtls: deduplicate some DISABLE_PROXY ifdefs
...
... in the code of gtls, nss, and openssl
Closes #5735
2020-10-01 16:36:24 +02:00
Daniel Stenberg
ce95c5e013
RELEASE-NOTES: synced
2020-10-01 09:19:11 +02:00
Emil Engler
6603917c3a
TODO: Add OpenBSD libtool notice
...
See #5862
Closes #6030
2020-09-30 22:48:31 +02:00
Daniel Stenberg
8aeb82eeca
tests/unit/README: convert to markdown
...
... and add to dist!
Closes #6028
2020-09-30 22:45:48 +02:00
Daniel Stenberg
422f610b40
tests/README: convert to markdown
...
Closes #6028
2020-09-30 22:45:45 +02:00
Daniel Stenberg
d0c77730ed
include/README: convert to markdown
...
Closes #6028
2020-09-30 22:45:41 +02:00
Daniel Stenberg
7b9e3c4b4c
examples/README: convert to markdown
...
Closes #6028
2020-09-30 22:45:29 +02:00
Daniel Stenberg
c8204ed6a2
configure: don't say HTTPS-proxy is enabled when disabled!
...
Reported-by: Kamil Dudka
Reviewed-by: Kamil Dudka
Bug: https://github.com/curl/curl/pull/5735#issuecomment-701376388
Closes #6029
2020-09-30 22:43:43 +02:00
Daniel Gustafsson
2aac895fb6
src: Consistently spell whitespace without whitespace
...
Whitespace is spelled without a space between white and space, so
make sure to consistently spell it that way across the codebase.
Closes #6023
Reviewed-by: Daniel Stenberg <daniel@haxx.se>
Reviewed-by: Emil Engler <me@emilengler.com>
2020-09-30 21:10:14 +02:00
Daniel Gustafsson
021f2c25fd
MANUAL: update examples to resolve without redirects
...
www.netscape.com is redirecting to a cookie consent form on Aol, and
cool.haxx.se isn't responding to FTP anymore. Replace with examples
that resolves in case users try out the commands when reading the
manual.
Closes #6024
Reviewed-by: Daniel Stenberg <daniel@haxx.se>
Reviewed-by: Emil Engler <me@emilengler.com>
2020-09-30 21:05:14 +02:00
Daniel Stenberg
025b20971c
HISTORY: add some 2020 events
2020-09-30 13:44:32 +02:00
Daniel Stenberg
b312e3238f
sectransp: make it build with --disable-proxy
...
Follow-up from #5466 and f3d501dc67Fixes #6025
Closes #6026
2020-09-30 10:32:17 +02:00
Daniel Stenberg
cbe7fad20d
ECH: renamed from ESNI in docs and configure
...
Encrypted Client Hello (ECH) is the current name.
Closes #6022
2020-09-29 11:23:23 +02:00
Daniel Stenberg
83c6493296
configure: use "no" instead of "disabled" for the end summary
...
... for consistency but also to make them more distinctly stand out next
to the "enabled" lines.
2020-09-29 11:01:45 +02:00
Daniel Stenberg
a7de1c0d81
TODO: SSH over HTTPS proxy with more backends
...
... as right now only the libssh2 backend supports it.
2020-09-29 07:50:15 +02:00
Daniel Stenberg
edfb6168e9
libssh2: handle the SSH protocols done over HTTPS proxy
...
Reported-by: Robin Douine
Fixes #4295
Closes #6021
2020-09-29 07:50:07 +02:00
Emil Engler
82d66f1582
memdebug: remove 9 year old unused debug function
...
There used to be a way to have memdebug fill allocated memory. 9 years
later this has no value there (valgrind and ASAN etc are way better). If
people need to know about it they can have a look at VCS logs.
Closes #5973
2020-09-28 22:15:21 +02:00
Daniel Stenberg
a87cca7b1c
sendf: move Curl_sendf to dict.c and make it static
...
... as the only remaining user of that function. Also fix gopher.c to
instead use Curl_write()
Closes #6020
2020-09-28 17:05:53 +02:00
Daniel Stenberg
422b257fef
ROADMAP: updates and cleanups
...
Fix the HSTS PR
Remove DoT, thread-safe init and hard-coded localhost. I feel very
little interest for these with users so I downgrade them to plain "TODO"
entries again.
2020-09-28 17:03:20 +02:00
Daniel Stenberg
abeeffb11c
schannel: return CURLE_PEER_FAILED_VERIFICATION for untrusted root
...
This matches what is returned in other TLS backends in the same
situation.
Reviewed-by: Jay Satiro
Reviewed-by: Emil Engler
Follow-up to 5a3efb1Fixes #6003
Closes #6018
2020-09-28 10:41:51 +02:00
Daniel Stenberg
1e3c52fba7
RELEASE-NOTES: synced
2020-09-26 13:39:37 +02:00
Daniel Stenberg
4a4c724599
ftp: make a 552 response return CURLE_REMOTE_DISK_FULL
...
Added test 348 to verify. Added a 'STOR' command to the test FTP
server to enable test 348. Documented the command in FILEFORMAT.md
Reported-by: Duncan Wilcox
Fixes #6016
Closes #6017
2020-09-26 13:37:15 +02:00
Daniel Stenberg
7772344e17
pause: only trigger a reread if the unpause sticks
...
As an unpause might itself get paused again and then triggering another
reread doesn't help.
Follow-up from e040146f22https://curl.haxx.se/mail/lib-2020-09/0081.html
Patch-by: Kunal Chandarana
Fixes #5988
Closes #6013
2020-09-25 15:18:10 +02:00
Daniel Stenberg
11522d7292
test163[12]: require http to be built-in to run
...
... as speaking over an HTTPS proxy implies http!
Closes #6014
2020-09-25 14:29:45 +02:00
Daniel Stenberg
3d60a22390
ngtcp2: adapt to new NGTCP2_PROTO_VER_MAX define
...
Closes #6012
2020-09-25 08:59:43 +02:00
Javier Blazquez
bed5f8454a
strerror: honor Unicode API choice on Windows
...
Closes #6005
2020-09-25 08:55:35 +02:00
Daniel Stenberg
c4693adc62
imap: make imap_send use dynbuf for the send buffer management
...
Reuses the buffer and thereby reduces number of mallocs over a transfer.
Closes #6010
2020-09-25 08:35:01 +02:00
Daniel Stenberg
92a9b88ebf
Curl_send: return error when pre_receive_plain can't malloc
...
... will probably trigger some false DEAD CODE positives on non-windows
code analyzers for the conditional code.
Closes #6011
2020-09-25 08:31:52 +02:00
Daniel Stenberg
1397a7de6e
ftp: separate FTPS from FTP over "HTTPS proxy"
...
When using HTTPS proxy, SSL is used but not in the view of the FTP
protocol handler itself so separate the connection's use of SSL from the
FTP control connection's sue.
Reported-by: Mingtao Yang
Fixes #5523
Closes #6006
2020-09-24 14:09:20 +02:00
