Daniel Stenberg
0bb6deda72
TFTP: don't ack if wrong block num is received
...
If an unexpected block number was received, break out of the
switch loop.
2010-05-21 23:07:59 +02:00
Daniel Stenberg
0a29e2445c
TFTP: block id wrap bug fix
...
In a normal expression, doing [unsigned short] + 1 will not wrap
at 16 bits so the comparisons and outputs were done wrong. I
added a macro do make sure it gets done right.
Douglas Kilpatrick filed bug report #3004787 about it:
http://curl.haxx.se/bug/view.cgi?id=3004787
2010-05-21 23:04:15 +02:00
Daniel Stenberg
aabd27d9aa
TFTP: send timeout option correctly
...
Eric Mertens posted bug report #3003005 pointing out that the
libcurl TFTP code was not sending the timeout option properly to
the server, and suggested a fix.
(http://curl.haxx.se/bug/view.cgi?id=3003005 )
2010-05-18 23:14:00 +02:00
Daniel Stenberg
c0111460b0
Curl_setup_transfer: no longer returns anything
...
This function could only return CURLE_OK and by changing it to
a void instead, we can simplify code all over.
2010-04-16 23:43:04 +02:00
Daniel Stenberg
313a5b05c2
tftp_rx: Value stored to 'sbytes' is never read
2010-04-16 22:55:07 +02:00
Ben Greear
7de44e0a42
Make rate-limitation logic smoother
...
This gives a smoother rate limitation performance by using
sub-second pauses and also taking the buffer sizes into
account.
2010-03-26 23:33:02 +01:00
Daniel Stenberg
2309b4e330
remove the CVSish $Id$ lines
2010-03-24 11:02:54 +01:00
Ben Greear
ad76d58e7f
Fix tftp return codes and tsize upload handling
...
Error codes were not properly returned to the main curl code (and on to apps
using libcurl).
tftp was crapping out when tsize == 0 on upload, but I see no reason to fail
to upload just because the remote file is zero-length. Ignore tsize option on
upload.
2010-03-21 23:24:36 +01:00
Daniel Stenberg
6728334edb
fix warning about conversions between curl_off_t and long
2010-03-18 21:52:31 +00:00
Daniel Stenberg
e262aaae2b
- Ben Greear brought a patch that fixed the rate limiting logic for TFTP when
...
the easy interface was used.
2010-03-06 18:42:06 +00:00
Daniel Stenberg
53aa6b21fe
- Ben Greear provided an update for TFTP that fixes upload.
2010-03-01 22:14:47 +00:00
Yang Tse
7aef172a34
fix printf-style format strings
2010-02-04 19:44:31 +00:00
Yang Tse
d65cf7889b
fix printf-style format strings
2010-01-28 15:34:18 +00:00
Yang Tse
6e5acc2fc1
make tftp_translate_code() static, it is only used from within tftp.c
2010-01-21 14:44:28 +00:00
Yang Tse
230dc699e2
s/socklen_t/curl_socklen_t/g
2009-11-28 04:34:46 +00:00
Yang Tse
3f6854272f
Fix compiler warning: unused variable `data'
2009-11-28 03:00:32 +00:00
Daniel Stenberg
6e38cc9048
- Markus Koetter provided a polished and updated version of Chad Monroe's TFTP
...
rework patch that now integrates TFTP properly into libcurl so that it can
be used non-blocking with the multi interface and more. BLKSIZE also works.
The --tftp-blksize option was added to allow setting the TFTP BLKSIZE from
the command line.
2009-11-27 23:46:29 +00:00
Yang Tse
59939313f8
Make usage of calloc()'s arguments consistent with rest of code base
2009-11-18 10:33:54 +00:00
Daniel Stenberg
966cb698e6
- Carsten Lange reported a bug and provided a patch for TFTP upload and the
...
sending of the TSIZE option. I don't like fixing bugs just hours before
a release, but since it was broken and the patch fixes this for him I decided
to get it in anyway.
2009-08-12 08:19:39 +00:00
Gunter Knauf
8570883412
changes to silent compiler warnings with 64bit systems.
2009-07-24 22:20:22 +00:00
Gunter Knauf
1d5627b181
changes to silent compiler warnings with 64bit systems.
2009-07-24 22:06:19 +00:00
Gunter Knauf
038fff6c9f
changes to silent compiler warnings with 64bit systems.
2009-07-23 04:53:08 +00:00
Gunter Knauf
21dd9a8021
fixed brace error.
2009-07-23 03:54:01 +00:00
Gunter Knauf
59934c1176
changes to silent compiler warnings with 64bit systems.
2009-07-23 02:48:05 +00:00
Yang Tse
f13cbcf175
fix compiler warning: unused parameter
2009-05-28 16:18:25 +00:00
Yang Tse
b8c438f22d
Fix function call pointed data size argument mismatch on 64Bit systems
2009-05-10 10:25:23 +00:00
Daniel Stenberg
7bdd14a994
- Vijay G filed bug report #2723236
...
(http://curl.haxx.se/bug/view.cgi?id=2723236 ) identifying a problem with
libcurl's TFTP code and its lack of dealing with the OACK packet.
2009-05-07 08:30:43 +00:00
Yang Tse
9137e717b0
Use build-time configured curl_socklen_t instead of socklen_t
2009-05-02 02:37:32 +00:00
Daniel Stenberg
e2c6e00570
- Based on bug report #2723219 ( http://curl.haxx.se/bug/view.cgi?id=2723219 )
...
I've now made TFTP "connections" not being kept for re-use within libcurl.
TFTP is UDP-based so the benefit was really low (if even existing) to begin
with so instead of tracking down to fix this problem we instead removed the
re-use. I also enabled test case 1099 that I wrote a few days ago to verify
that this change fixes the reported problem.
2009-04-29 11:30:03 +00:00
Yang Tse
33a3753c3f
libcurl's memory.h renamed to curl_memory.h
2009-04-21 11:46:16 +00:00
Gisle Vanem
8925527fef
In MSVC9 'time_t' is a 64-bit quantity. This causes a truncation warning
...
when an 'int' is assigned to a 'time_t' variable. Hence redefine 'retry_time'
and 'retry_max' to 'time_t'.
2009-02-14 13:43:18 +00:00
Yang Tse
6e34c2d59a
fix compiler warning: conversion from 'int' to 'bool', possible loss of data
2009-01-28 17:43:11 +00:00
Yang Tse
34b09398d5
fix compiler warning: enumerated type mixed with another type
2009-01-28 17:26:26 +00:00
Daniel Stenberg
0516ce7786
- Chad Monroe provided the new CURLOPT_TFTP_BLKSIZE option that allows an app
...
to set desired block size to use for TFTP transfers instead of the default
512 bytes.
2009-01-26 22:43:06 +00:00
Dan Fandrich
5591550167
Fixed a couple more locale-dependent toupper conversions, mainly for
...
clarity. This does fix one problem that causes ;type=i FTP URLs
to fail in the Turkish locale when CURLOPT_PROXY_TRANSFER_MODE is
used (test case 561)
Added tests 561 and 1092 through 1094 to test various combinations
of ;type= and ;mode= URLs that could potentially fail in the Turkish
locale.
2009-01-21 04:42:47 +00:00
Daniel Stenberg
1225d36188
Grant Erickson fixed timeouts for TFTP
2009-01-13 23:24:06 +00:00
Daniel Stenberg
07416b61e3
- Using the libssh2 0.19 function libssh2_session_block_directions(), libcurl
...
now has an improved ability to do right when the multi interface (both
"regular" and multi_socket) is used for SCP and SFTP transfers. This should
result in (much) less busy-loop situations and thus less CPU usage with no
speed loss.
2008-12-19 21:14:52 +00:00
Dan Fandrich
ea8fbb5233
Added some #ifdefs around header files and change the EAGAIN test to
...
fix compilation on Cell (reported by Jeff Curley).
2008-11-14 23:17:32 +00:00
Dan Fandrich
8f467b4288
Removed unneeded includes of signal.h and setjmp.h
2008-09-29 21:44:50 +00:00
Dan Fandrich
0994d7811f
Removed some redundant type casts
2008-09-02 18:36:39 +00:00
Yang Tse
537490e391
Undo using the sreadfrom() wrapper to replace recvfrom() in our code.
2008-07-30 05:10:42 +00:00
Yang Tse
775d9e0615
fix compiler warning: comparison between signed and unsigned
2008-07-21 03:59:23 +00:00
Yang Tse
1b37baf656
Use the sreadfrom() wrapper to replace recvfrom() in our code.
2008-07-21 03:06:07 +00:00
Daniel Stenberg
fcc320ee40
Yang Tse pointed out a few remaining quirks from my timeout refactoring from
...
Feb 7 that didn't abort properly on timeouts. These are actually old
problems but now they should be fixed.
2008-02-11 22:03:31 +00:00
Dan Fandrich
44fba11b34
Fixed unused variable warning.
2008-02-11 18:27:36 +00:00
Daniel Stenberg
1b701c746f
- Refactored a lot of timeout code into a few functions in an attempt to make
...
them all use the same (hopefully correct) logic to make it less error-prone
and easier to introduce library-wide where it should be used.
2008-02-07 22:25:04 +00:00
Daniel Stenberg
ed6466d176
Calls to Curl_failf() are not supposed to provide a trailing newline as the
...
function itself adds that. Fixed on 50 or something strings!
2008-01-15 23:19:02 +00:00
Yang Tse
15f832d1c2
fix compiler warning
2008-01-09 19:11:56 +00:00
Daniel Stenberg
662bee7193
All static functions that were previously name Curl_* something no longer
...
use that prefix as we use that prefix only for library-wide internal global
symbols.
2007-12-08 22:50:55 +00:00
Daniel Stenberg
162c039e9d
reqdata doesn't exist anymore and the path moved to the UrlState struct
2007-11-24 23:18:21 +00:00