From ff318a6302a92ffb627ebffb397e8dc2420a96c0 Mon Sep 17 00:00:00 2001
From: Daniel Stenberg <daniel@haxx.se>
Date: Fri, 13 Jul 2012 23:39:25 +0200
Subject: [PATCH] getparam: fix the GetStr() macro

It should return PARAM_NO_MEM if the strdup fails. Spotted by
clang-analyzer
---
 src/tool_getparam.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/tool_getparam.c b/src/tool_getparam.c
index 579437eb7..685c224de 100644
--- a/src/tool_getparam.c
+++ b/src/tool_getparam.c
@@ -56,10 +56,11 @@
     free(*(str)); \
     *(str) = NULL; \
   } \
-  if((val)) \
+  if((val)) {              \
     *(str) = strdup((val)); \
-  if(!(val)) \
-    return PARAM_NO_MEM; \
+    if(!(*(str)))          \
+      return PARAM_NO_MEM; \
+  } \
 } WHILE_FALSE
 
 struct LongShort {