1
0
mirror of https://github.com/moparisthebest/curl synced 2024-08-13 17:03:50 -04:00

curl: exit the create_transfers loop on errors

When looping around the ranges and given URLs to create transfers, all
errors should exit the loop and return. Previously it would keep
looping.

Reported-by: SumatraPeter on github
Bug: #4393
Closes #4396
This commit is contained in:
Daniel Stenberg 2019-09-21 23:46:41 +02:00
parent 5ee88eee68
commit f8a2058533
No known key found for this signature in database
GPG Key ID: 5CC908FDB71E12C2

View File

@ -1885,15 +1885,9 @@ static CURLcode create_transfers(struct GlobalConfig *global,
urls = NULL;
}
if(infilenum > 1) {
/* when file globbing, exit loop upon critical error */
if(is_fatal_error(result))
break;
}
else if(result)
/* when not file globbing, exit loop upon any error */
if(result)
/* exit loop upon error */
break;
} /* loop to the next globbed upload file */
/* Free loop-local allocated memory */
@ -1913,6 +1907,9 @@ static CURLcode create_transfers(struct GlobalConfig *global,
Curl_safefree(urlnode->infile);
urlnode->flags = 0;
if(result)
/* exit loop upon error */
break;
} /* for-loop through all URLs */
quit_curl: