moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2024-08-13 17:03:50 -04:00
Code Issues Releases Wiki Activity

darwinssl: Fix realloc memleak

Browse Source 
The reallocation was using the input pointer for the return value, which
leads to a memory leak on reallication failure. Fix by instead use the
safe internal API call Curl_saferealloc().

Closes #3005
Reviewed-by: Daniel Stenberg <daniel@haxx.se>
Reviewed-by: Nick Zitzmann <nickzman@gmail.com>
This commit is contained in:
Daniel Gustafsson 2018-09-18 09:06:07 +02:00
parent 23524bf85b
commit ed7830061e
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/vtls/darwinssl.c
View File

@ -120,6 +120,7 @@
#include "vtls.h"
#include "darwinssl.h"
#include "curl_printf.h"
#include "strdup.h"
#include "curl_memory.h"
/* The last #include file should be: */
@ -2056,7 +2057,7 @@ static int read_cert(const char *file, unsigned char **out, size_t *outlen)
if(len + n >= cap) {
cap *= 2;
data = realloc(data, cap);
data = Curl_saferealloc(data, cap);
if(!data) {
close(fd);
return -1;