mirror of https://github.com/moparisthebest/curl
pop3_perform_authentication: fix memory leak
Coverity CID 1215287. There's a potential risk for a memory leak in here, and moving the free call to be unconditional seems like a cheap price to remove the risk.
This commit is contained in:
parent
a9beeeeeea
commit
ea6c5f03a5
|
@ -560,8 +560,6 @@ static CURLcode pop3_perform_authentication(struct connectdata *conn)
|
||||||
if(mech && (pop3c->preftype & POP3_TYPE_SASL)) {
|
if(mech && (pop3c->preftype & POP3_TYPE_SASL)) {
|
||||||
/* Perform SASL based authentication */
|
/* Perform SASL based authentication */
|
||||||
result = pop3_perform_auth(conn, mech, initresp, len, state1, state2);
|
result = pop3_perform_auth(conn, mech, initresp, len, state1, state2);
|
||||||
|
|
||||||
Curl_safefree(initresp);
|
|
||||||
}
|
}
|
||||||
#ifndef CURL_DISABLE_CRYPTO_AUTH
|
#ifndef CURL_DISABLE_CRYPTO_AUTH
|
||||||
else if((pop3c->authtypes & POP3_TYPE_APOP) &&
|
else if((pop3c->authtypes & POP3_TYPE_APOP) &&
|
||||||
|
@ -580,6 +578,8 @@ static CURLcode pop3_perform_authentication(struct connectdata *conn)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Curl_safefree(initresp);
|
||||||
|
|
||||||
return result;
|
return result;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue