moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2025-02-28 09:21:50 -05:00
Code Issues Releases Wiki Activity

http: add missing return code check

Browse Source 
Detected by Coverity. CID 1439610.

Follow-up from 46e164069d1a523

Closes #3034
This commit is contained in:
Daniel Stenberg 2018-09-22 22:32:47 +02:00
parent 30b2d07b03
commit e407e79c29
No known key found for this signature in database
GPG Key ID: 5CC908FDB71E12C2
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/http.c
View File

@ -2453,8 +2453,6 @@ CURLcode Curl_http(struct connectdata *conn, bool *done)
if(conn->bits.httpproxy && !conn->bits.tunnel_proxy) { if(conn->bits.httpproxy && !conn->bits.tunnel_proxy) {
char *url = data->change.url; char *url = data->change.url;
result = Curl_add_buffer(&req_buffer, url, strlen(url)); result = Curl_add_buffer(&req_buffer, url, strlen(url));
if(result)
return result;
} }
else if(paste_ftp_userpwd) else if(paste_ftp_userpwd)
result = Curl_add_bufferf(&req_buffer, "ftp://%s:%s@%s", result = Curl_add_bufferf(&req_buffer, "ftp://%s:%s@%s",
@ -2464,12 +2462,11 @@ CURLcode Curl_http(struct connectdata *conn, bool *done)
result = Curl_add_buffer(&req_buffer, path, strlen(path)); result = Curl_add_buffer(&req_buffer, path, strlen(path));
if(result) if(result)
return result; return result;
if(query) { if(query)
result = Curl_add_bufferf(&req_buffer, "?%s", query); result = Curl_add_bufferf(&req_buffer, "?%s", query);
if(result)
return result;
}
} }
if(result)
return result;
result = result =
Curl_add_bufferf(&req_buffer, Curl_add_bufferf(&req_buffer,