moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2024-12-22 08:08:50 -05:00
Code Issues Releases Wiki Activity

Ralf S. Engelschall filed bug report #1757328

Browse Source 
(http://curl.haxx.se/bug/view.cgi?id=1757328) and submitted a patch. It turns
out we broke login to FTP servers that don't require (nor understand) PASS
after the USER command
This commit is contained in:
Daniel Stenberg 2007-07-20 09:35:58 +00:00
parent 2ab854cafd
commit e3377e637a
3 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
CHANGES
View File

@ -6,6 +6,14 @@
Changelog Changelog
Daniel S (20 July 2007)
- Ralf S. Engelschall filed bug report #1757328
(http://curl.haxx.se/bug/view.cgi?id=1757328) and submitted a patch. It
turns out we broke login to FTP servers that don't require (nor understand)
PASS after the USER command. The breakage was done as part of the krb5
commit so a krb-using person needs to verify that the current version now
works or if we need to fix it (in a different way of course).
Dan F (17 July 2007) Dan F (17 July 2007)
- Fixed test cases 613 and 614 by improving the log postprocessor to handle - Fixed test cases 613 and 614 by improving the log postprocessor to handle
a new directory listing format that newer libssh2's can provide. This a new directory listing format that newer libssh2's can provide. This

7
RELEASE-NOTES
View File

@ -22,7 +22,9 @@ This release includes the following bugfixes:
o CONNECT endless loop o CONNECT endless loop
o krb5 support builds with Heimdal o krb5 support builds with Heimdal
o added returned error string for connection refused case o added returned error string for connection refused case
o re-use of dead control connections o re-use of dead FTP control connections
o login to FTP servers that don't require (nor understand) PASS after the
USER command.
This release includes the following known bugs: This release includes the following known bugs:
@ -40,6 +42,7 @@ This release would not have looked like this without help, code, reports and
advice from friends like these: advice from friends like these:
Dan Fandrich, Song Ma, Daniel Black, Giancarlo Formicuccia, Shmulik Regev, Dan Fandrich, Song Ma, Daniel Black, Giancarlo Formicuccia, Shmulik Regev,
Daniel Cater, Colin Hogben, Jofell Gallardo Daniel Cater, Colin Hogben, Jofell Gallardo, Daniel Johnson,
Ralf S. Engelschall
Thanks! (and sorry if I forgot to mention someone) Thanks! (and sorry if I forgot to mention someone)

2
lib/ftp.c
View File

@ -2372,7 +2372,7 @@ static CURLcode ftp_state_user_resp(struct connectdata *conn,
(void)instate; /* no use for this yet */ (void)instate; /* no use for this yet */
/* some need password anyway, and others just return 2xx ignored */ /* some need password anyway, and others just return 2xx ignored */
if((ftpcode == 331 || ftpcode/100 == 2) && (ftpc->state == FTP_USER)) { if((ftpcode == 331) && (ftpc->state == FTP_USER)) {
/* 331 Password required for ... /* 331 Password required for ...
(the server requires to send the user's password too) */ (the server requires to send the user's password too) */
NBFTPSENDF(conn, "PASS %s", ftp->passwd?ftp->passwd:""); NBFTPSENDF(conn, "PASS %s", ftp->passwd?ftp->passwd:"");