From deadb2348f40e7afa46a03a918f522c67145ebe0 Mon Sep 17 00:00:00 2001 From: Marcel Raad Date: Sat, 8 Jul 2017 17:44:34 +0200 Subject: [PATCH] curl-compilers.m4: disable warning spam with Cygwin's clang When building with Cygwin or MinGW, libtool uses a wrapper executable instead of a wrapper script [1], which is written in C and throws missing-variable-declarations warnings. Don't enable these warnings on Cygwin and MinGW in order to avoid warnings for every executable built, which spams the test suite output when using Cygwin's clang. [1] https://www.gnu.org/software/libtool/manual/html_node/Wrapper-executables.html Closes https://github.com/curl/curl/pull/1665 --- m4/curl-compilers.m4 | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/m4/curl-compilers.m4 b/m4/curl-compilers.m4 index dcd96ed54..3c87efa09 100644 --- a/m4/curl-compilers.m4 +++ b/m4/curl-compilers.m4 @@ -903,7 +903,15 @@ AC_DEFUN([CURL_SET_COMPILER_WARNING_OPTS], [ # dnl Only clang 3.2 or later if test "$compiler_num" -ge "302"; then - tmp_CFLAGS="$tmp_CFLAGS -Wmissing-variable-declarations" + case $host_os in + cygwin* | mingw*) + dnl skip missing-variable-declarations warnings for cygwin and + dnl mingw because the libtool wrapper executable causes them + ;; + *) + tmp_CFLAGS="$tmp_CFLAGS -Wmissing-variable-declarations" + ;; + esac fi # dnl Only clang 3.6 or later