moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2024-12-23 00:28:48 -05:00
Code Issues Releases Wiki Activity

tool_urlglob.c: Silence warning C6293: Ill-defined for-loop

Browse Source 
The >= 0 is actually not required, since i underflows and
the for-loop is stopped using the < condition, but this
makes the VS2012 compiler and code analysis happy.
This commit is contained in:
Marc Hoersken 2014-12-14 22:45:06 +01:00
parent 2ffbd7afac
commit d8efde07e5
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/tool_urlglob.c
View File

@ -466,7 +466,7 @@ void glob_cleanup(URLGlob* glob)
int elem; int elem;
/* the < condition is required since i underflows! */ /* the < condition is required since i underflows! */
for(i = glob->size - 1; i < glob->size; --i) { for(i = glob->size - 1; i >= 0 && i < glob->size; --i) {
if((glob->pattern[i].type == UPTSet) && if((glob->pattern[i].type == UPTSet) &&
(glob->pattern[i].content.Set.elements)) { (glob->pattern[i].content.Set.elements)) {
for(elem = glob->pattern[i].content.Set.size - 1; for(elem = glob->pattern[i].content.Set.size - 1;
@ -500,7 +500,7 @@ int glob_next_url(char **globbed, URLGlob *glob)
/* implement a counter over the index ranges of all patterns, /* implement a counter over the index ranges of all patterns,
starting with the rightmost pattern */ starting with the rightmost pattern */
/* the < condition is required since i underflows! */ /* the < condition is required since i underflows! */
for(i = glob->size - 1; carry && (i < glob->size); --i) { for(i = glob->size - 1; carry && i >= 0 && (i < glob->size); --i) {
carry = FALSE; carry = FALSE;
pat = &glob->pattern[i]; pat = &glob->pattern[i];
switch (pat->type) { switch (pat->type) {