if Curl_hash_add() returns NULL, we shall not free the addrinfo field as that

is made in the hash function in the case of failure (using the already setup
'dtor' function).
This commit is contained in:
Daniel Stenberg 2003-12-15 15:22:10 +00:00
parent 947e656367
commit cfe53768dd
1 changed files with 3 additions and 3 deletions

View File

@ -237,10 +237,10 @@ cache_resolv_response(struct SessionHandle *data,
/* Store the resolved data in our DNS cache. This function may return a
pointer to an existing struct already present in the hash, and it may
return the same argument we pass in. Make no assumptions. */
dns = Curl_hash_add(data->hostcache, entry_id, entry_len+1, (void *) dns);
dns = Curl_hash_add(data->hostcache, entry_id, entry_len+1, (void *)dns);
if(!dns) {
/* major badness, run away! */
Curl_freeaddrinfo(addr);
/* Major badness, run away. When this happens, the 'dns' data has
already been cleared up by Curl_hash_add(). */
free(entry_id);
return NULL;
}