moparisthebest
/
curl
mirror of https://github.com/moparisthebest/curl
1
0
Fork 0
Code Issues Releases Wiki Activity

openssl: Fix uninitialized variable use in NPN callback 

OpenSSL passes out and outlen variable uninitialized to
select_next_proto_cb callback function.  If the callback function
returns SSL_TLSEXT_ERR_OK, the caller assumes the callback filled
values in out and outlen and processes as such.  Previously, if there
is no overlap in protocol lists, curl code does not fill any values in
these variables and returns SSL_TLSEXT_ERR_OK, which means we are
triggering undefined behavior.  valgrind warns this.

This patch fixes this issue by fallback to HTTP/1.1 if there is no
overlap.
This commit is contained in:
Tatsuhiro Tsujikawa 2014-05-21 23:34:55 +09:00 committed by Daniel Stenberg
parent 3b65aeda52
commit c7638d93b0
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/vtls/openssl.c
View File

@ -1440,7 +1440,11 @@ select_next_proto_cb(SSL *ssl,
conn->negnpn = NPN_HTTP1_1;
}
else {
infof(conn->data, "NPN, no overlap, negotiated nothing\n");
infof(conn->data, "NPN, no overlap, use HTTP1.1\n",
NGHTTP2_PROTO_VERSION_ID);
*out = (unsigned char*)"http/1.1";
*outlen = sizeof("http/1.1") - 1;
conn->negnpn = NPN_HTTP1_1;
}
return SSL_TLSEXT_ERR_OK;