moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2024-12-21 23:58:49 -05:00
Code Issues Releases Wiki Activity

cookie: do not refuse cookies for localhost

Browse Source 
Closes #658
This commit is contained in:
Tim Rühsen 2016-03-02 11:07:16 +01:00 committed by Kamil Dudka
parent cb222bcfef
commit c140bd7891
3 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
RELEASE-NOTES
View File

@ -31,6 +31,7 @@ This release includes the following bugfixes:
o gtls: fix for builds lacking encrypted key file support [11] o gtls: fix for builds lacking encrypted key file support [11]
o SCP: use libssh2_scp_recv2 to support > 2GB files on windows [12] o SCP: use libssh2_scp_recv2 to support > 2GB files on windows [12]
o CURLOPT_CONNECTTIMEOUT_MS.3: Fix example to use milliseconds option [13] o CURLOPT_CONNECTTIMEOUT_MS.3: Fix example to use milliseconds option [13]
o cookie: do not refuse cookies to localhost [14]
This release includes the following known bugs: This release includes the following known bugs:
@ -62,3 +63,4 @@ References to bug reports and discussions on issues:
[11] = https://curl.haxx.se/bug/?i=651 [11] = https://curl.haxx.se/bug/?i=651
[12] = https://curl.haxx.se/bug/?i=451 [12] = https://curl.haxx.se/bug/?i=451
[13] = https://curl.haxx.se/bug/?i=653 [13] = https://curl.haxx.se/bug/?i=653
[14] = https://curl.haxx.se/bug/?i=658

10
lib/cookie.c
View File

@ -797,10 +797,12 @@ Curl_cookie_add(struct SessionHandle *data,
#ifdef USE_LIBPSL #ifdef USE_LIBPSL
/* Check if the domain is a Public Suffix and if yes, ignore the cookie. /* Check if the domain is a Public Suffix and if yes, ignore the cookie.
This needs a libpsl compiled with builtin data. */ This needs a libpsl compiled with builtin data. */
if(co->domain && !isip(co->domain) && (psl = psl_builtin()) != NULL) { if(domain && co->domain && !isip(co->domain)) {
if(psl_is_public_suffix(psl, co->domain)) { if(((psl = psl_builtin()) != NULL)
infof(data, "cookie '%s' dropped, domain '%s' is a public suffix\n", && !psl_is_cookie_domain_acceptable(psl, domain, co->domain)) {
co->name, co->domain); infof(data,
"cookie '%s' dropped, domain '%s' must not set cookies for '%s'\n",
co->name, domain, co->domain);
freecookie(co); freecookie(co);
return NULL; return NULL;
} }

1
tests/data/test1136
View File

@ -58,6 +58,7 @@ http://www.example.ck/1136 http://www.ck/1136 http://z-1.compute-1.amazonaws.com
.www.example.ck TRUE / FALSE 0 test2 allowed2 .www.example.ck TRUE / FALSE 0 test2 allowed2
.www.ck TRUE / FALSE 0 test4 allowed4 .www.ck TRUE / FALSE 0 test4 allowed4
.z-1.compute-1.amazonaws.com TRUE / FALSE 0 test5 forbidden5
</file> </file>
</verify> </verify>
</testcase> </testcase>