moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2024-12-21 23:58:49 -05:00
Code Issues Releases Wiki Activity

checksrc: add ASTERISKSPACE

Browse Source 
Verifies a 'char *name' style, with no space after the asterisk.
This commit is contained in:
Daniel Stenberg 2016-11-23 07:52:38 +01:00
parent 74ffa040a4
commit bc7e08471c
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/checksrc.pl
View File

@ -55,7 +55,8 @@ my %warnings = (
'COPYRIGHT' => 'file missing a copyright statement', 'COPYRIGHT' => 'file missing a copyright statement',
'BADCOMMAND' => 'bad !checksrc! instruction', 'BADCOMMAND' => 'bad !checksrc! instruction',
'UNUSEDIGNORE' => 'a warning ignore was not used', 'UNUSEDIGNORE' => 'a warning ignore was not used',
'OPENCOMMENT' => 'file ended with a /* comment still "open"' 'OPENCOMMENT' => 'file ended with a /* comment still "open"',
'ASTERISKSPACE' => 'pointer declared with space after asterisk'
); );
sub readwhitelist { sub readwhitelist {
@ -471,6 +472,12 @@ sub scanfile {
} }
} }
# check for 'char * name'
if(($l =~ /(^.*(char|int|long|void|curl_slist|CURL|CURLM|CURLMsg|curl_httppost) *\*) (\w+)/) && ($3 ne "const")) {
checkwarn("ASTERISKSPACE",
$line, length($1), $file, $ol,
"no space after declarative asterisk");
}
$line++; $line++;
$prevl = $ol; $prevl = $ol;
} }