From b4beb3b1157a441e4eb6601f9a45d4237a15357b Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Thu, 14 Feb 2019 11:48:43 +0100 Subject: [PATCH] examples: remove superfluous null-pointer checks in ftpget, ftpsget and sftpget, so that scan-build stops warning for potential NULL pointer dereference below! Detected by scan-build --- docs/examples/ftpget.c | 4 ++-- docs/examples/ftpsget.c | 4 ++-- docs/examples/sftpget.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/examples/ftpget.c b/docs/examples/ftpget.c index a2a7da0ce..fc7ab4a39 100644 --- a/docs/examples/ftpget.c +++ b/docs/examples/ftpget.c @@ -5,7 +5,7 @@ * | (__| |_| | _ <| |___ * \___|\___/|_| \_\_____| * - * Copyright (C) 1998 - 2017, Daniel Stenberg, , et al. + * Copyright (C) 1998 - 2019, Daniel Stenberg, , et al. * * This software is licensed as described in the file COPYING, which * you should have received as part of this distribution. The terms @@ -36,7 +36,7 @@ struct FtpFile { static size_t my_fwrite(void *buffer, size_t size, size_t nmemb, void *stream) { struct FtpFile *out = (struct FtpFile *)stream; - if(out && !out->stream) { + if(!out->stream) { /* open file for writing */ out->stream = fopen(out->filename, "wb"); if(!out->stream) diff --git a/docs/examples/ftpsget.c b/docs/examples/ftpsget.c index fb7489f03..91162e624 100644 --- a/docs/examples/ftpsget.c +++ b/docs/examples/ftpsget.c @@ -5,7 +5,7 @@ * | (__| |_| | _ <| |___ * \___|\___/|_| \_\_____| * - * Copyright (C) 1998 - 2015, 2017, Daniel Stenberg, , et al. + * Copyright (C) 1998 - 2019, Daniel Stenberg, , et al. * * This software is licensed as described in the file COPYING, which * you should have received as part of this distribution. The terms @@ -38,7 +38,7 @@ static size_t my_fwrite(void *buffer, size_t size, size_t nmemb, void *stream) { struct FtpFile *out = (struct FtpFile *)stream; - if(out && !out->stream) { + if(!out->stream) { /* open file for writing */ out->stream = fopen(out->filename, "wb"); if(!out->stream) diff --git a/docs/examples/sftpget.c b/docs/examples/sftpget.c index 44a3caf2e..e5a74b9ec 100644 --- a/docs/examples/sftpget.c +++ b/docs/examples/sftpget.c @@ -5,7 +5,7 @@ * | (__| |_| | _ <| |___ * \___|\___/|_| \_\_____| * - * Copyright (C) 1998 - 2017, Daniel Stenberg, , et al. + * Copyright (C) 1998 - 2019, Daniel Stenberg, , et al. * * This software is licensed as described in the file COPYING, which * you should have received as part of this distribution. The terms @@ -47,7 +47,7 @@ static size_t my_fwrite(void *buffer, size_t size, size_t nmemb, void *stream) { struct FtpFile *out = (struct FtpFile *)stream; - if(out && !out->stream) { + if(!out->stream) { /* open file for writing */ out->stream = fopen(out->filename, "wb"); if(!out->stream)