1
0
mirror of https://github.com/moparisthebest/curl synced 2024-12-23 16:48:49 -05:00

file2memory: use a define instead of -1 unsigned value

... to use the maximum value for 'size_t' when detecting integer overflow.
Changed the limit to max/4 as already that seems unreasonably large.

Codacy didn't like the previous approach.

Closes #5683
This commit is contained in:
Daniel Stenberg 2020-07-15 14:04:32 +02:00
parent 954cd3eb48
commit b331a5fa09
No known key found for this signature in database
GPG Key ID: 5CC908FDB71E12C2

View File

@ -115,8 +115,8 @@ ParameterError file2memory(char **bufp, size_t *size, FILE *file)
size_t alloc = 512;
do {
if(!buffer || (alloc == nused)) {
/* size_t overflow detection for huge files */
if(alloc + 1 > ((size_t)-1)/2) {
/* size_t overflow detection and avoiding huge files */
if(alloc >= (SIZE_T_MAX/4)) {
Curl_safefree(buffer);
return PARAM_NO_MEM;
}