moparisthebest/curl
1
0
Fork 0
mirror of https://github.com/moparisthebest/curl synced 2024-12-24 17:18:48 -05:00
Code Issues Releases Wiki Activity

smtp: overwriting 'from' leaks memory

Browse Source 
Detected by Coverity. CID 1418139.

Also, make sure to return error if the new 'from' allocation fails.

Closes #4997
This commit is contained in:
Daniel Stenberg 2020-02-28 09:49:02 +01:00
parent ea1b2eb976
commit aeb292301a
No known key found for this signature in database
GPG Key ID: 5CC908FDB71E12C2
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/smtp.c
View File

@ -625,6 +625,7 @@ static CURLcode smtp_perform_mail(struct connectdata *conn)
utf8 = TRUE; utf8 = TRUE;
if(host.name) { if(host.name) {
free(from);
from = aprintf("<%s@%s>", address, host.name); from = aprintf("<%s@%s>", address, host.name);
Curl_free_idnconverted_hostname(&host); Curl_free_idnconverted_hostname(&host);
@ -635,6 +636,8 @@ static CURLcode smtp_perform_mail(struct connectdata *conn)
auth = aprintf("<%s>", address); auth = aprintf("<%s>", address);
free(address); free(address);
if(!from)
return CURLE_OUT_OF_MEMORY;
} }
else else
/* Empty AUTH, RFC-2554, sect. 5 */ /* Empty AUTH, RFC-2554, sect. 5 */