diff --git a/lib/url.c b/lib/url.c index dd3f62d9c..48016e2ba 100644 --- a/lib/url.c +++ b/lib/url.c @@ -5453,11 +5453,16 @@ static CURLcode parse_remote_port(struct Curl_easy *data, *portptr = '\0'; /* cut off the name there */ conn->remote_port = curlx_ultous(port); } - else + else { + if(rest[0]) { + failf(data, "Illegal port number"); + return CURLE_URL_MALFORMAT; + } /* Browser behavior adaptation. If there's a colon with no digits after, just cut off the name there which makes us ignore the colon and just use the default port. Firefox and Chrome both do that. */ *portptr = '\0'; + } } /* only if remote_port was not already parsed off the URL we use the diff --git a/tests/data/Makefile.inc b/tests/data/Makefile.inc index 370c3dd45..deabaacc5 100644 --- a/tests/data/Makefile.inc +++ b/tests/data/Makefile.inc @@ -129,7 +129,7 @@ test1228 test1229 test1230 test1231 test1232 test1233 test1234 test1235 \ test1236 test1237 test1238 test1239 test1240 test1241 test1242 test1243 \ test1244 test1245 test1246 test1247 \ \ -test1280 \ +test1280 test1281 \ \ test1300 test1301 test1302 test1303 test1304 test1305 test1306 test1307 \ test1308 test1309 test1310 test1311 test1312 test1313 test1314 test1315 \ diff --git a/tests/data/test1281 b/tests/data/test1281 new file mode 100644 index 000000000..6226f8698 --- /dev/null +++ b/tests/data/test1281 @@ -0,0 +1,35 @@ + + + +URL + + + +# +# Server-side + + + + + +# Client-side + + +none + + +reject non-numerical port number in URL + + +http://%HOSTIP:alpha/beta/1281 + + + +# Verify data after the test has been "shot" + +# 3 == CURLE_URL_MALFORMAT + +3 + + +